diff mbox series

[-next] staging: r8188eu: use 'is_zero_ether_addr' to identify an empty address

Message ID 20220704123140.100128-1-zhangzekun11@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] staging: r8188eu: use 'is_zero_ether_addr' to identify an empty address | expand

Commit Message

zhangzekun (A) July 4, 2022, 12:31 p.m. UTC 
Use 'is_zero_ether_addr' to identify an empty ethernet address, intead
of using 'memcpy' directly.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
---
 drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Greg KH July 4, 2022, 1:27 p.m. UTC | #1 
On Mon, Jul 04, 2022 at 12:31:40PM +0000, Zhang Zekun wrote:
> Use 'is_zero_ether_addr' to identify an empty ethernet address, intead
> of using 'memcpy' directly.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>

I am now just going to ignore all patch submissions with this line in it
based on a total lack of responses by the developers using it.  See
https://lore.kernel.org/r/Yr7DQJTPrSWTOa0c@kroah.com for why.

greg k-h
Greg KH July 4, 2022, 1:38 p.m. UTC | #2 
On Mon, Jul 04, 2022 at 03:27:01PM +0200, Greg KH wrote:
> On Mon, Jul 04, 2022 at 12:31:40PM +0000, Zhang Zekun wrote:
> > Use 'is_zero_ether_addr' to identify an empty ethernet address, intead
> > of using 'memcpy' directly.
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> 
> I am now just going to ignore all patch submissions with this line in it
> based on a total lack of responses by the developers using it.  See
> https://lore.kernel.org/r/Yr7DQJTPrSWTOa0c@kroah.com for why.

And now just ignore patches from your domain, see:
	https://lore.kernel.org/r/YsLq5vXtJgLWCqqz@kroah.com
for why (patches sent totally ignoring previous requests.)

Please work with the open source developers in your company to fix this
broken process, as it is causing more problems for me than it is worth.

greg k-h
diff mbox series

Patch

diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index cce0575e93b7..365f5b2786cf 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -3513,7 +3513,6 @@  static unsigned int on_action_public_p2p(struct recv_frame *precv_frame)
 	u32	p2p_ielen;
 	struct	wifidirect_info	*pwdinfo = &padapter->wdinfo;
 	u8	result = P2P_STATUS_SUCCESS;
-	u8	empty_addr[ETH_ALEN] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
 
 	frame_body = (unsigned char *)(pframe + sizeof(struct ieee80211_hdr_3addr));
 
@@ -3551,7 +3550,7 @@  static unsigned int on_action_public_p2p(struct recv_frame *precv_frame)
 
 		/*	Commented by Kurt 20120113 */
 		/*	Get peer_dev_addr here if peer doesn't issue prov_disc frame. */
-		if (!memcmp(pwdinfo->rx_prov_disc_info.peerDevAddr, empty_addr, ETH_ALEN))
+		if (is_zero_ether_addr(pwdinfo->rx_prov_disc_info.peerDevAddr))
 			memcpy(pwdinfo->rx_prov_disc_info.peerDevAddr, GetAddr2Ptr(pframe), ETH_ALEN);
 
 		result = process_p2p_group_negotation_req(pwdinfo, frame_body, len);