[net-next,v2,0/5] PolarFire SoC macb reset support

Message

Conor Dooley July 4, 2022, 11:45 a.m. UTC

Hey all,
Jakub requested that these patches be split off from the series
adding the reset controller itself that I sent ~yesterday~ last
week [0].

The Cadence MACBs on PolarFire SoC (MPFS) have reset capability and are
compatible with the zynqmp's init function. I have removed the zynqmp
specific comments from that function & renamed it to reflect what it
does, since it is no longer zynqmp only.

MPFS's MACB had previously used the generic binding, so I also added
the required specific binding.

For v2, I noticed some low hanging cleanup fruit so there are extra
patches added for that:
moving the init function out of the config structs, aligning the
alignment of the zynqmp & default config structs with the other dozen
or so structs & simplifing the error paths to use dev_err_probe().

Feel free to apply as many or as few of those as you like.

Thanks,
Conor.

Changes since v1:
- added the 3 aforementioned cleanup patches
- fixed two stylistic complaints from Claudiu

Conor Dooley (5):
  dt-bindings: net: cdns,macb: document polarfire soc's macb
  net: macb: add polarfire soc reset support
  net: macb: unify macb_config alignment style
  net: macb: simplify error paths in init_reset_optional()
  net: macb: sort init_reset_optional() with other init()s

 .../devicetree/bindings/net/cdns,macb.yaml    |   1 +
 drivers/net/ethernet/cadence/macb_main.c      | 106 +++++++++---------
 2 files changed, 56 insertions(+), 51 deletions(-)

Comments

Claudiu Beznea July 5, 2022, 7:20 a.m. UTC | #1

On 04.07.2022 14:45, Conor Dooley wrote:
> Hey all,
> Jakub requested that these patches be split off from the series
> adding the reset controller itself that I sent ~yesterday~ last
> week [0].
> 
> The Cadence MACBs on PolarFire SoC (MPFS) have reset capability and are
> compatible with the zynqmp's init function. I have removed the zynqmp
> specific comments from that function & renamed it to reflect what it
> does, since it is no longer zynqmp only.
> 
> MPFS's MACB had previously used the generic binding, so I also added
> the required specific binding.
> 
> For v2, I noticed some low hanging cleanup fruit so there are extra
> patches added for that:
> moving the init function out of the config structs, aligning the
> alignment of the zynqmp & default config structs with the other dozen
> or so structs & simplifing the error paths to use dev_err_probe().
> 
> Feel free to apply as many or as few of those as you like.

Other than minor comment on patch 3/5:

Reviewed-by: Claudiu Beznea <[e-mail]>


> 
> Thanks,
> Conor.
> 
> Changes since v1:
> - added the 3 aforementioned cleanup patches
> - fixed two stylistic complaints from Claudiu
> 
> Conor Dooley (5):
>   dt-bindings: net: cdns,macb: document polarfire soc's macb
>   net: macb: add polarfire soc reset support
>   net: macb: unify macb_config alignment style
>   net: macb: simplify error paths in init_reset_optional()
>   net: macb: sort init_reset_optional() with other init()s
> 
>  .../devicetree/bindings/net/cdns,macb.yaml    |   1 +
>  drivers/net/ethernet/cadence/macb_main.c      | 106 +++++++++---------
>  2 files changed, 56 insertions(+), 51 deletions(-)
>