mbox series

[v3,0/2] Fix IPI device emulation for LoongArch machine

Message ID 20220705064901.2353349-1-yangxiaojuan@loongson.cn (mailing list archive)
Headers show
Series Fix IPI device emulation for LoongArch machine | expand

Message

Xiaojuan Yang July 5, 2022, 6:48 a.m. UTC 
Fix LoongArch IPI device emulation follwing Richard's advice based on v2 version:
1. Change ipi64_ops' valid.min_access_size to 8, as it only support 8 bytes writing.
2. Remove 'UL' prefix in send_ipi_data().
3. Add a condition to skip the method of geting write mask in send_ipi_data(), as the mask is 0 at most time.

Xiaojuan Yang (2):
  hw/intc/loongarch_ipi: Fix ipi device access of 64bits
  hw/intc/loongarch_ipi: Fix mail send and any send function

 hw/intc/loongarch_ipi.c         | 92 ++++++++++++++++++++++-----------
 hw/loongarch/loongson3.c        |  5 +-
 include/hw/intc/loongarch_ipi.h |  7 +--
 3 files changed, 70 insertions(+), 34 deletions(-)

Comments

Richard Henderson July 5, 2022, 10:54 a.m. UTC | #1 
On 7/5/22 12:18, Xiaojuan Yang wrote:
> Fix LoongArch IPI device emulation follwing Richard's advice based on v2 version:
> 1. Change ipi64_ops' valid.min_access_size to 8, as it only support 8 bytes writing.
> 2. Remove 'UL' prefix in send_ipi_data().
> 3. Add a condition to skip the method of geting write mask in send_ipi_data(), as the mask is 0 at most time.
> 
> Xiaojuan Yang (2):
>    hw/intc/loongarch_ipi: Fix ipi device access of 64bits
>    hw/intc/loongarch_ipi: Fix mail send and any send function
> 
>   hw/intc/loongarch_ipi.c         | 92 ++++++++++++++++++++++-----------
>   hw/loongarch/loongson3.c        |  5 +-
>   include/hw/intc/loongarch_ipi.h |  7 +--
>   3 files changed, 70 insertions(+), 34 deletions(-)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Applied.


r~