| Message ID | 20220701192300.2293643-5-conor@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Canaan devicetree fixes | expand |
On 01-07-22, 20:22, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The Canaan k210 apparently has a Sysnopsys Designware AXI DMA > controller, but according to the documentation & devicetree it has 6 > interrupts rather than the standard one. Support the 6 interrupt > configuration by unconditionally extending the binding to a maximum of > 8 per-channel interrupts thereby matching the number of possible > channels. > > Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51 > Reviewed-by: Serge Semin <fancer.lancer@gmail.com> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > index 4324a94b26b2..98c2ab18d04f 100644 > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > @@ -34,7 +34,12 @@ properties: > - const: axidma_apb_regs > > interrupts: > - maxItems: 1 > + description: | rob asked you to drop this in last patch, pls fix that and send with his ack > + If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this > + will be per-channel interrupts. Otherwise, this is a single combined IRQ > + for all channels. > + minItems: 1 > + maxItems: 8 > > clocks: > items: > -- > 2.37.0
On 05/07/2022 13:46, Vinod Koul wrote: > On 01-07-22, 20:22, Conor Dooley wrote: >> From: Conor Dooley <conor.dooley@microchip.com> >> >> The Canaan k210 apparently has a Sysnopsys Designware AXI DMA >> controller, but according to the documentation & devicetree it has 6 >> interrupts rather than the standard one. Support the 6 interrupt >> configuration by unconditionally extending the binding to a maximum of >> 8 per-channel interrupts thereby matching the number of possible >> channels. >> >> Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51 >> Reviewed-by: Serge Semin <fancer.lancer@gmail.com> >> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> >> --- >> .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml >> index 4324a94b26b2..98c2ab18d04f 100644 >> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml >> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml >> @@ -34,7 +34,12 @@ properties: >> - const: axidma_apb_regs >> >> interrupts: >> - maxItems: 1 >> + description: | > > rob asked you to drop this in last patch, pls fix that and send with his > ack Yeah, I was a bit gung-ho & sent before v4 with other fixes prior to his review of v3. I didn't intentionally ignore him :) I'll resend later tonight. Thanks, Conor. > >> + If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this >> + will be per-channel interrupts. Otherwise, this is a single combined IRQ >> + for all channels. >> + minItems: 1 >> + maxItems: 8 >> >> clocks: >> items: >> -- >> 2.37.0 >
diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml index 4324a94b26b2..98c2ab18d04f 100644 --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml @@ -34,7 +34,12 @@ properties: - const: axidma_apb_regs interrupts: - maxItems: 1 + description: | + If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this + will be per-channel interrupts. Otherwise, this is a single combined IRQ + for all channels. + minItems: 1 + maxItems: 8 clocks: items: