| Message ID | 20220705114032.22787-7-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: QMP PHY fixes | expand |
On 05/07/2022 14:40, Johan Hovold wrote: > The QMP USB PHY provides a single clock so drop the redundant clock > index. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > -- With best wishes Dmitry
On 05/07/2022 14:40, Johan Hovold wrote: > The QMP USB PHY provides a single clock so drop the redundant clock > index. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> However please note https://lore.kernel.org/linux-arm-msm/20220620071936.1558906-3-dmitry.baryshkov@linaro.org/ (for this and the last patch). > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 758c45bbbe78..2511e70d66ef 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -2080,7 +2080,7 @@ usb1_ssphy: phy@c010200 { > <0xc010600 0x128>, > <0xc010800 0x200>; > #phy-cells = <0>; > - #clock-cells = <1>; > + #clock-cells = <0>; > clocks = <&gcc GCC_USB3_PHY_PIPE_CLK>; > clock-names = "pipe0"; > clock-output-names = "usb3_phy_pipe_clk_src";
On Tue, Jul 05, 2022 at 04:09:14PM +0300, Dmitry Baryshkov wrote: > On 05/07/2022 14:40, Johan Hovold wrote: > > The QMP USB PHY provides a single clock so drop the redundant clock > > index. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > However please note > https://lore.kernel.org/linux-arm-msm/20220620071936.1558906-3-dmitry.baryshkov@linaro.org/ > (for this and the last patch). Ah, I had not seen that one. Bjorn appears to have applied your series before this one so these two patches became empty and were dropped. Thanks for reviewing! Johan
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 758c45bbbe78..2511e70d66ef 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2080,7 +2080,7 @@ usb1_ssphy: phy@c010200 { <0xc010600 0x128>, <0xc010800 0x200>; #phy-cells = <0>; - #clock-cells = <1>; + #clock-cells = <0>; clocks = <&gcc GCC_USB3_PHY_PIPE_CLK>; clock-names = "pipe0"; clock-output-names = "usb3_phy_pipe_clk_src";
The QMP USB PHY provides a single clock so drop the redundant clock index. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)