diff mbox series

keys/keyring: Fix typo in string

Message ID 20220704025610.3834-1-zeming@nfschina.com (mailing list archive)
State Handled Elsewhere
Headers show
Series keys/keyring: Fix typo in string | expand

Commit Message

Li zeming July 4, 2022, 2:56 a.m. UTC
Remove the repeated ',' from string

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 security/keys/keyring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Howells July 5, 2022, 1:32 p.m. UTC | #1
Li zeming <zeming@nfschina.com> wrote:

> -	kenter("{%s,%d},,{%zu/%zu}",
> +	kenter("{%s,%d},{%zu/%zu}",
>  	       key->type->name, key->serial, ctx->count, ctx->buflen);

This changed, so yes, it can be fixed.

> -	kenter("{%d},,%zu", key_serial(keyring), buflen);
> +	kenter("{%d},%zu", key_serial(keyring), buflen);

This one's not a typo.

David
Jarkko Sakkinen July 11, 2022, 2:52 a.m. UTC | #2
On Mon, Jul 04, 2022 at 10:56:10AM +0800, Li zeming wrote:
> Remove the repeated ',' from string
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  security/keys/keyring.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/keys/keyring.c b/security/keys/keyring.c
> index 5e6a90760753..c6c47ca9b57d 100644
> --- a/security/keys/keyring.c
> +++ b/security/keys/keyring.c
> @@ -460,7 +460,7 @@ static int keyring_read_iterator(const void *object, void *data)
>  	struct keyring_read_iterator_context *ctx = data;
>  	const struct key *key = keyring_ptr_to_key(object);
>  
> -	kenter("{%s,%d},,{%zu/%zu}",
> +	kenter("{%s,%d},{%zu/%zu}",
>  	       key->type->name, key->serial, ctx->count, ctx->buflen);
>  
>  	if (ctx->count >= ctx->buflen)
> @@ -484,7 +484,7 @@ static long keyring_read(const struct key *keyring,
>  	struct keyring_read_iterator_context ctx;
>  	long ret;
>  
> -	kenter("{%d},,%zu", key_serial(keyring), buflen);
> +	kenter("{%d},%zu", key_serial(keyring), buflen);
>  
>  	if (buflen & (sizeof(key_serial_t) - 1))
>  		return -EINVAL;
> -- 
> 2.18.2
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko
diff mbox series

Patch

diff --git a/security/keys/keyring.c b/security/keys/keyring.c
index 5e6a90760753..c6c47ca9b57d 100644
--- a/security/keys/keyring.c
+++ b/security/keys/keyring.c
@@ -460,7 +460,7 @@  static int keyring_read_iterator(const void *object, void *data)
 	struct keyring_read_iterator_context *ctx = data;
 	const struct key *key = keyring_ptr_to_key(object);
 
-	kenter("{%s,%d},,{%zu/%zu}",
+	kenter("{%s,%d},{%zu/%zu}",
 	       key->type->name, key->serial, ctx->count, ctx->buflen);
 
 	if (ctx->count >= ctx->buflen)
@@ -484,7 +484,7 @@  static long keyring_read(const struct key *keyring,
 	struct keyring_read_iterator_context ctx;
 	long ret;
 
-	kenter("{%d},,%zu", key_serial(keyring), buflen);
+	kenter("{%d},%zu", key_serial(keyring), buflen);
 
 	if (buflen & (sizeof(key_serial_t) - 1))
 		return -EINVAL;