[net,0/7] mptcp: Path manager fixes for 5.19

Message

Mat Martineau July 5, 2022, 9:32 p.m. UTC

The MPTCP userspace path manager is new in 5.19, and these patches fix
some issues in that new code.

Patches 1-3 fix path manager locking issues.

Patches 4 and 5 allow userspace path managers to change priority of
established subflows using the existing MPTCP_PM_CMD_SET_FLAGS generic
netlink command. Includes corresponding self test update.

Patches 6 and 7 fix accounting of available endpoint IDs and the
MPTCP_MIB_RMSUBFLOW counter.

Geliang Tang (1):
  mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy

Kishen Maloor (2):
  mptcp: netlink: issue MP_PRIO signals from userspace PMs
  selftests: mptcp: userspace PM support for MP_PRIO signals

Mat Martineau (2):
  mptcp: Avoid acquiring PM lock for subflow priority changes
  mptcp: Acquire the subflow socket lock before modifying MP_PRIO flags

Paolo Abeni (2):
  mptcp: fix locking in mptcp_nl_cmd_sf_destroy()
  mptcp: fix local endpoint accounting

 net/mptcp/options.c                           |  3 +
 net/mptcp/pm_netlink.c                        | 46 ++++++++----
 net/mptcp/pm_userspace.c                      | 51 +++++++++----
 net/mptcp/protocol.c                          |  9 ++-
 net/mptcp/protocol.h                          |  9 ++-
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 73 ++++++++++++++++++-
 .../selftests/net/mptcp/userspace_pm.sh       | 32 ++++++++
 7 files changed, 192 insertions(+), 31 deletions(-)


base-commit: 029cc0963412c4f989d2731759ce4578f7e1a667

Comments

Jakub Kicinski July 6, 2022, 1 a.m. UTC | #1

On Tue,  5 Jul 2022 14:32:10 -0700 Mat Martineau wrote:
> The MPTCP userspace path manager is new in 5.19, and these patches fix
> some issues in that new code.

Two questions looking at patchwork checks:

Is userspace_pm.sh not supposed to be included in the Makefile 
so that it's run by all the CIs that execute selftests?

Is it possible to CC folks who authored patches under Fixes?
Sorry if I already asked about this. I'm trying to work on refining 
the CC check in patchwork but I'm a little ambivalent about adding
this one to exceptions.

Those are sort of independent of the series, no need to repost.

[e-mail] July 6, 2022, noon UTC | #2

Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <[e-mail]>:

On Tue,  5 Jul 2022 14:32:10 -0700 you wrote:
> The MPTCP userspace path manager is new in 5.19, and these patches fix
> some issues in that new code.
> 
> Patches 1-3 fix path manager locking issues.
> 
> Patches 4 and 5 allow userspace path managers to change priority of
> established subflows using the existing MPTCP_PM_CMD_SET_FLAGS generic
> netlink command. Includes corresponding self test update.
> 
> [...]

Here is the summary with links:
  - [net,1/7] mptcp: fix locking in mptcp_nl_cmd_sf_destroy()
    https://git.kernel.org/netdev/net/c/5ccecaec5c1e
  - [net,2/7] mptcp: Avoid acquiring PM lock for subflow priority changes
    https://git.kernel.org/netdev/net/c/c21b50d5912b
  - [net,3/7] mptcp: Acquire the subflow socket lock before modifying MP_PRIO flags
    https://git.kernel.org/netdev/net/c/a657430260e5
  - [net,4/7] mptcp: netlink: issue MP_PRIO signals from userspace PMs
    https://git.kernel.org/netdev/net/c/892f396c8e68
  - [net,5/7] selftests: mptcp: userspace PM support for MP_PRIO signals
    https://git.kernel.org/netdev/net/c/ca188a25d43f
  - [net,6/7] mptcp: fix local endpoint accounting
    https://git.kernel.org/netdev/net/c/843b5e75efff
  - [net,7/7] mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy
    https://git.kernel.org/netdev/net/c/d2d21f175f1f

You are awesome, thank you!

Mat Martineau July 6, 2022, 5:14 p.m. UTC | #3

On Tue, 5 Jul 2022, Jakub Kicinski wrote:

> On Tue,  5 Jul 2022 14:32:10 -0700 Mat Martineau wrote:
>> The MPTCP userspace path manager is new in 5.19, and these patches fix
>> some issues in that new code.
>
> Two questions looking at patchwork checks:
>
> Is userspace_pm.sh not supposed to be included in the Makefile
> so that it's run by all the CIs that execute selftests?

Thanks for noticing that, we have a patch in process now to fix it.

>
> Is it possible to CC folks who authored patches under Fixes?
> Sorry if I already asked about this. I'm trying to work on refining
> the CC check in patchwork but I'm a little ambivalent about adding
> this one to exceptions.

Yes, I do try to do that. Note that Geliang changed his email address, so 
the check script flags his old address though he is cc'd. This is the 
recurring source of most of those red 'fail' blobs in patchwork for MPTCP 
series.

Does your script use the .mailmap file from the kernel repo? Maybe I can 
ask Geliang about adding an entry there.

(I did also forget to add my coworker Kishen to part of the series this 
time, sorry about that)

--
Mat Martineau
Intel

Jakub Kicinski July 6, 2022, 8:20 p.m. UTC | #4

On Wed, 6 Jul 2022 10:14:21 -0700 (PDT) Mat Martineau wrote:
> > Is it possible to CC folks who authored patches under Fixes?
> > Sorry if I already asked about this. I'm trying to work on refining
> > the CC check in patchwork but I'm a little ambivalent about adding
> > this one to exceptions.  
> 
> Yes, I do try to do that. Note that Geliang changed his email address, so 
> the check script flags his old address though he is cc'd. This is the 
> recurring source of most of those red 'fail' blobs in patchwork for MPTCP 
> series.
> 
> Does your script use the .mailmap file from the kernel repo? Maybe I can 
> ask Geliang about adding an entry there.

That my next TODO item. I'm planning to include a local alias map as
well because I have a suspicion that chasing people to update .mailmap
will be a hassle.

> (I did also forget to add my coworker Kishen to part of the series this 
> time, sorry about that)