| Message ID | c62c1774e6a34bc64323ce526b385aa87c1ca575.1657049799.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ee4c0c5d2593d5f694447f4053076cdc23e606c9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | sfc: falcon: Use the bitmap API to allocate bitmaps | expand |
On Tue, Jul 05, 2022 at 09:36:51PM +0200, Christophe JAILLET wrote: > Use bitmap_zalloc()/bitmap_free() instead of hand-writing them. > > It is less verbose and it improves the semantic. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Martin Habets <habetsm.xilinx@gmail.com> > --- > drivers/net/ethernet/sfc/falcon/farch.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/falcon/farch.c b/drivers/net/ethernet/sfc/falcon/farch.c > index 2c91792cec01..c64623c2e80c 100644 > --- a/drivers/net/ethernet/sfc/falcon/farch.c > +++ b/drivers/net/ethernet/sfc/falcon/farch.c > @@ -2711,7 +2711,7 @@ void ef4_farch_filter_table_remove(struct ef4_nic *efx) > enum ef4_farch_filter_table_id table_id; > > for (table_id = 0; table_id < EF4_FARCH_FILTER_TABLE_COUNT; table_id++) { > - kfree(state->table[table_id].used_bitmap); > + bitmap_free(state->table[table_id].used_bitmap); > vfree(state->table[table_id].spec); > } > kfree(state); > @@ -2740,9 +2740,7 @@ int ef4_farch_filter_table_probe(struct ef4_nic *efx) > table = &state->table[table_id]; > if (table->size == 0) > continue; > - table->used_bitmap = kcalloc(BITS_TO_LONGS(table->size), > - sizeof(unsigned long), > - GFP_KERNEL); > + table->used_bitmap = bitmap_zalloc(table->size, GFP_KERNEL); > if (!table->used_bitmap) > goto fail; > table->spec = vzalloc(array_size(sizeof(*table->spec), > -- > 2.34.1
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 5 Jul 2022 21:36:51 +0200 you wrote: > Use bitmap_zalloc()/bitmap_free() instead of hand-writing them. > > It is less verbose and it improves the semantic. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/net/ethernet/sfc/falcon/farch.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Here is the summary with links: - sfc: falcon: Use the bitmap API to allocate bitmaps https://git.kernel.org/netdev/net-next/c/ee4c0c5d2593 You are awesome, thank you!
diff --git a/drivers/net/ethernet/sfc/falcon/farch.c b/drivers/net/ethernet/sfc/falcon/farch.c index 2c91792cec01..c64623c2e80c 100644 --- a/drivers/net/ethernet/sfc/falcon/farch.c +++ b/drivers/net/ethernet/sfc/falcon/farch.c @@ -2711,7 +2711,7 @@ void ef4_farch_filter_table_remove(struct ef4_nic *efx) enum ef4_farch_filter_table_id table_id; for (table_id = 0; table_id < EF4_FARCH_FILTER_TABLE_COUNT; table_id++) { - kfree(state->table[table_id].used_bitmap); + bitmap_free(state->table[table_id].used_bitmap); vfree(state->table[table_id].spec); } kfree(state); @@ -2740,9 +2740,7 @@ int ef4_farch_filter_table_probe(struct ef4_nic *efx) table = &state->table[table_id]; if (table->size == 0) continue; - table->used_bitmap = kcalloc(BITS_TO_LONGS(table->size), - sizeof(unsigned long), - GFP_KERNEL); + table->used_bitmap = bitmap_zalloc(table->size, GFP_KERNEL); if (!table->used_bitmap) goto fail; table->spec = vzalloc(array_size(sizeof(*table->spec),
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them. It is less verbose and it improves the semantic. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/sfc/falcon/farch.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)