| Message ID | 20220706174253.4175492-1-yury.norov@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | lib: cleanup bitmap-related headers | expand |
On Wed, Jul 6, 2022 at 10:42 AM Yury Norov <yury.norov@gmail.com> wrote: > > This series unifies declarations of bitmap-related functions and aligns > return types with values that actually returned. Also, it moves one-liner > wrappers around cpumask functions into headers, so that compiler has a > chance to optimize better. > > With this series, GCC 11.2 for ARM64 with kernel v5.19-rc4: > add/remove: 15/7 grow/shrink: 461/164 up/down: 14844/-4580 (10264) > > This +10K didn't surprise me because modern compilers are more aggressive > in inlining, loop unrolling, and other techniques that increase size of > the image. > > v1: https://lore.kernel.org/linux-mm/YsAzU3g2QpgmIGre@smile.fi.intel.com/T/ > v2: - Align whitespaces in headers; > - Make bitmap_weight() unsigned long consistently; > - Pick 2 patches from Ingo's sched/headers series [1] that split > linux/gfp.h, and drop my similar patch for it. Ping?
On Tue, Jul 12, 2022 at 09:28:21AM -0700, Yury Norov wrote: > On Wed, Jul 6, 2022 at 10:42 AM Yury Norov <yury.norov@gmail.com> wrote: > > > > This series unifies declarations of bitmap-related functions and aligns > > return types with values that actually returned. Also, it moves one-liner > > wrappers around cpumask functions into headers, so that compiler has a > > chance to optimize better. > > > > With this series, GCC 11.2 for ARM64 with kernel v5.19-rc4: > > add/remove: 15/7 grow/shrink: 461/164 up/down: 14844/-4580 (10264) > > > > This +10K didn't surprise me because modern compilers are more aggressive > > in inlining, loop unrolling, and other techniques that increase size of > > the image. > > > > v1: https://lore.kernel.org/linux-mm/YsAzU3g2QpgmIGre@smile.fi.intel.com/T/ > > v2: - Align whitespaces in headers; > > - Make bitmap_weight() unsigned long consistently; > > - Pick 2 patches from Ingo's sched/headers series [1] that split > > linux/gfp.h, and drop my similar patch for it. > > Ping? OK, I realize that it's not the very entertaining thing to review a headers cleanup. Adding this into -next because there's no negative feedback (he-he).
This series unifies declarations of bitmap-related functions and aligns return types with values that actually returned. Also, it moves one-liner wrappers around cpumask functions into headers, so that compiler has a chance to optimize better. With this series, GCC 11.2 for ARM64 with kernel v5.19-rc4: add/remove: 15/7 grow/shrink: 461/164 up/down: 14844/-4580 (10264) This +10K didn't surprise me because modern compilers are more aggressive in inlining, loop unrolling, and other techniques that increase size of the image. v1: https://lore.kernel.org/linux-mm/YsAzU3g2QpgmIGre@smile.fi.intel.com/T/ v2: - Align whitespaces in headers; - Make bitmap_weight() unsigned long consistently; - Pick 2 patches from Ingo's sched/headers series [1] that split linux/gfp.h, and drop my similar patch for it. [1] https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/log/?h=sched/headers Ingo Molnar (2): headers/deps: mm: Optimize <linux/gfp.h> header dependencies headers/deps: mm: Split <linux/gfp_types.h> out of <linux/gfp.h> Yury Norov (8): arm: align find_bit declarations with generic kernel lib/bitmap: change return types to bool where appropriate lib/bitmap: change type of bitmap_weight to unsigned long cpumask: change return types to bool where appropriate lib/cpumask: change return types to unsigned where appropriate lib/cpumask: move trivial wrappers around find_bit to the header headers/deps: mm: align MANITAINERS and Docs with new gfp.h structure lib/cpumask: move some one-line wrappers to header file Documentation/core-api/mm-api.rst | 8 +- MAINTAINERS | 1 + arch/arm/include/asm/bitops.h | 18 +- include/linux/bitmap.h | 13 +- include/linux/cpumask.h | 125 +++++++++-- include/linux/gfp.h | 348 +----------------------------- include/linux/gfp_types.h | 348 ++++++++++++++++++++++++++++++ lib/bitmap.c | 9 +- lib/cpumask.c | 97 +-------- tools/include/linux/bitmap.h | 12 +- tools/lib/bitmap.c | 6 +- 11 files changed, 494 insertions(+), 491 deletions(-) create mode 100644 include/linux/gfp_types.h