| Message ID | 20220708182507.23542-1-william.zhang@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC | expand |
On Fri, 8 Jul 2022 11:25:06 -0700, William Zhang <william.zhang@broadcom.com> wrote: > The cpu mask value in interrupt property inherits from bcm4908.dtsi > which sets to four cpus. Correct the value to two cpus for dual core > BCM4906 SoC. > > Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906 > Netgear R8000P DTS files") > > Signed-off-by: William Zhang <william.zhang@broadcom.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree-arm64/fixes, thanks! -- Florian
On 2022-07-08 20:25, William Zhang wrote: > The cpu mask value in interrupt property inherits from bcm4908.dtsi > which sets to four cpus. Correct the value to two cpus for dual core > BCM4906 SoC. > > Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906 > Netgear R8000P DTS files") > > Signed-off-by: William Zhang <william.zhang@broadcom.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Both look good, thanks!
On 2022-07-08 20:25, William Zhang wrote: > The cpu mask value in interrupt property inherits from bcm4908.dtsi > which sets to four cpus. Correct the value to two cpus for dual core > BCM4906 SoC. > > Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906 > Netgear R8000P DTS files") Well, one note. You shouldn't line break Fixes: line. > Signed-off-by: William Zhang <william.zhang@broadcom.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On 7/12/22 23:49, Rafał Miłecki wrote: > On 2022-07-08 20:25, William Zhang wrote: >> The cpu mask value in interrupt property inherits from bcm4908.dtsi >> which sets to four cpus. Correct the value to two cpus for dual core >> BCM4906 SoC. >> >> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906 >> Netgear R8000P DTS files") > > Well, one note. You shouldn't line break Fixes: line. Took care of that before applying the two patches: https://github.com/torvalds/linux/commit/b4a544e415e9be33b37d9bfa9d9f9f4d13f553d6 https://github.com/torvalds/linux/commit/8bd582ae9a71d7f14c4e0c735b2eacaf7516d626
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi index 66023d553524..d084c33d5ca8 100644 --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi @@ -9,6 +9,14 @@ cpus { /delete-node/ cpu@3; }; + timer { + compatible = "arm,armv8-timer"; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + }; + pmu { compatible = "arm,cortex-a53-pmu"; interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
The cpu mask value in interrupt property inherits from bcm4908.dtsi which sets to four cpus. Correct the value to two cpus for dual core BCM4906 SoC. Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906 Netgear R8000P DTS files") Signed-off-by: William Zhang <william.zhang@broadcom.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> --- Changes in v2: - Split into two patches and add fix reference arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)