| Message ID | 20220713074118.14733-5-frieder@fris.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8mm-kontron: Improvements and OSM board support | expand |
Hi Frieder, Am Mi., 13. Juli 2022 um 09:41 Uhr schrieb Frieder Schrempf <frieder@fris.de>: > > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > Use upper case PMIC regulator names to comply with the bindings. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > .../freescale/imx8mm-kontron-n801x-som.dtsi | 22 +++++++++---------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > index 2d0661cce89b..2e3d51bbf92e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi > @@ -85,7 +85,7 @@ pca9450: pmic@25 { > > regulators { > reg_vdd_soc: BUCK1 { > - regulator-name = "buck1"; > + regulator-name = "BUCK1"; Wouldn't it be better to use the real signal or voltage rail names used in the schematics? Like it is done here as example: https://elixir.bootlin.com/linux/v5.19-rc6/source/arch/arm64/boot/dts/freescale/imx8mn-evk.dts#L44 Or use a name that includes both information (signal + PMIC out): https://elixir.bootlin.com/linux/v5.19-rc6/source/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi#L445 > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <850000>; > regulator-boot-on; > @@ -96,7 +96,7 @@ reg_vdd_soc: BUCK1 { > }; > > reg_vdd_arm: BUCK2 { > - regulator-name = "buck2"; > + regulator-name = "BUCK2"; > regulator-min-microvolt = <850000>; > regulator-max-microvolt = <950000>; > regulator-boot-on; > @@ -107,7 +107,7 @@ reg_vdd_arm: BUCK2 { > }; > > reg_vdd_dram: BUCK3 { > - regulator-name = "buck3"; > + regulator-name = "BUCK3"; > regulator-min-microvolt = <850000>; > regulator-max-microvolt = <950000>; > regulator-boot-on; > @@ -115,7 +115,7 @@ reg_vdd_dram: BUCK3 { > }; > > reg_vdd_3v3: BUCK4 { > - regulator-name = "buck4"; > + regulator-name = "BUCK4"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > regulator-boot-on; > @@ -123,7 +123,7 @@ reg_vdd_3v3: BUCK4 { > }; > > reg_vdd_1v8: BUCK5 { > - regulator-name = "buck5"; > + regulator-name = "BUCK5"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > regulator-boot-on; > @@ -131,7 +131,7 @@ reg_vdd_1v8: BUCK5 { > }; > > reg_nvcc_dram: BUCK6 { > - regulator-name = "buck6"; > + regulator-name = "BUCK6"; > regulator-min-microvolt = <1100000>; > regulator-max-microvolt = <1100000>; > regulator-boot-on; > @@ -139,7 +139,7 @@ reg_nvcc_dram: BUCK6 { > }; > > reg_nvcc_snvs: LDO1 { > - regulator-name = "ldo1"; > + regulator-name = "LDO1"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > regulator-boot-on; > @@ -147,7 +147,7 @@ reg_nvcc_snvs: LDO1 { > }; > > reg_vdd_snvs: LDO2 { > - regulator-name = "ldo2"; > + regulator-name = "LDO2"; > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <900000>; > regulator-boot-on; > @@ -155,7 +155,7 @@ reg_vdd_snvs: LDO2 { > }; > > reg_vdda: LDO3 { > - regulator-name = "ldo3"; > + regulator-name = "LDO3"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > regulator-boot-on; > @@ -163,7 +163,7 @@ reg_vdda: LDO3 { > }; > > reg_vdd_phy: LDO4 { > - regulator-name = "ldo4"; > + regulator-name = "LDO4"; > regulator-min-microvolt = <900000>; > regulator-max-microvolt = <900000>; > regulator-boot-on; > @@ -171,7 +171,7 @@ reg_vdd_phy: LDO4 { > }; > > reg_nvcc_sd: LDO5 { > - regulator-name = "ldo5"; > + regulator-name = "LDO5"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > }; > -- > 2.37.0 >
Am 13.07.22 um 09:52 schrieb Heiko Thiery: > Hi Frieder, > > Am Mi., 13. Juli 2022 um 09:41 Uhr schrieb Frieder Schrempf <frieder@fris.de>: >> >> From: Frieder Schrempf <frieder.schrempf@kontron.de> >> >> Use upper case PMIC regulator names to comply with the bindings. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> >> --- >> .../freescale/imx8mm-kontron-n801x-som.dtsi | 22 +++++++++---------- >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi >> index 2d0661cce89b..2e3d51bbf92e 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi >> @@ -85,7 +85,7 @@ pca9450: pmic@25 { >> >> regulators { >> reg_vdd_soc: BUCK1 { >> - regulator-name = "buck1"; >> + regulator-name = "BUCK1"; > > Wouldn't it be better to use the real signal or voltage rail names > used in the schematics? Sounds like a good idea, thanks! I will try to include in the next version of this patchset.
Am 13.07.22 um 10:15 schrieb Frieder Schrempf: > Am 13.07.22 um 09:52 schrieb Heiko Thiery: >> Hi Frieder, >> >> Am Mi., 13. Juli 2022 um 09:41 Uhr schrieb Frieder Schrempf <frieder@fris.de>: >>> >>> From: Frieder Schrempf <frieder.schrempf@kontron.de> >>> >>> Use upper case PMIC regulator names to comply with the bindings. >>> >>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> >>> --- >>> .../freescale/imx8mm-kontron-n801x-som.dtsi | 22 +++++++++---------- >>> 1 file changed, 11 insertions(+), 11 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi >>> index 2d0661cce89b..2e3d51bbf92e 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi >>> @@ -85,7 +85,7 @@ pca9450: pmic@25 { >>> >>> regulators { >>> reg_vdd_soc: BUCK1 { >>> - regulator-name = "buck1"; >>> + regulator-name = "BUCK1"; >> >> Wouldn't it be better to use the real signal or voltage rail names >> used in the schematics? > > Sounds like a good idea, thanks! I will try to include in the next > version of this patchset. On the other hand, the bindings stipulate that the regulator-names should be "^BUCK[1-6]$" and "^LDO[1-5]$". But I admit these names are not really useful and maybe the bindings should be changed to allow arbitrary names?
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi index 2d0661cce89b..2e3d51bbf92e 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi @@ -85,7 +85,7 @@ pca9450: pmic@25 { regulators { reg_vdd_soc: BUCK1 { - regulator-name = "buck1"; + regulator-name = "BUCK1"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <850000>; regulator-boot-on; @@ -96,7 +96,7 @@ reg_vdd_soc: BUCK1 { }; reg_vdd_arm: BUCK2 { - regulator-name = "buck2"; + regulator-name = "BUCK2"; regulator-min-microvolt = <850000>; regulator-max-microvolt = <950000>; regulator-boot-on; @@ -107,7 +107,7 @@ reg_vdd_arm: BUCK2 { }; reg_vdd_dram: BUCK3 { - regulator-name = "buck3"; + regulator-name = "BUCK3"; regulator-min-microvolt = <850000>; regulator-max-microvolt = <950000>; regulator-boot-on; @@ -115,7 +115,7 @@ reg_vdd_dram: BUCK3 { }; reg_vdd_3v3: BUCK4 { - regulator-name = "buck4"; + regulator-name = "BUCK4"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-boot-on; @@ -123,7 +123,7 @@ reg_vdd_3v3: BUCK4 { }; reg_vdd_1v8: BUCK5 { - regulator-name = "buck5"; + regulator-name = "BUCK5"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-boot-on; @@ -131,7 +131,7 @@ reg_vdd_1v8: BUCK5 { }; reg_nvcc_dram: BUCK6 { - regulator-name = "buck6"; + regulator-name = "BUCK6"; regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1100000>; regulator-boot-on; @@ -139,7 +139,7 @@ reg_nvcc_dram: BUCK6 { }; reg_nvcc_snvs: LDO1 { - regulator-name = "ldo1"; + regulator-name = "LDO1"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-boot-on; @@ -147,7 +147,7 @@ reg_nvcc_snvs: LDO1 { }; reg_vdd_snvs: LDO2 { - regulator-name = "ldo2"; + regulator-name = "LDO2"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <900000>; regulator-boot-on; @@ -155,7 +155,7 @@ reg_vdd_snvs: LDO2 { }; reg_vdda: LDO3 { - regulator-name = "ldo3"; + regulator-name = "LDO3"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-boot-on; @@ -163,7 +163,7 @@ reg_vdda: LDO3 { }; reg_vdd_phy: LDO4 { - regulator-name = "ldo4"; + regulator-name = "LDO4"; regulator-min-microvolt = <900000>; regulator-max-microvolt = <900000>; regulator-boot-on; @@ -171,7 +171,7 @@ reg_vdd_phy: LDO4 { }; reg_nvcc_sd: LDO5 { - regulator-name = "ldo5"; + regulator-name = "LDO5"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; };