| Message ID | 20220713204623.5443-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests: timers: fixes and improvements | expand |
On Wed, Jul 13, 2022 at 1:46 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > The timer selftests are quite useful for me when enabling timers on new > SoCs, e.g. like now with the CMT timer on a Renesas R-Car S4-8. During > development, I needed these fixes and additions to make full use of > the tests. I think they make all sense upstream, so here they are. > > Patches are based on v5.19-rc1. Looking forward to comments. > Hey! Thanks so much I really appreciate the effort to make and send out these cleanups. From the initial skim it all looks great (though, some are slightly embarrassing :), and I think some of the extra config args will be quite nice for others to use as well. Acked-by: John Stultz <jstultz@google.com> Thanks so much for submitting these. -john
On 7/13/22 3:02 PM, John Stultz wrote: > On Wed, Jul 13, 2022 at 1:46 PM Wolfram Sang > <wsa+renesas@sang-engineering.com> wrote: >> >> The timer selftests are quite useful for me when enabling timers on new >> SoCs, e.g. like now with the CMT timer on a Renesas R-Car S4-8. During >> development, I needed these fixes and additions to make full use of >> the tests. I think they make all sense upstream, so here they are. >> >> Patches are based on v5.19-rc1. Looking forward to comments. >> > > Hey! > Thanks so much I really appreciate the effort to make and send out > these cleanups. From the initial skim it all looks great (though, some > are slightly embarrassing :), and I think some of the extra config > args will be quite nice for others to use as well. > > Acked-by: John Stultz <jstultz@google.com> > > Thanks so much for submitting these. > -john > Thank you both. I can queue these for 5.20-rc1 Wolfram, are you going to send v2 to address John's comment on 8/9? thanks, -- Shuah
Hey John, > Acked-by: John Stultz <jstultz@google.com> > > Thanks so much for submitting these. Glad you like this series. I will wait some more to see if there are further review comments. But surely, I will add the missing parameter to the help output and add your tags to v2. Thank you for doing these tools :) Wolfram
> Wolfram, are you going to send v2 to address John's comment on > 8/9? Yes, will do!
On 7/14/22 12:43 PM, Wolfram Sang wrote: > >> Wolfram, are you going to send v2 to address John's comment on >> 8/9? > > Yes, will do! > All patches now applied to linux-kselftest next for 5.20-rc1 Picked up v1 1-7 and 9 and v2 8 thanks, -- Shuah
The timer selftests are quite useful for me when enabling timers on new SoCs, e.g. like now with the CMT timer on a Renesas R-Car S4-8. During development, I needed these fixes and additions to make full use of the tests. I think they make all sense upstream, so here they are. Patches are based on v5.19-rc1. Looking forward to comments. Happy hacking, Wolfram Wolfram Sang (9): selftests: timers: valid-adjtimex: build fix for newer toolchains selftests: timers: fix declarations of main() selftests: timers: nanosleep: adapt to kselftest framework selftests: timers: inconsistency-check: adapt to kselftest framework selftests: timers: clocksource-switch: fix passing errors from child selftests: timers: clocksource-switch: sort includes selftests: timers: clocksource-switch: add command line switch to skip sanity check selftests: timers: clocksource-switch: add 'runtime' command line parameter selftests: timers: clocksource-switch: adapt to kselftest framework tools/testing/selftests/timers/adjtick.c | 2 +- tools/testing/selftests/timers/change_skew.c | 2 +- .../selftests/timers/clocksource-switch.c | 70 ++++++++++++------- .../selftests/timers/inconsistency-check.c | 32 +++++---- tools/testing/selftests/timers/nanosleep.c | 18 +++-- tools/testing/selftests/timers/raw_skew.c | 2 +- .../selftests/timers/skew_consistency.c | 2 +- .../testing/selftests/timers/valid-adjtimex.c | 2 +- 8 files changed, 80 insertions(+), 50 deletions(-)