| Message ID | 20220715205737.83076-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/1] ALSA: isa: Use INVALID_HWIRQ definition | expand |
On Fri, 15 Jul 2022 22:57:37 +0200, Andy Shevchenko wrote: > > Use specific definition for invalid IRQ. It makes the > code uniform in respect to the constant used for that. > No functional change intended. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > sound/isa/sscape.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c > index 0bc0025f7c19..9adaf91045e9 100644 > --- a/sound/isa/sscape.c > +++ b/sound/isa/sscape.c > @@ -140,8 +140,7 @@ struct soundscape { > unsigned char midi_vol; > }; > > -#define INVALID_IRQ ((unsigned)-1) > - > +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ) > > static inline struct soundscape *get_card_soundscape(struct snd_card *c) > { This seems failing to build on my local tree as is. We need to include <linux/irq.h> explicitly. thanks, Takashi
On Sat, Jul 16, 2022 at 08:54:17AM +0200, Takashi Iwai wrote: > On Fri, 15 Jul 2022 22:57:37 +0200, > Andy Shevchenko wrote: ... > > -#define INVALID_IRQ ((unsigned)-1) > > - > > +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ) > > This seems failing to build on my local tree as is. > We need to include <linux/irq.h> explicitly. As Marc told me this is probably the way to the wrong direction, so, please, discard this patch anyway.
diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c index 0bc0025f7c19..9adaf91045e9 100644 --- a/sound/isa/sscape.c +++ b/sound/isa/sscape.c @@ -140,8 +140,7 @@ struct soundscape { unsigned char midi_vol; }; -#define INVALID_IRQ ((unsigned)-1) - +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ) static inline struct soundscape *get_card_soundscape(struct snd_card *c) {
Use specific definition for invalid IRQ. It makes the code uniform in respect to the constant used for that. No functional change intended. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- sound/isa/sscape.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)