diff mbox series

dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles

Message ID 20220613123529.466528-1-alexander.stein@ew.tq-group.com (mailing list archive)
State Accepted
Headers show
Series dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles | expand

Commit Message

Alexander Stein June 13, 2022, 12:35 p.m. UTC
Both are already using the vf610 compatible.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) June 13, 2022, 5:34 p.m. UTC | #1
On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> Both are already using the vf610 compatible.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


adc@2198000: 'num-channels' does not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm/boot/dts/imx6ul-14x14-evk.dtb
	arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
	arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
	arch/arm/boot/dts/imx6ul-geam.dtb
	arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
	arch/arm/boot/dts/imx6ul-isiot-nand.dtb
	arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
	arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
	arch/arm/boot/dts/imx6ull-14x14-evk.dtb
	arch/arm/boot/dts/imx6ull-colibri-aster.dtb
	arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
	arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
	arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
	arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
	arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
	arch/arm/boot/dts/imx6ull-colibri-iris.dtb
	arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
	arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
	arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
	arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
	arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
	arch/arm/boot/dts/imx6ul-liteboard.dtb
	arch/arm/boot/dts/imx6ull-jozacp.dtb
	arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
	arch/arm/boot/dts/imx6ull-opos6uldev.dtb
	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
	arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
	arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
	arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
	arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
	arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
	arch/arm/boot/dts/imx6ul-opos6uldev.dtb
	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
	arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
	arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
	arch/arm/boot/dts/imx6ul-pico-pi.dtb
	arch/arm/boot/dts/imx6ul-prti6g.dtb
	arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
	arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
	arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
	arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
	arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
	arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
Rob Herring (Arm) June 17, 2022, 10:44 p.m. UTC | #2
On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > Both are already using the vf610 compatible.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/
> 
> 
> adc@2198000: 'num-channels' does not match any of the regexes: 'pinctrl-[0-9]+'

Looks like you need to add 'num-channels'?

> 	arch/arm/boot/dts/imx6ul-14x14-evk.dtb
> 	arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
> 	arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
> 	arch/arm/boot/dts/imx6ul-geam.dtb
> 	arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
> 	arch/arm/boot/dts/imx6ul-isiot-nand.dtb
> 	arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
> 	arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
> 	arch/arm/boot/dts/imx6ull-14x14-evk.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-aster.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-iris.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
> 	arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
> 	arch/arm/boot/dts/imx6ul-liteboard.dtb
> 	arch/arm/boot/dts/imx6ull-jozacp.dtb
> 	arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
> 	arch/arm/boot/dts/imx6ull-opos6uldev.dtb
> 	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
> 	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
> 	arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
> 	arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
> 	arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
> 	arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
> 	arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
> 	arch/arm/boot/dts/imx6ul-opos6uldev.dtb
> 	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
> 	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
> 	arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
> 	arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> 	arch/arm/boot/dts/imx6ul-pico-pi.dtb
> 	arch/arm/boot/dts/imx6ul-prti6g.dtb
> 	arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
> 	arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
> 	arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
> 	arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
> 	arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
> 	arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
> 
>
Jonathan Cameron June 18, 2022, 5:01 p.m. UTC | #3
On Fri, 17 Jun 2022 16:44:48 -0600
Rob Herring <robh@kernel.org> wrote:

> On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:  
> > > Both are already using the vf610 compatible.
> > > 
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > >  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9 ++++++++-
> > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > >   
> > 
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> > 
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> > 
> > Full log is available here: https://patchwork.ozlabs.org/patch/
> > 
> > 
> > adc@2198000: 'num-channels' does not match any of the regexes: 'pinctrl-[0-9]+'  
> 
> Looks like you need to add 'num-channels'?

or a lot of wrong dtbs :)

By which I mean ones providing a property that may or may not be actually
used by any drivers...

Jonathan


> 
> > 	arch/arm/boot/dts/imx6ul-14x14-evk.dtb
> > 	arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
> > 	arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
> > 	arch/arm/boot/dts/imx6ul-geam.dtb
> > 	arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
> > 	arch/arm/boot/dts/imx6ul-isiot-nand.dtb
> > 	arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
> > 	arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
> > 	arch/arm/boot/dts/imx6ull-14x14-evk.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-aster.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-iris.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
> > 	arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
> > 	arch/arm/boot/dts/imx6ul-liteboard.dtb
> > 	arch/arm/boot/dts/imx6ull-jozacp.dtb
> > 	arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
> > 	arch/arm/boot/dts/imx6ull-opos6uldev.dtb
> > 	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
> > 	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
> > 	arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
> > 	arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
> > 	arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
> > 	arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
> > 	arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
> > 	arch/arm/boot/dts/imx6ul-opos6uldev.dtb
> > 	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
> > 	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
> > 	arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
> > 	arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> > 	arch/arm/boot/dts/imx6ul-pico-pi.dtb
> > 	arch/arm/boot/dts/imx6ul-prti6g.dtb
> > 	arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
> > 	arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
> > 	arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
> > 	arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
> > 	arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
> > 	arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
> > 
> >
Alexander Stein June 20, 2022, 8:12 a.m. UTC | #4
Hello,

Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:
> On Fri, 17 Jun 2022 16:44:48 -0600
> 
> Rob Herring <robh@kernel.org> wrote:
> > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > > Both are already using the vf610 compatible.
> > > > 
> > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > ---
> > > > 
> > > >  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9
> > > >  ++++++++-
> > > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > > 
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema is
> > > incorrect. These may not be new warnings.
> > > 
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > This will change in the future.
> > > 
> > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > 
> > > 
> > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > 'pinctrl-[0-9]+'> 
> > Looks like you need to add 'num-channels'?
> 
> or a lot of wrong dtbs :)
> 
> By which I mean ones providing a property that may or may not be actually
> used by any drivers...

This got already fixed by Baruch's patch which is currently in Shawn's imx-
fixes-5.19 branch at [1]

Best reagrds,
Alexander

[1] https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/
commit/?h=imx/dt&id=71b81f1cac29297769ec81fe29a3fcc40bc2c31c

> > > 	arch/arm/boot/dts/imx6ul-14x14-evk.dtb
> > > 	arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
> > > 	arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
> > > 	arch/arm/boot/dts/imx6ul-geam.dtb
> > > 	arch/arm/boot/dts/imx6ul-isiot-emmc.dtb
> > > 	arch/arm/boot/dts/imx6ul-isiot-nand.dtb
> > > 	arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dtb
> > > 	arch/arm/boot/dts/imx6ul-kontron-n6310-s.dtb
> > > 	arch/arm/boot/dts/imx6ull-14x14-evk.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-aster.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-emmc-aster.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-emmc-iris.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-emmc-iris-v2.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-iris.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-iris-v2.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-wifi-aster.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-wifi-eval-v3.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-wifi-iris.dtb
> > > 	arch/arm/boot/dts/imx6ull-colibri-wifi-iris-v2.dtb
> > > 	arch/arm/boot/dts/imx6ul-liteboard.dtb
> > > 	arch/arm/boot/dts/imx6ull-jozacp.dtb
> > > 	arch/arm/boot/dts/imx6ull-myir-mys-6ulx-eval.dtb
> > > 	arch/arm/boot/dts/imx6ull-opos6uldev.dtb
> > > 	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dtb
> > > 	arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dtb
> > > 	arch/arm/boot/dts/imx6ull-phytec-segin-lc-rdk-nand.dtb
> > > 	arch/arm/boot/dts/imx6ull-phytec-tauri-emmc.dtb
> > > 	arch/arm/boot/dts/imx6ull-phytec-tauri-nand.dtb
> > > 	arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dtb
> > > 	arch/arm/boot/dts/imx6ull-tqma6ull2-mba6ulx.dtb
> > > 	arch/arm/boot/dts/imx6ul-opos6uldev.dtb
> > > 	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dtb
> > > 	arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dtb
> > > 	arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
> > > 	arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
> > > 	arch/arm/boot/dts/imx6ul-pico-pi.dtb
> > > 	arch/arm/boot/dts/imx6ul-prti6g.dtb
> > > 	arch/arm/boot/dts/imx6ul-tqma6ul1-mba6ulx.dtb
> > > 	arch/arm/boot/dts/imx6ul-tqma6ul2l-mba6ulx.dtb
> > > 	arch/arm/boot/dts/imx6ul-tqma6ul2-mba6ulx.dtb
> > > 	arch/arm/boot/dts/imx6ul-tx6ul-0010.dtb
> > > 	arch/arm/boot/dts/imx6ul-tx6ul-0011.dtb
> > > 	arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dtb
Rob Herring (Arm) June 28, 2022, 9:09 p.m. UTC | #5
On Mon, Jun 20, 2022 at 10:12:44AM +0200, Alexander Stein wrote:
> Hello,
> 
> Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:
> > On Fri, 17 Jun 2022 16:44:48 -0600
> > 
> > Rob Herring <robh@kernel.org> wrote:
> > > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > > > Both are already using the vf610 compatible.
> > > > > 
> > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > ---
> > > > > 
> > > > >  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9
> > > > >  ++++++++-
> > > > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > > > 
> > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > following warnings. Consider if they are expected or the schema is
> > > > incorrect. These may not be new warnings.
> > > > 
> > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > > This will change in the future.
> > > > 
> > > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > > 
> > > > 
> > > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > > 'pinctrl-[0-9]+'> 
> > > Looks like you need to add 'num-channels'?
> > 
> > or a lot of wrong dtbs :)
> > 
> > By which I mean ones providing a property that may or may not be actually
> > used by any drivers...
> 
> This got already fixed by Baruch's patch which is currently in Shawn's imx-
> fixes-5.19 branch at [1]

Great!

Reviewed-by: Rob Herring <robh@kernel.org>
Alexander Stein July 15, 2022, 7:56 a.m. UTC | #6
Am Dienstag, 28. Juni 2022, 23:09:19 CEST schrieb Rob Herring:
> On Mon, Jun 20, 2022 at 10:12:44AM +0200, Alexander Stein wrote:
> > Hello,
> > 
> > Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:
> > > On Fri, 17 Jun 2022 16:44:48 -0600
> > > 
> > > Rob Herring <robh@kernel.org> wrote:
> > > > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:
> > > > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:
> > > > > > Both are already using the vf610 compatible.
> > > > > > 
> > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > > ---
> > > > > > 
> > > > > >  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9
> > > > > >  ++++++++-
> > > > > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > > > > 
> > > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > > following warnings. Consider if they are expected or the schema is
> > > > > incorrect. These may not be new warnings.
> > > > > 
> > > > > Note that it is not yet a requirement to have 0 warnings for
> > > > > dtbs_check.
> > > > > This will change in the future.
> > > > > 
> > > > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > > > 
> > > > > 
> > > > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > > > 'pinctrl-[0-9]+'>
> > > > 
> > > > Looks like you need to add 'num-channels'?
> > > 
> > > or a lot of wrong dtbs :)
> > > 
> > > By which I mean ones providing a property that may or may not be
> > > actually
> > > used by any drivers...
> > 
> > This got already fixed by Baruch's patch which is currently in Shawn's
> > imx-
> > fixes-5.19 branch at [1]
> 
> Great!
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Did this got missed? Or is it applied somwhere I' not aware of?

Best regards,
Alexander
Jonathan Cameron July 16, 2022, 2:52 p.m. UTC | #7
On Fri, 15 Jul 2022 09:56:45 +0200
Alexander Stein <alexander.stein@ew.tq-group.com> wrote:

> Am Dienstag, 28. Juni 2022, 23:09:19 CEST schrieb Rob Herring:
> > On Mon, Jun 20, 2022 at 10:12:44AM +0200, Alexander Stein wrote:  
> > > Hello,
> > > 
> > > Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:  
> > > > On Fri, 17 Jun 2022 16:44:48 -0600
> > > > 
> > > > Rob Herring <robh@kernel.org> wrote:  
> > > > > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:  
> > > > > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:  
> > > > > > > Both are already using the vf610 compatible.
> > > > > > > 
> > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > > > ---
> > > > > > > 
> > > > > > >  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9
> > > > > > >  ++++++++-
> > > > > > >  1 file changed, 8 insertions(+), 1 deletion(-)  
> > > > > > 
> > > > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > > > following warnings. Consider if they are expected or the schema is
> > > > > > incorrect. These may not be new warnings.
> > > > > > 
> > > > > > Note that it is not yet a requirement to have 0 warnings for
> > > > > > dtbs_check.
> > > > > > This will change in the future.
> > > > > > 
> > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > > > > 
> > > > > > 
> > > > > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > > > > 'pinctrl-[0-9]+'>  
> > > > > 
> > > > > Looks like you need to add 'num-channels'?  
> > > > 
> > > > or a lot of wrong dtbs :)
> > > > 
> > > > By which I mean ones providing a property that may or may not be
> > > > actually
> > > > used by any drivers...  
> > > 
> > > This got already fixed by Baruch's patch which is currently in Shawn's
> > > imx-
> > > fixes-5.19 branch at [1]  
> > 
> > Great!
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>  
> 
> Did this got missed? Or is it applied somwhere I' not aware of?
Missed it.  Thanks for pointing it out!

Applied to the togreg branch of iio.git and pushed out initially as testing
for 0-day to poke at it.  Note this may well not make this cycle now unfortunately
given the timing.

Thanks,

Jonathan

> 
> Best regards,
> Alexander
> 
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml
index 925f355cc21f..c770ff4998f5 100644
--- a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml
@@ -14,7 +14,14 @@  description:
 
 properties:
   compatible:
-    const: fsl,vf610-adc
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx6sx-adc
+              - fsl,imx6ul-adc
+          - const: fsl,vf610-adc
+      - items:
+          - const: fsl,vf610-adc
 
   reg:
     maxItems: 1