mbox series

[v1,net,00/15] sysctl: Fix data-races around ipv4_net_table (Round 3).

Message ID 20220715171755.38497-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series sysctl: Fix data-races around ipv4_net_table (Round 3). | expand

Message

Kuniyuki Iwashima July 15, 2022, 5:17 p.m. UTC 
This series fixes data-races around 21 knobs after
igmp_link_local_mcast_reports in ipv4_net_table.

These 4 knobs are skipped because they are safe.

  - tcp_congestion_control: Safe with RCU and xchg().
  - tcp_available_congestion_control: Read only.
  - tcp_allowed_congestion_control: Safe with RCU and spinlock().
  - tcp_fastopen_key: Safe with RCU and xchg()

So, round 4 will start with fib_multipath_use_neigh.


Kuniyuki Iwashima (15):
  igmp: Fix data-races around sysctl_igmp_llm_reports.
  igmp: Fix a data-race around sysctl_igmp_max_memberships.
  igmp: Fix data-races around sysctl_igmp_max_msf.
  igmp: Fix data-races around sysctl_igmp_qrv.
  tcp: Fix data-races around keepalive sysctl knobs.
  tcp: Fix data-races around sysctl_tcp_syn(ack)?_retries.
  tcp: Fix data-races around sysctl_tcp_syncookies.
  tcp: Fix data-races around sysctl_tcp_migrate_req.
  tcp: Fix data-races around sysctl_tcp_reordering.
  tcp: Fix data-races around some timeout sysctl knobs.
  tcp: Fix a data-race around sysctl_tcp_notsent_lowat.
  tcp: Fix a data-race around sysctl_tcp_tw_reuse.
  tcp: Fix data-races around sysctl_max_syn_backlog.
  tcp: Fix data-races around sysctl_tcp_fastopen.
  tcp: Fix data-races around sysctl_tcp_fastopen_blackhole_timeout.

 drivers/net/amt.c               |  4 +--
 include/net/tcp.h               | 14 ++++++----
 net/core/filter.c               |  4 +--
 net/core/sock_reuseport.c       |  4 +--
 net/ipv4/af_inet.c              |  2 +-
 net/ipv4/igmp.c                 | 49 +++++++++++++++++++--------------
 net/ipv4/inet_connection_sock.c |  3 +-
 net/ipv4/ip_sockglue.c          |  6 ++--
 net/ipv4/syncookies.c           |  3 +-
 net/ipv4/tcp.c                  | 13 +++++----
 net/ipv4/tcp_fastopen.c         |  9 +++---
 net/ipv4/tcp_input.c            | 36 +++++++++++++++---------
 net/ipv4/tcp_ipv4.c             |  2 +-
 net/ipv4/tcp_metrics.c          |  3 +-
 net/ipv4/tcp_output.c           |  2 +-
 net/ipv4/tcp_timer.c            | 20 ++++++++------
 net/ipv6/syncookies.c           |  3 +-
 net/smc/smc_llc.c               |  2 +-
 18 files changed, 106 insertions(+), 73 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 18, 2022, 11:50 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 15 Jul 2022 10:17:40 -0700 you wrote:
> This series fixes data-races around 21 knobs after
> igmp_link_local_mcast_reports in ipv4_net_table.
> 
> These 4 knobs are skipped because they are safe.
> 
>   - tcp_congestion_control: Safe with RCU and xchg().
>   - tcp_available_congestion_control: Read only.
>   - tcp_allowed_congestion_control: Safe with RCU and spinlock().
>   - tcp_fastopen_key: Safe with RCU and xchg()
> 
> [...]

Here is the summary with links:
  - [v1,net,01/15] igmp: Fix data-races around sysctl_igmp_llm_reports.
    https://git.kernel.org/netdev/net/c/f6da2267e711
  - [v1,net,02/15] igmp: Fix a data-race around sysctl_igmp_max_memberships.
    https://git.kernel.org/netdev/net/c/6305d821e3b9
  - [v1,net,03/15] igmp: Fix data-races around sysctl_igmp_max_msf.
    https://git.kernel.org/netdev/net/c/6ae0f2e55373
  - [v1,net,04/15] igmp: Fix data-races around sysctl_igmp_qrv.
    https://git.kernel.org/netdev/net/c/8ebcc62c738f
  - [v1,net,05/15] tcp: Fix data-races around keepalive sysctl knobs.
    https://git.kernel.org/netdev/net/c/f2f316e287e6
  - [v1,net,06/15] tcp: Fix data-races around sysctl_tcp_syn(ack)?_retries.
    https://git.kernel.org/netdev/net/c/20a3b1c0f603
  - [v1,net,07/15] tcp: Fix data-races around sysctl_tcp_syncookies.
    https://git.kernel.org/netdev/net/c/f2e383b5bb6b
  - [v1,net,08/15] tcp: Fix data-races around sysctl_tcp_migrate_req.
    https://git.kernel.org/netdev/net/c/4177f545895b
  - [v1,net,09/15] tcp: Fix data-races around sysctl_tcp_reordering.
    https://git.kernel.org/netdev/net/c/46778cd16e6a
  - [v1,net,10/15] tcp: Fix data-races around some timeout sysctl knobs.
    https://git.kernel.org/netdev/net/c/39e24435a776
  - [v1,net,11/15] tcp: Fix a data-race around sysctl_tcp_notsent_lowat.
    https://git.kernel.org/netdev/net/c/55be873695ed
  - [v1,net,12/15] tcp: Fix a data-race around sysctl_tcp_tw_reuse.
    https://git.kernel.org/netdev/net/c/cbfc6495586a
  - [v1,net,13/15] tcp: Fix data-races around sysctl_max_syn_backlog.
    https://git.kernel.org/netdev/net/c/79539f34743d
  - [v1,net,14/15] tcp: Fix data-races around sysctl_tcp_fastopen.
    https://git.kernel.org/netdev/net/c/5a54213318c4
  - [v1,net,15/15] tcp: Fix data-races around sysctl_tcp_fastopen_blackhole_timeout.
    https://git.kernel.org/netdev/net/c/021266ec640c

You are awesome, thank you!