diff mbox series

[4/4] mt76: mt7921u: remove unnecessary MT76_STATE_SUSPEND

Message ID 2938c18e2a14e26de293adcf68cd851ca0a7474a.1658176701.git.sean.wang@kernel.org (mailing list archive)
State Superseded
Delegated to: Felix Fietkau
Headers show
Series [1/4] mt76: mt7921e: fix race issue between reset and suspend/resume | expand

Commit Message

Sean Wang July 18, 2022, 8:51 p.m. UTC
From: Sean Wang <sean.wang@mediatek.com>

remove unnecessary MT76_STATE_SUSPEND manipulation to be consistent
with the mt7921[e, s] driver.

Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Lorenzo Bianconi July 18, 2022, 10:12 p.m. UTC | #1
> From: Sean Wang <sean.wang@mediatek.com>
> 
> remove unnecessary MT76_STATE_SUSPEND manipulation to be consistent
> with the mt7921[e, s] driver.

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> index 124d62c0dfa4..a8ea03d4f990 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> @@ -313,8 +313,6 @@ static int mt7921u_suspend(struct usb_interface *intf, pm_message_t state)
>  	mt76u_stop_rx(&dev->mt76);
>  	mt76u_stop_tx(&dev->mt76);
>  
> -	set_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
> -
>  	return 0;
>  
>  failed:
> @@ -354,8 +352,6 @@ static int mt7921u_resume(struct usb_interface *intf)
>  			goto failed;
>  	}
>  
> -	clear_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
> -
>  	err = mt76u_resume_rx(&dev->mt76);
>  	if (err < 0)
>  		goto failed;
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
index 124d62c0dfa4..a8ea03d4f990 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
@@ -313,8 +313,6 @@  static int mt7921u_suspend(struct usb_interface *intf, pm_message_t state)
 	mt76u_stop_rx(&dev->mt76);
 	mt76u_stop_tx(&dev->mt76);
 
-	set_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
-
 	return 0;
 
 failed:
@@ -354,8 +352,6 @@  static int mt7921u_resume(struct usb_interface *intf)
 			goto failed;
 	}
 
-	clear_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
-
 	err = mt76u_resume_rx(&dev->mt76);
 	if (err < 0)
 		goto failed;