mbox series

[0/2] crypto: make the sha1 library optional

Message ID 20220709211849.210850-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series crypto: make the sha1 library optional | expand

Message

Eric Biggers July 9, 2022, 9:18 p.m. UTC
This series makes it possible to build the kernel without SHA-1 support,
although for now this is only possible in minimal configurations, due to
the uses of SHA-1 in the networking subsystem.

Eric Biggers (2):
  crypto: move lib/sha1.c into lib/crypto/
  crypto: make the sha1 library optional

 crypto/Kconfig          | 1 +
 init/Kconfig            | 1 +
 lib/Makefile            | 2 +-
 lib/crypto/Kconfig      | 3 +++
 lib/crypto/Makefile     | 3 +++
 lib/{ => crypto}/sha1.c | 0
 net/ipv6/Kconfig        | 1 +
 7 files changed, 10 insertions(+), 1 deletion(-)
 rename lib/{ => crypto}/sha1.c (100%)


base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81

Comments

Herbert Xu July 15, 2022, 8:50 a.m. UTC | #1
Eric Biggers <ebiggers@kernel.org> wrote:
> This series makes it possible to build the kernel without SHA-1 support,
> although for now this is only possible in minimal configurations, due to
> the uses of SHA-1 in the networking subsystem.
> 
> Eric Biggers (2):
>  crypto: move lib/sha1.c into lib/crypto/
>  crypto: make the sha1 library optional
> 
> crypto/Kconfig          | 1 +
> init/Kconfig            | 1 +
> lib/Makefile            | 2 +-
> lib/crypto/Kconfig      | 3 +++
> lib/crypto/Makefile     | 3 +++
> lib/{ => crypto}/sha1.c | 0
> net/ipv6/Kconfig        | 1 +
> 7 files changed, 10 insertions(+), 1 deletion(-)
> rename lib/{ => crypto}/sha1.c (100%)
> 
> 
> base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81

All applied.  Thanks.
Randy Dunlap July 18, 2022, 5:49 p.m. UTC | #2
On 7/15/22 01:50, Herbert Xu wrote:
> Eric Biggers <ebiggers@kernel.org> wrote:
>> This series makes it possible to build the kernel without SHA-1 support,
>> although for now this is only possible in minimal configurations, due to
>> the uses of SHA-1 in the networking subsystem.
>>
>> Eric Biggers (2):
>>  crypto: move lib/sha1.c into lib/crypto/
>>  crypto: make the sha1 library optional
>>
>> crypto/Kconfig          | 1 +
>> init/Kconfig            | 1 +
>> lib/Makefile            | 2 +-
>> lib/crypto/Kconfig      | 3 +++
>> lib/crypto/Makefile     | 3 +++
>> lib/{ => crypto}/sha1.c | 0
>> net/ipv6/Kconfig        | 1 +
>> 7 files changed, 10 insertions(+), 1 deletion(-)
>> rename lib/{ => crypto}/sha1.c (100%)
>>
>>
>> base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81
> 
> All applied.  Thanks.

Eric,
linux-next-20220718 has a build error:

ERROR: modpost: missing MODULE_LICENSE() in lib/crypto/libsha1.o
Eric Biggers July 19, 2022, 3:48 a.m. UTC | #3
On Mon, Jul 18, 2022 at 10:49:07AM -0700, Randy Dunlap wrote:
> 
> 
> On 7/15/22 01:50, Herbert Xu wrote:
> > Eric Biggers <ebiggers@kernel.org> wrote:
> >> This series makes it possible to build the kernel without SHA-1 support,
> >> although for now this is only possible in minimal configurations, due to
> >> the uses of SHA-1 in the networking subsystem.
> >>
> >> Eric Biggers (2):
> >>  crypto: move lib/sha1.c into lib/crypto/
> >>  crypto: make the sha1 library optional
> >>
> >> crypto/Kconfig          | 1 +
> >> init/Kconfig            | 1 +
> >> lib/Makefile            | 2 +-
> >> lib/crypto/Kconfig      | 3 +++
> >> lib/crypto/Makefile     | 3 +++
> >> lib/{ => crypto}/sha1.c | 0
> >> net/ipv6/Kconfig        | 1 +
> >> 7 files changed, 10 insertions(+), 1 deletion(-)
> >> rename lib/{ => crypto}/sha1.c (100%)
> >>
> >>
> >> base-commit: 79e6e2f3f3ff345947075341781e900e4f70db81
> > 
> > All applied.  Thanks.
> 
> Eric,
> linux-next-20220718 has a build error:
> 
> ERROR: modpost: missing MODULE_LICENSE() in lib/crypto/libsha1.o

Thanks, https://lore.kernel.org/r/20220719030415.32113-1-ebiggers@kernel.org
fixes this.

- Eric