mbox series

[0/2] drm/i915/gt: Expose per gt defaults in sysfs

Message ID cover.1658192398.git.ashutosh.dixit@intel.com (mailing list archive)
Headers show
Series drm/i915/gt: Expose per gt defaults in sysfs | expand

Message

Dixit, Ashutosh July 19, 2022, 1:07 a.m. UTC
Create a gt/gtN/.defaults/ directory (similar to
engine/<engine-name>/.defaults/) to expose default parameter values for each
gt in sysfs. This allows userspace to restore default parameter values
after they may have changed.

Patch 1: Creates the gt/gtN/.defaults/ directory
Patch 2: Adds per-gt RPS defaults (rps_max_freq_mhz and rps_min_freq_mhz)
	 to gt/gtN/.defaults/

An approved Level-0/oneAPI UMD pull request which consumes the exposed
defaults can be seen here:
	https://github.com/intel/compute-runtime/pull/552
The UMD pull request will be merged if/after this series is merged to i915.

Previous discussion on these patches can be seen here:
	https://patchwork.freedesktop.org/patch/484238/?series=102665&rev=4
	https://patchwork.freedesktop.org/patch/483988/?series=102665&rev=3

Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Ashutosh Dixit (2):
  drm/i915/gt: Create gt/gtN/.defaults/ for per gt sysfs defaults
  drm/i915/gt: Expose per-gt RPS defaults in sysfs

 drivers/gpu/drm/i915/gt/intel_gt_sysfs.c    | 10 +++---
 drivers/gpu/drm/i915/gt/intel_gt_sysfs.h    |  6 ++++
 drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 34 +++++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt_types.h    |  9 ++++++
 drivers/gpu/drm/i915/gt/intel_rps.c         |  2 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 12 +++++---
 6 files changed, 64 insertions(+), 9 deletions(-)

Comments

Rodrigo Vivi July 19, 2022, 10:19 a.m. UTC | #1
On Mon, Jul 18, 2022 at 06:07:06PM -0700, Ashutosh Dixit wrote:
> Create a gt/gtN/.defaults/ directory (similar to
> engine/<engine-name>/.defaults/) to expose default parameter values for each
> gt in sysfs. This allows userspace to restore default parameter values
> after they may have changed.
> 
> Patch 1: Creates the gt/gtN/.defaults/ directory
> Patch 2: Adds per-gt RPS defaults (rps_max_freq_mhz and rps_min_freq_mhz)
> 	 to gt/gtN/.defaults/
> 
> An approved Level-0/oneAPI UMD pull request which consumes the exposed
> defaults can be seen here:
> 	https://github.com/intel/compute-runtime/pull/552
> The UMD pull request will be merged if/after this series is merged to i915.

Pushed to drm-intel-gt-next. Thanks for the patches.

> 
> Previous discussion on these patches can be seen here:
> 	https://patchwork.freedesktop.org/patch/484238/?series=102665&rev=4
> 	https://patchwork.freedesktop.org/patch/483988/?series=102665&rev=3
> 
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> 
> Ashutosh Dixit (2):
>   drm/i915/gt: Create gt/gtN/.defaults/ for per gt sysfs defaults
>   drm/i915/gt: Expose per-gt RPS defaults in sysfs
> 
>  drivers/gpu/drm/i915/gt/intel_gt_sysfs.c    | 10 +++---
>  drivers/gpu/drm/i915/gt/intel_gt_sysfs.h    |  6 ++++
>  drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 34 +++++++++++++++++++++
>  drivers/gpu/drm/i915/gt/intel_gt_types.h    |  9 ++++++
>  drivers/gpu/drm/i915/gt/intel_rps.c         |  2 ++
>  drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 12 +++++---
>  6 files changed, 64 insertions(+), 9 deletions(-)
> 
> -- 
> 2.34.1
>