| Message ID | 20220718211521.664729-5-volodymyr_babchuk@epam.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vpci: first series in preparation for vpci on ARM | expand |
On 18.07.2022 23:15, Volodymyr Babchuk wrote: > Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to > iounmap(), but not added corresponding include. > > Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") I don't think there's any active issue with the "missing" include: That's only a problem once Arm has vPCI code enabled? In which case I don't think a Fixes: tag is warranted. > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> With Roger away and on the basis that I'm sure we won't mind the change: Acked-by: Jan Beulich <jbeulich@suse.com> Jan
Hello Jan, Jan Beulich <jbeulich@suse.com> writes: > On 18.07.2022 23:15, Volodymyr Babchuk wrote: >> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to >> iounmap(), but not added corresponding include. >> >> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") > > I don't think there's any active issue with the "missing" include: > That's only a problem once Arm has vPCI code enabled? In which > case I don't think a Fixes: tag is warranted. > Fair enough. May I ask committer to drop this tag? >> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> > > With Roger away and on the basis that I'm sure we won't mind the > change: > Acked-by: Jan Beulich <jbeulich@suse.com> Thank you,
On 19.07.2022 12:32, Volodymyr Babchuk wrote: > Jan Beulich <jbeulich@suse.com> writes: > >> On 18.07.2022 23:15, Volodymyr Babchuk wrote: >>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to >>> iounmap(), but not added corresponding include. >>> >>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") >> >> I don't think there's any active issue with the "missing" include: >> That's only a problem once Arm has vPCI code enabled? In which >> case I don't think a Fixes: tag is warranted. > > Fair enough. May I ask committer to drop this tag? I had taken respective note already, in case I end up committing this. But this is the last patch of the series, so I can only guess whether it might be okay to go in ahead of the other three patches. Jan
Hello all. On 19.07.22 13:40, Jan Beulich wrote: > On 19.07.2022 12:32, Volodymyr Babchuk wrote: >> Jan Beulich <jbeulich@suse.com> writes: >> >>> On 18.07.2022 23:15, Volodymyr Babchuk wrote: >>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to >>>> iounmap(), but not added corresponding include. >>>> >>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") >>> I don't think there's any active issue with the "missing" include: >>> That's only a problem once Arm has vPCI code enabled? In which >>> case I don't think a Fixes: tag is warranted. >> Fair enough. May I ask committer to drop this tag? > I had taken respective note already, in case I end up committing this. > But this is the last patch of the series, so I can only guess whether > it might be okay to go in ahead of the other three patches. > > Jan I am wondering, where this patch could be 4.17 material? The patch series seem to get stuck, but the current patch just adds a missing include to fix a build on Arm, so it is completely independent. I agree, there is no issue with the current code base as vPCI is disabled on Arm, so nothing to fix right now. But as PCI passthrough/vPCI on Arm is in the development stage, the developers enable that support in their builds. I think the risk is rather low than high.
(+ Arm maintainers) Hi Oleksandr, > -----Original Message----- > From: Oleksandr <olekstysh@gmail.com> > Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM > Hello all. > On 19.07.22 13:40, Jan Beulich wrote: > > On 19.07.2022 12:32, Volodymyr Babchuk wrote: > >> Jan Beulich <jbeulich@suse.com> writes: > >> > >>> On 18.07.2022 23:15, Volodymyr Babchuk wrote: > >>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to > >>>> iounmap(), but not added corresponding include. > >>>> > >>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") > >>> I don't think there's any active issue with the "missing" include: > >>> That's only a problem once Arm has vPCI code enabled? In which > >>> case I don't think a Fixes: tag is warranted. > >> Fair enough. May I ask committer to drop this tag? > > I had taken respective note already, in case I end up committing this. > > But this is the last patch of the series, so I can only guess whether > > it might be okay to go in ahead of the other three patches. > > > > Jan > > > I am wondering, where this patch could be 4.17 material? > > The patch series seem to get stuck, but the current patch just adds a > missing include to fix a build on Arm, so it is completely independent. > I agree, there is no issue with the current code base as vPCI is > disabled on Arm, so nothing to fix right now. But as PCI > passthrough/vPCI on Arm is in the development stage, the developers > enable that support in their builds. I think the risk is rather low than > high. It seems reasonable to me, but I am curious about what Arm maintainers and PCI maintainers think. From the history discussion in this thread I think it is pretty safe to include this in 4.17. Thanks for the ping. Kind regards, Henry > > > > -- > Regards, > > Oleksandr Tyshchenko
Hi, > On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@arm.com> wrote: > > (+ Arm maintainers) > > Hi Oleksandr, > >> -----Original Message----- >> From: Oleksandr <olekstysh@gmail.com> >> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM >> Hello all. >> On 19.07.22 13:40, Jan Beulich wrote: >>> On 19.07.2022 12:32, Volodymyr Babchuk wrote: >>>> Jan Beulich <jbeulich@suse.com> writes: >>>> >>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote: >>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to >>>>>> iounmap(), but not added corresponding include. >>>>>> >>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") >>>>> I don't think there's any active issue with the "missing" include: >>>>> That's only a problem once Arm has vPCI code enabled? In which >>>>> case I don't think a Fixes: tag is warranted. >>>> Fair enough. May I ask committer to drop this tag? >>> I had taken respective note already, in case I end up committing this. >>> But this is the last patch of the series, so I can only guess whether >>> it might be okay to go in ahead of the other three patches. >>> >>> Jan >> >> >> I am wondering, where this patch could be 4.17 material? >> >> The patch series seem to get stuck, but the current patch just adds a >> missing include to fix a build on Arm, so it is completely independent. >> I agree, there is no issue with the current code base as vPCI is >> disabled on Arm, so nothing to fix right now. But as PCI >> passthrough/vPCI on Arm is in the development stage, the developers >> enable that support in their builds. I think the risk is rather low than >> high. > > It seems reasonable to me, but I am curious about what Arm maintainers > and PCI maintainers think. From the history discussion in this thread I > think it is pretty safe to include this in 4.17. Thanks for the ping. I think this can safely go in for 4.17. Cheers Bertrand > > Kind regards, > Henry > > >> >> >> >> -- >> Regards, >> >> Oleksandr Tyshchenko
Hi Bertrand, > -----Original Message----- > From: Bertrand Marquis <Bertrand.Marquis@arm.com> > Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM > > Hi, > > > On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@arm.com> wrote: > > > > (+ Arm maintainers) > > > > Hi Oleksandr, > > > >> -----Original Message----- > >> From: Oleksandr <olekstysh@gmail.com> > >> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM > >> Hello all. > >> On 19.07.22 13:40, Jan Beulich wrote: > >>> On 19.07.2022 12:32, Volodymyr Babchuk wrote: > >>>> Jan Beulich <jbeulich@suse.com> writes: > >>>> > >>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote: > >>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to > >>>>>> iounmap(), but not added corresponding include. > >>>>>> > >>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") > >>>>> I don't think there's any active issue with the "missing" include: > >>>>> That's only a problem once Arm has vPCI code enabled? In which > >>>>> case I don't think a Fixes: tag is warranted. > >>>> Fair enough. May I ask committer to drop this tag? > >>> I had taken respective note already, in case I end up committing this. > >>> But this is the last patch of the series, so I can only guess whether > >>> it might be okay to go in ahead of the other three patches. > >>> > >>> Jan > >> > >> > >> I am wondering, where this patch could be 4.17 material? > >> > >> The patch series seem to get stuck, but the current patch just adds a > >> missing include to fix a build on Arm, so it is completely independent. > >> I agree, there is no issue with the current code base as vPCI is > >> disabled on Arm, so nothing to fix right now. But as PCI > >> passthrough/vPCI on Arm is in the development stage, the developers > >> enable that support in their builds. I think the risk is rather low than > >> high. > > > > It seems reasonable to me, but I am curious about what Arm maintainers > > and PCI maintainers think. From the history discussion in this thread I > > think it is pretty safe to include this in 4.17. Thanks for the ping. > > I think this can safely go in for 4.17. > > Cheers > Bertrand Thanks for the feedback :) Feel free to add my: Release-acked-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry > > > > > Kind regards, > > Henry > > > > > >> > >> > >> > >> -- > >> Regards, > >> > >> Oleksandr Tyshchenko >
On 22.10.2022 02:50, Henry Wang wrote: >> -----Original Message----- >> From: Bertrand Marquis <Bertrand.Marquis@arm.com> >> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM >> >>> On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@arm.com> wrote: >>> >>> (+ Arm maintainers) >>> >>>> -----Original Message----- >>>> From: Oleksandr <olekstysh@gmail.com> >>>> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM >>>> On 19.07.22 13:40, Jan Beulich wrote: >>>>> On 19.07.2022 12:32, Volodymyr Babchuk wrote: >>>>>> Jan Beulich <jbeulich@suse.com> writes: >>>>>> >>>>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote: >>>>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to >>>>>>>> iounmap(), but not added corresponding include. >>>>>>>> >>>>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") >>>>>>> I don't think there's any active issue with the "missing" include: >>>>>>> That's only a problem once Arm has vPCI code enabled? In which >>>>>>> case I don't think a Fixes: tag is warranted. >>>>>> Fair enough. May I ask committer to drop this tag? >>>>> I had taken respective note already, in case I end up committing this. >>>>> But this is the last patch of the series, so I can only guess whether >>>>> it might be okay to go in ahead of the other three patches. >>>>> >>>>> Jan >>>> >>>> >>>> I am wondering, where this patch could be 4.17 material? >>>> >>>> The patch series seem to get stuck, but the current patch just adds a >>>> missing include to fix a build on Arm, so it is completely independent. >>>> I agree, there is no issue with the current code base as vPCI is >>>> disabled on Arm, so nothing to fix right now. But as PCI >>>> passthrough/vPCI on Arm is in the development stage, the developers >>>> enable that support in their builds. I think the risk is rather low than >>>> high. >>> >>> It seems reasonable to me, but I am curious about what Arm maintainers >>> and PCI maintainers think. From the history discussion in this thread I >>> think it is pretty safe to include this in 4.17. Thanks for the ping. >> >> I think this can safely go in for 4.17. >> >> Cheers >> Bertrand > > Thanks for the feedback :) Feel free to add my: > > Release-acked-by: Henry Wang <Henry.Wang@arm.com> Okay, recorded, but first of all this patch needs Roger's ack. Jan
On Mon, Jul 18, 2022 at 09:15:43PM +0000, Volodymyr Babchuk wrote: > Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to > iounmap(), but not added corresponding include. > > Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") > > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 1559763479..674c9b347d 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -19,6 +19,7 @@ #include <xen/sched.h> #include <xen/vpci.h> +#include <xen/vmap.h> /* Internal struct to store the emulated PCI registers. */ struct vpci_register {
Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to iounmap(), but not added corresponding include. Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com> --- xen/drivers/vpci/vpci.c | 1 + 1 file changed, 1 insertion(+)