mbox series

[0/3] selftests: KVM: Improvements to binary stats test

Message ID 20220719143134.3246798-1-oliver.upton@linux.dev (mailing list archive)
Headers show
Series selftests: KVM: Improvements to binary stats test | expand

Message

Oliver Upton July 19, 2022, 2:31 p.m. UTC
From: Oliver Upton <oupton@google.com>

Small series to improve the debuggability of the binary stats test w/
more descriptive test assertions + add coverage for boolean stats.

Applies to kvm/queue, with the following patches applied:

 - 1b870fa5573e ("kvm: stats: tell userspace which values are boolean")
 - https://lore.kernel.org/kvm/20220719125229.2934273-1-oupton@google.com/

First time sending patches from my new inbox, apologies if I've screwed
something up.

Oliver Upton (3):
  selftests: KVM: Check stat name before other fields
  selftests: KVM: Provide descriptive assertions in
    kvm_binary_stats_test
  selftests: KVM: Add exponent check for boolean stats

 .../selftests/kvm/kvm_binary_stats_test.c     | 38 +++++++++++++------
 1 file changed, 27 insertions(+), 11 deletions(-)

Comments

Andrew Jones July 19, 2022, 4:09 p.m. UTC | #1
On Tue, Jul 19, 2022 at 02:31:31PM +0000, Oliver Upton wrote:
> From: Oliver Upton <oupton@google.com>
> 
> Small series to improve the debuggability of the binary stats test w/
> more descriptive test assertions + add coverage for boolean stats.
> 
> Applies to kvm/queue, with the following patches applied:
> 
>  - 1b870fa5573e ("kvm: stats: tell userspace which values are boolean")
>  - https://lore.kernel.org/kvm/20220719125229.2934273-1-oupton@google.com/
> 
> First time sending patches from my new inbox, apologies if I've screwed
> something up.
> 
> Oliver Upton (3):
>   selftests: KVM: Check stat name before other fields
>   selftests: KVM: Provide descriptive assertions in
>     kvm_binary_stats_test
>   selftests: KVM: Add exponent check for boolean stats
> 
>  .../selftests/kvm/kvm_binary_stats_test.c     | 38 +++++++++++++------
>  1 file changed, 27 insertions(+), 11 deletions(-)
> 
> -- 
> 2.37.0.170.g444d1eabd0-goog
>

For the series,

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
Paolo Bonzini July 19, 2022, 5:53 p.m. UTC | #2
On 7/19/22 18:09, Andrew Jones wrote:
> On Tue, Jul 19, 2022 at 02:31:31PM +0000, Oliver Upton wrote:
>> From: Oliver Upton <oupton@google.com>
>>
>> Small series to improve the debuggability of the binary stats test w/
>> more descriptive test assertions + add coverage for boolean stats.
>>
>> Applies to kvm/queue, with the following patches applied:
>>
>>   - 1b870fa5573e ("kvm: stats: tell userspace which values are boolean")
>>   - https://lore.kernel.org/kvm/20220719125229.2934273-1-oupton@google.com/
>>
>> First time sending patches from my new inbox, apologies if I've screwed
>> something up.
>>
>> Oliver Upton (3):
>>    selftests: KVM: Check stat name before other fields
>>    selftests: KVM: Provide descriptive assertions in
>>      kvm_binary_stats_test
>>    selftests: KVM: Add exponent check for boolean stats
>>
>>   .../selftests/kvm/kvm_binary_stats_test.c     | 38 +++++++++++++------
>>   1 file changed, 27 insertions(+), 11 deletions(-)
>>
>> -- 
>> 2.37.0.170.g444d1eabd0-goog
>>
> 
> For the series,
> 
> Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
> 

Queued, thanks.

Paolo