mbox series

[v1,0/7] mv: from in-cone to out-of-cone

Message ID 20220719132809.409247-1-shaoxuan.yuan02@gmail.com (mailing list archive)
Headers show
Series mv: from in-cone to out-of-cone | expand

Message

Shaoxuan Yuan July 19, 2022, 1:28 p.m. UTC 
This is a sister series to the previous "from out-of-cone to in-cone" [1]
series. This series is trying to make the opposite operation possible for
'mv', namely move <source>, which is in-cone, to <destination>, which is
out-of-cone.

Other than the main task, there are also some minor fixes done.

[1] https://lore.kernel.org/git/20220331091755.385961-1-shaoxuan.yuan02@gmail.com/

Shaoxuan Yuan (7):
  t7002: add tests for moving from in-cone to out-of-cone
  mv: add documentation for check_dir_in_index()
  mv: free the *with_slash in check_dir_in_index()
  mv: check if <destination> is a SKIP_WORKTREE_DIR
  mv: remove BOTH from enum update_mode
  mv: from in-cone to out-of-cone
  mv: check overwrite for in-to-out move

 advice.c                      |  19 +++++
 advice.h                      |   1 +
 builtin/mv.c                  | 100 +++++++++++++++++++----
 t/t7002-mv-sparse-checkout.sh | 148 +++++++++++++++++++++++++++++++++-
 4 files changed, 250 insertions(+), 18 deletions(-)


base-commit: 71a8fab31b70c417e8f5b5f716581f89955a7082

Comments

Derrick Stolee July 19, 2022, 6:16 p.m. UTC | #1 
On 7/19/2022 9:28 AM, Shaoxuan Yuan wrote:
> This is a sister series to the previous "from out-of-cone to in-cone" [1]
> series. This series is trying to make the opposite operation possible for
> 'mv', namely move <source>, which is in-cone, to <destination>, which is
> out-of-cone.
> 
> Other than the main task, there are also some minor fixes done.

I'm happy to see that the main task is less complicated than the previous
case, because of your hard work refactoring some things.

I still have some ideas about how to break up the change to be a bit more
readable. Most of my comments on this v1 are nits, though. Good work!

Thanks,
-Stolee