| Message ID | 20220704060806.1622849-1-lizhijian@fujitsu.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RDMA/rxe: Fix no completion event issue | expand |
On Mon, Jul 04, 2022 at 06:00:54AM +0000, lizhijian@fujitsu.com wrote: Please fix your gitconfig to have same From/author fields as in Signed-off-by. Thanks
Hi Leon On 20/07/2022 13:38, Leon Romanovsky wrote: > On Mon, Jul 04, 2022 at 06:00:54AM +0000, lizhijian@fujitsu.com wrote: > > Please fix your gitconfig to have same From/author fields as in Signed-off-by. I'm sorry about that, tay I know which patch has something wrong? I have not updated these fields recently. Do you mean "[PATCH v5 3/4] RDMA/rxe: Split qp state for requester and completer" which is from Bob. So I keep his author and SOB. Thanks Zhijian > > Thanks
On Wed, Jul 20, 2022 at 06:21:29AM +0000, lizhijian@fujitsu.com wrote: > Hi Leon > > > On 20/07/2022 13:38, Leon Romanovsky wrote: > > On Mon, Jul 04, 2022 at 06:00:54AM +0000, lizhijian@fujitsu.com wrote: > > > > Please fix your gitconfig to have same From/author fields as in Signed-off-by. > > I'm sorry about that, tay I know which patch has something wrong? I have not updated these fields recently. > Do you mean "[PATCH v5 3/4] RDMA/rxe: Split qp state for requester and completer" which is from Bob. So > I keep his author and SOB. No, I'm talking about something else. Almost all your patches are sent with wrong "From:" field. Let's take your first patch as an example: https://lore.kernel.org/linux-rdma/20220704060806.1622849-2-lizhijian@fujitsu.com/ From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com> ... Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> and if i try to apply it, the checkpatch will throw the following error: ➜ kernel git:(rdma-next) ✗ git am --continue Applying: RDMA/rxe: Update wqe_index for each wqe error completion ➜ kernel git:(rdma-next) git checkpatch WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: qp->req.wqe_index==queue.index in next round, req_next_wqe() will treat queue WARNING: From:/Signed-off-by: email name mismatch: 'From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>' != 'Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>' 0001-RDMA-rxe-Update-wqe_index-for-each-wqe-error-complet.patch total: 0 errors, 2 warnings, 8 lines checked > > Thanks > Zhijian > > > > > > Thanks
It's observed that no more completion occurs after a few incorrect posts. Actually, it will block the polling. we can easily reproduce it by the below pattern. a. post correct RDMA_WRITE b. poll completion event while true { c. post incorrect RDMA_WRITE(wrong rkey for example) d. poll completion event <<<< block after 2 incorrect RDMA_WRITE posts } V4 add new patch from Bob where it make requester stop executing qp operation as soon as possible. Both blktests and pyverbs tests are passed fine. Bob Pearson (1): RDMA/rxe: Split qp state for requester and completer Li Zhijian (3): RDMA/rxe: Update wqe_index for each wqe error completion RDMA/rxe: Generate error completion for error requester QP state RDMA/rxe: Fix typo in comment drivers/infiniband/sw/rxe/rxe_comp.c | 6 +++--- drivers/infiniband/sw/rxe/rxe_qp.c | 5 +++++ drivers/infiniband/sw/rxe/rxe_req.c | 16 +++++++++++++++- drivers/infiniband/sw/rxe/rxe_task.c | 2 +- drivers/infiniband/sw/rxe/rxe_verbs.h | 1 + 5 files changed, 25 insertions(+), 5 deletions(-)