| Message ID | 20220709014929.14221-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning | expand |
Reviewed-by: Guo Ren <guoren@kernel.org> On Sat, Jul 9, 2022 at 9:49 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL. > Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so > quieten this kconfig warning: > > WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE > Depends on [n]: !XIP_KERNEL [=y] > Selected by [y]: > - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y] > > Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Wei Fu <wefu@redhat.com> > Cc: Liu Shaohua <liush@allwinnertech.com> > Cc: Guo Ren <guoren@kernel.org> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org > --- > arch/riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -362,6 +362,7 @@ config RISCV_ISA_C > config RISCV_ISA_SVPBMT > bool "SVPBMT extension support" > depends on 64BIT && MMU > + depends on !XIP_KERNEL > select RISCV_ALTERNATIVE > default y > help
Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap: > RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL. > Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so > quieten this kconfig warning: > > WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE > Depends on [n]: !XIP_KERNEL [=y] > Selected by [y]: > - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y] > > Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Wei Fu <wefu@redhat.com> > Cc: Liu Shaohua <liush@allwinnertech.com> > Cc: Guo Ren <guoren@kernel.org> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Hi Palmer, Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap: > RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL. > Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so > quieten this kconfig warning: > > WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE > Depends on [n]: !XIP_KERNEL [=y] > Selected by [y]: > - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y] > > Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> I think this should also be applied as fix? Thanks Heiko > Cc: Wei Fu <wefu@redhat.com> > Cc: Liu Shaohua <liush@allwinnertech.com> > Cc: Guo Ren <guoren@kernel.org> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: linux-riscv@lists.infradead.org > --- > arch/riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -362,6 +362,7 @@ config RISCV_ISA_C > config RISCV_ISA_SVPBMT > bool "SVPBMT extension support" > depends on 64BIT && MMU > + depends on !XIP_KERNEL > select RISCV_ALTERNATIVE > default y > help >
On Tue, 13 Sep 2022 05:00:08 PDT (-0700), heiko@sntech.de wrote: > Hi Palmer, > > Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap: >> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL. >> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so >> quieten this kconfig warning: >> >> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE >> Depends on [n]: !XIP_KERNEL [=y] >> Selected by [y]: >> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y] >> >> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > I think this should also be applied as fix? Thanks, the original seems to have gotten lost somewhere but I've picked this up from lore. > > Thanks > Heiko > > >> Cc: Wei Fu <wefu@redhat.com> >> Cc: Liu Shaohua <liush@allwinnertech.com> >> Cc: Guo Ren <guoren@kernel.org> >> Cc: Heiko Stuebner <heiko@sntech.de> >> Cc: Paul Walmsley <paul.walmsley@sifive.com> >> Cc: Palmer Dabbelt <palmer@dabbelt.com> >> Cc: Albert Ou <aou@eecs.berkeley.edu> >> Cc: linux-riscv@lists.infradead.org >> --- >> arch/riscv/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- a/arch/riscv/Kconfig >> +++ b/arch/riscv/Kconfig >> @@ -362,6 +362,7 @@ config RISCV_ISA_C >> config RISCV_ISA_SVPBMT >> bool "SVPBMT extension support" >> depends on 64BIT && MMU >> + depends on !XIP_KERNEL >> select RISCV_ALTERNATIVE >> default y >> help >>
On Tue, 13 Sep 2022 05:00:08 PDT (-0700), heiko@sntech.de wrote: > Hi Palmer, > > Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap: >> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL. >> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so >> quieten this kconfig warning: >> >> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE >> Depends on [n]: !XIP_KERNEL [=y] >> Selected by [y]: >> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y] >> >> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > I think this should also be applied as fix? > > Thanks > Heiko > > >> Cc: Wei Fu <wefu@redhat.com> >> Cc: Liu Shaohua <liush@allwinnertech.com> >> Cc: Guo Ren <guoren@kernel.org> >> Cc: Heiko Stuebner <heiko@sntech.de> >> Cc: Paul Walmsley <paul.walmsley@sifive.com> >> Cc: Palmer Dabbelt <palmer@dabbelt.com> >> Cc: Albert Ou <aou@eecs.berkeley.edu> >> Cc: linux-riscv@lists.infradead.org >> --- >> arch/riscv/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- a/arch/riscv/Kconfig >> +++ b/arch/riscv/Kconfig >> @@ -362,6 +362,7 @@ config RISCV_ISA_C >> config RISCV_ISA_SVPBMT >> bool "SVPBMT extension support" >> depends on 64BIT && MMU >> + depends on !XIP_KERNEL >> select RISCV_ALTERNATIVE >> default y >> help >> Thanks, this is on fixes.
--- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -362,6 +362,7 @@ config RISCV_ISA_C config RISCV_ISA_SVPBMT bool "SVPBMT extension support" depends on 64BIT && MMU + depends on !XIP_KERNEL select RISCV_ALTERNATIVE default y help
RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL. Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so quieten this kconfig warning: WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE Depends on [n]: !XIP_KERNEL [=y] Selected by [y]: - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y] Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Wei Fu <wefu@redhat.com> Cc: Liu Shaohua <liush@allwinnertech.com> Cc: Guo Ren <guoren@kernel.org> Cc: Heiko Stuebner <heiko@sntech.de> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: linux-riscv@lists.infradead.org --- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+)