| Message ID | 20220721153155.245336-6-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: iio/panel/eeprom/misc/net/spi: drop SPI CPHA and CPOL | expand |
On Thu, Jul 21, 2022 at 05:31:54PM +0200, Krzysztof Kozlowski wrote: > The spi-cpha and spi-cpol properties are device specific and should be > accepted only if device really needs them. Explicitly list them in > device bindings in preparation of their removal from generic > spi-peripheral-props.yaml schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/net/nfc/marvell,nci.yaml | 12 ++++++++++-- > .../devicetree/bindings/net/vertexcom-mse102x.yaml | 12 +++++++++--- > 2 files changed, 19 insertions(+), 5 deletions(-) This too should not be needed. Rob
diff --git a/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml b/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml index 1bcaf6ba822c..00b3918a9bf2 100644 --- a/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml +++ b/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml @@ -56,8 +56,16 @@ properties: description: | For UART type of connection. Specifies that the chip is using RTS/CTS. - spi-cpha: true - spi-cpol: true + spi-cpha: + type: boolean + description: + The device requires shifted clock phase (CPHA) mode. + + spi-cpol: + type: boolean + description: + The device requires inverse clock polarity (CPOL) mode. + spi-max-frequency: true required: diff --git a/Documentation/devicetree/bindings/net/vertexcom-mse102x.yaml b/Documentation/devicetree/bindings/net/vertexcom-mse102x.yaml index 8156a9aeb589..9dc1609f6d06 100644 --- a/Documentation/devicetree/bindings/net/vertexcom-mse102x.yaml +++ b/Documentation/devicetree/bindings/net/vertexcom-mse102x.yaml @@ -34,9 +34,15 @@ properties: interrupts: maxItems: 1 - spi-cpha: true - - spi-cpol: true + spi-cpha: + type: boolean + description: + The device requires shifted clock phase (CPHA) mode. + + spi-cpol: + type: boolean + description: + The device requires inverse clock polarity (CPOL) mode. spi-max-frequency: minimum: 6000000
The spi-cpha and spi-cpol properties are device specific and should be accepted only if device really needs them. Explicitly list them in device bindings in preparation of their removal from generic spi-peripheral-props.yaml schema. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/net/nfc/marvell,nci.yaml | 12 ++++++++++-- .../devicetree/bindings/net/vertexcom-mse102x.yaml | 12 +++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-)