diff mbox series

[5/5] ASoC: amd: enable RPL Platform acp drivers build

Message ID 20220721061035.91139-5-Syed.SabaKareem@amd.com (mailing list archive)
State Accepted
Commit 4fb35936a374758d5065b0a015c565436685c378
Headers show
Series [1/5] ASoC: amd: add RPL Platform acp header file | expand

Commit Message

Saba Kareem, Syed July 21, 2022, 6:10 a.m. UTC 
From: Syed Saba Kareem <Syed.SabaKareem@amd.com>

RPL Platform drivers can be built by selecting necessary
kernel config option.
The patch enables build support of the same.

Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/soc/amd/Kconfig      | 10 ++++++++++
 sound/soc/amd/Makefile     |  1 +
 sound/soc/amd/rpl/Makefile |  5 +++++
 3 files changed, 16 insertions(+)
 create mode 100644 sound/soc/amd/rpl/Makefile

Comments

Mark Brown July 21, 2022, 7:36 p.m. UTC | #1 
On Thu, Jul 21, 2022 at 11:40:02AM +0530, syed sabakareem wrote:
> From: Syed Saba Kareem <Syed.SabaKareem@amd.com>
> 
> RPL Platform drivers can be built by selecting necessary
> kernel config option.
> The patch enables build support of the same.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/amd/acp/acp-platform.c: In function ‘i2s_irq_handle
r’:
/build/stage/linux/sound/soc/amd/acp/acp-platform.c:108:31: error: ‘struct acp_d
ev_data’ has no member named ‘stream’
  108 |                 stream = adata->stream[i];
      |                               ^~
Mark Brown July 21, 2022, 10:21 p.m. UTC | #2 
On Thu, Jul 21, 2022 at 08:36:53PM +0100, Mark Brown wrote:
> On Thu, Jul 21, 2022 at 11:40:02AM +0530, syed sabakareem wrote:
> > From: Syed Saba Kareem <Syed.SabaKareem@amd.com>
> > 
> > RPL Platform drivers can be built by selecting necessary
> > kernel config option.
> > The patch enables build support of the same.
> 
> This breaks an x86 allmodconfig build:
> 
> /build/stage/linux/sound/soc/amd/acp/acp-platform.c: In function ‘i2s_irq_handle
> r’:
> /build/stage/linux/sound/soc/amd/acp/acp-platform.c:108:31: error: ‘struct acp_d
> ev_data’ has no member named ‘stream’
>   108 |                 stream = adata->stream[i];
>       |                               ^~

Sorry, this was actually a different commit earlier in the branch
triggering this.
Saba Kareem, Syed July 22, 2022, 10:57 a.m. UTC | #3 
[AMD Official Use Only - General]



-----Original Message-----
From: Randy Dunlap <rdunlap@infradead.org> 
Sent: Thursday, July 21, 2022 7:32 PM
To: Saba Kareem, Syed <Syed.SabaKareem@amd.com>; broonie@kernel.org; alsa-devel@alsa-project.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil-kumar.Dommati@amd.com>; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Liam Girdwood <lgirdwood@gmail.com>; Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>; Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>; Daniel Baluta <daniel.baluta@nxp.com>; Lucas Tanure <tanureal@opensource.cirrus.com>; Julian Braha <julianbraha@gmail.com>; Bard Liao <bard.liao@intel.com>; open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] ASoC: amd: enable RPL Platform acp drivers build

[CAUTION: External Email]

Hi--

On 7/20/22 23:10, syed sabakareem wrote:
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index 
> 9c2fef2ce89f..08f5289dac54 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -117,3 +117,13 @@ config SND_AMD_ACP_CONFIG
>        driver modules to use
>
>  source "sound/soc/amd/acp/Kconfig"
> +
> +config SND_SOC_AMD_RPL_ACP6x
> +        tristate "AMD Audio Coprocessor-v6.2 RPL support"
> +        depends on X86 && PCI
> +        help
> +          This option enables Audio Coprocessor i.e ACP v6.2 support 
> +on

If that "i.e" is supposed to mean "that is", then it should be "i.e.".
Or does it mean something else here?

It is a typo mistake. Will correct it.
> +          AMD RPL platform. By enabling this flag build will be
> +          triggered for ACP PCI driver.
> +          Say m if you have such a device.
> +          If unsure select "N".

--
~Randy
diff mbox series

Patch

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 9c2fef2ce89f..08f5289dac54 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -117,3 +117,13 @@  config SND_AMD_ACP_CONFIG
 	 driver modules to use
 
 source "sound/soc/amd/acp/Kconfig"
+
+config SND_SOC_AMD_RPL_ACP6x
+        tristate "AMD Audio Coprocessor-v6.2 RPL support"
+        depends on X86 && PCI
+        help
+          This option enables Audio Coprocessor i.e ACP v6.2 support on
+          AMD RPL platform. By enabling this flag build will be
+          triggered for ACP PCI driver.
+          Say m if you have such a device.
+          If unsure select "N".
diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
index 8823f6f28611..0592e7c5c407 100644
--- a/sound/soc/amd/Makefile
+++ b/sound/soc/amd/Makefile
@@ -17,3 +17,4 @@  obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
 obj-$(CONFIG_SND_SOC_AMD_ACP6x) += yc/
 obj-$(CONFIG_SND_SOC_AMD_ACP_COMMON) += acp/
 obj-$(CONFIG_SND_AMD_ACP_CONFIG) += snd-acp-config.o
+obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += rpl/
diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
new file mode 100644
index 000000000000..11a33a05e94b
--- /dev/null
+++ b/sound/soc/amd/rpl/Makefile
@@ -0,0 +1,5 @@ 
+# SPDX-License-Identifier: GPL-2.0+
+# RPL platform Support
+snd-rpl-pci-acp6x-objs	:= rpl-pci-acp6x.o
+
+obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o