| Message ID | 20220721210331.4012015-1-justinstitt@google.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drivers: iommu: fix clang -wformat warning | expand |
On Thu, Jul 21, 2022 at 02:03:31PM -0700, Justin Stitt wrote: > When building with Clang we encounter the following warning: > | drivers/iommu/msm_iommu.c:603:6: error: format specifies type 'unsigned > | short' but the argument has type 'int' [-Werror,-Wformat] sid); > > `sid` is an int, use the proper format specifier `%x`. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Reported-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Justin Stitt <justinstitt@google.com> Thanks for the patch! Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > Reported by Nathan here: > https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ > > drivers/iommu/msm_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index 428919a474c1..6a24aa804ea3 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -599,7 +599,7 @@ static int insert_iommu_master(struct device *dev, > > for (sid = 0; sid < master->num_mids; sid++) > if (master->mids[sid] == spec->args[0]) { > - dev_warn(dev, "Stream ID 0x%hx repeated; ignoring\n", > + dev_warn(dev, "Stream ID 0x%x repeated; ignoring\n", > sid); > return 0; > } > -- > 2.37.1.359.gd136c6c3e2-goog > >
On Thu, Jul 21, 2022 at 02:03:31PM -0700, Justin Stitt wrote: > drivers/iommu/msm_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.
diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c index 428919a474c1..6a24aa804ea3 100644 --- a/drivers/iommu/msm_iommu.c +++ b/drivers/iommu/msm_iommu.c @@ -599,7 +599,7 @@ static int insert_iommu_master(struct device *dev, for (sid = 0; sid < master->num_mids; sid++) if (master->mids[sid] == spec->args[0]) { - dev_warn(dev, "Stream ID 0x%hx repeated; ignoring\n", + dev_warn(dev, "Stream ID 0x%x repeated; ignoring\n", sid); return 0; }
When building with Clang we encounter the following warning: | drivers/iommu/msm_iommu.c:603:6: error: format specifies type 'unsigned | short' but the argument has type 'int' [-Werror,-Wformat] sid); `sid` is an int, use the proper format specifier `%x`. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Reported-by: Nathan Chancellor <nathan@kernel.org> Suggested-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Justin Stitt <justinstitt@google.com> --- Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ drivers/iommu/msm_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)