mbox series

[v8,0/6] pack-bitmap.c: optimize error messages

Message ID cover.1658393855.git.dyroneteng@gmail.com (mailing list archive)
Headers show
Series pack-bitmap.c: optimize error messages | expand

Message

Teng Long July 21, 2022, 9:05 a.m. UTC
From: Teng Long <dyroneteng@gmail.com>

Changes since v7:

Remove [7/7] and will move to another separate topic.

Thanks.

Teng Long (6):
  pack-bitmap.c: fix formatting of error messages
  pack-bitmap.c: mark more strings for translations
  pack-bitmap.c: rename "idx_name" to "bitmap_name"
  pack-bitmap.c: do not ignore error when opening a bitmap file
  pack-bitmap.c: using error() instead of silently returning -1
  pack-bitmap.c: continue looping when first MIDX bitmap is found

 pack-bitmap.c | 103 ++++++++++++++++++++++++++++----------------------
 1 file changed, 58 insertions(+), 45 deletions(-)

Range-diff against v7:
1:  a01ae8478d < -:  ---------- tr2: dump names if config exist in multiple scopes
-:  ---------- > 1:  7426b277ba pack-bitmap.c: fix formatting of error messages
-:  ---------- > 2:  4e493426a0 pack-bitmap.c: mark more strings for translations
-:  ---------- > 3:  263f45ba96 pack-bitmap.c: rename "idx_name" to "bitmap_name"
-:  ---------- > 4:  d11ea092d5 pack-bitmap.c: do not ignore error when opening a bitmap file
-:  ---------- > 5:  f60efe78d6 pack-bitmap.c: using error() instead of silently returning -1
-:  ---------- > 6:  83090308ad pack-bitmap.c: continue looping when first MIDX bitmap is found

Comments

Junio C Hamano July 21, 2022, 11:01 p.m. UTC | #1
"tenglong.tl" <dyroneteng@gmail.com> writes:

> From: Teng Long <dyroneteng@gmail.com>
>
> Changes since v7:
>
> Remove [7/7] and will move to another separate topic.

If that is the only change, then I am relieved, as I can safely
ignore this round ;-)

The previous round (without the last step) has been in 'next' since
Tuesday and cannot be replaced.

It seems that both of the topics are in good shape.  Let's plan to
merge the other one about showing the scope of the configuration
variable in trace2 output down to 'next' soonish.

Thanks.
Teng Long July 22, 2022, 6:17 a.m. UTC | #2
Junio C Hamano <gitster@pobox.com> writes:

> If that is the only change, then I am relieved, as I can safely
> ignore this round ;-)

Yes, only removed 7/7, the others do not change.


> The previous round (without the last step) has been in 'next' since
> Tuesday and cannot be replaced.
>
> It seems that both of the topics are in good shape.  Let's plan to
> merge the other one about showing the scope of the configuration
> variable in trace2 output down to 'next' soonish.

Oh, I see.

Thanks.