[v2,4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

Commit Message

Yuji Ishikawa July 22, 2022, 8:28 a.m. UTC

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Greg KH July 25, 2022, 12:47 p.m. UTC | #1

On Fri, Jul 22, 2022 at 05:28:57PM +0900, Yuji Ishikawa wrote:
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)

No changelog text?

No signed-off-by?

Are you sure that checkpatch passed this patch?

greg k-h

Yuji Ishikawa July 26, 2022, 6:10 a.m. UTC | #2

Sorry for this patch not being well formatted.

I'll add change log and the signed-off-by tag.
I should have checked patches with checkpatch.pl as well as testing sources with --file option.

Regards,
  Yuji 

> -----Original Message-----
> From: Greg KH <[e-mail]>
> Sent: Monday, July 25, 2022 9:47 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <[e-mail]>
> Cc: Rob Herring <[e-mail]>; Hans Verkuil <[e-mail]>;
> iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <[e-mail]>; Jonathan Corbet <[e-mail]>;
> Sumit Semwal <[e-mail]>; Christian König
> <[e-mail]>; [e-mail];
> [e-mail]; [e-mail];
> [e-mail]; [e-mail]
> Subject: Re: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti
> DNN image processing accelerator
> 
> On Fri, Jul 22, 2022 at 05:28:57PM +0900, Yuji Ishikawa wrote:
> > ---
> >  MAINTAINERS | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> No changelog text?
> 
> No signed-off-by?
> 
> Are you sure that checkpatch passed this patch?
> 
> greg k-h

Greg KH July 28, 2022, 8:46 a.m. UTC | #3

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jul 26, 2022 at 06:10:40AM +0000, [e-mail] wrote:
> Sorry for this patch not being well formatted.
> 
> I'll add change log and the signed-off-by tag.
> I should have checked patches with checkpatch.pl as well as testing sources with --file option.

Just a normal call to checkpatch will work, no need for the --file
option.

Also for new stuff, please use the --strict to see more things that you
might also want to fix up.

For future versions, also please cc: me on this series.

thanks,

greg k-h

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index dd36acc87..a2e2bd719 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2796,12 +2796,14 @@  F:	Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.yaml
 F:	Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
 F:	Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
 F:	Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml
+F:	Documentation/devicetree/bindings/soc/visconti/
 F:	Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
 F:	arch/arm64/boot/dts/toshiba/
 F:	drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
 F:	drivers/gpio/gpio-visconti.c
 F:	drivers/pci/controller/dwc/pcie-visconti.c
 F:	drivers/pinctrl/visconti/
+F:	drivers/soc/visconti/
 F:	drivers/watchdog/visconti_wdt.c
 N:	visconti