| Message ID | 20220726101131.68058-1-tanureal@opensource.cirrus.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for CLSA0101 | expand |
On Tue, 26 Jul 2022 12:11:29 +0200, Lucas Tanure wrote: > > Add Support for the CLSA0101 laptop, an Intel version of CLSA0100. > This patch has been tested using the CLSA0100, ensuring it > doesn't break the sound for it. > We appreciate it if someone with CLSA0101 could verify that this > the patch works for them. > > Lucas Tanure (2): > ALSA: hda: cs35l41: Use the CS35L41 HDA internal define > ALSA: hda: cs35l41: Support CLSA0101 Applied both patches. Thanks. Takashi
Hello, I can confirm this does _not_ work. More specifically, with these patches, the original behavior still occurs: 1. You get left channel audio from the right speaker only. 2. No sound at all after resuming from sleep. 3. You get sound after resuming from hibernate, but only as described in #1. If you apply a patch like this: https://paste-bin.xyz/71355 You get properly working audio until you put the laptop to sleep or hibernate. Upon resuming from either state, you get no audio at all. On 7/26/22 03:11, Lucas Tanure wrote: > Add Support for the CLSA0101 laptop, an Intel version of CLSA0100. > This patch has been tested using the CLSA0100, ensuring it > doesn't break the sound for it. > We appreciate it if someone with CLSA0101 could verify that this > the patch works for them. > > Lucas Tanure (2): > ALSA: hda: cs35l41: Use the CS35L41 HDA internal define > ALSA: hda: cs35l41: Support CLSA0101 > > sound/pci/hda/cs35l41_hda.c | 67 +++++++++++++++++++++-------------- > sound/pci/hda/patch_realtek.c | 12 +++++++ > 2 files changed, 53 insertions(+), 26 deletions(-) >
On Tue, 26 Jul 2022 17:35:49 +0200, Cameron Berkenpas wrote: > > Hello, > > I can confirm this does _not_ work. > > More specifically, with these patches, the original behavior still occurs: > 1. You get left channel audio from the right speaker only. > 2. No sound at all after resuming from sleep. > 3. You get sound after resuming from hibernate, but only as described in #1. > > If you apply a patch like this: https://paste-bin.xyz/71355 > > You get properly working audio until you put the laptop to sleep or > hibernate. Upon resuming from either state, you get no audio at all. OK, then let's drop them for now. Thanks for quick heads up. Takashi > > On 7/26/22 03:11, Lucas Tanure wrote: > > Add Support for the CLSA0101 laptop, an Intel version of CLSA0100. > > This patch has been tested using the CLSA0100, ensuring it > > doesn't break the sound for it. > > We appreciate it if someone with CLSA0101 could verify that this > > the patch works for them. > > > > Lucas Tanure (2): > > ALSA: hda: cs35l41: Use the CS35L41 HDA internal define > > ALSA: hda: cs35l41: Support CLSA0101 > > > > sound/pci/hda/cs35l41_hda.c | 67 +++++++++++++++++++++-------------- > > sound/pci/hda/patch_realtek.c | 12 +++++++ > > 2 files changed, 53 insertions(+), 26 deletions(-) > > >
On 7/26/22 16:35, Cameron Berkenpas wrote: > Hello, > > I can confirm this does _not_ work. > > More specifically, with these patches, the original behavior still occurs: > 1. You get left channel audio from the right speaker only. Hi, yes, I did forgot the scan and multi instantiate part. I will send V2 with the fix. > 2. No sound at all after resuming from sleep. > 3. You get sound after resuming from hibernate, but only as described in > #1. This is a different issue, that will be fixed in the future. > > If you apply a patch like this: https://paste-bin.xyz/71355 > > You get properly working audio until you put the laptop to sleep or > hibernate. Upon resuming from either state, you get no audio at all. > > On 7/26/22 03:11, Lucas Tanure wrote: >> Add Support for the CLSA0101 laptop, an Intel version of CLSA0100. >> This patch has been tested using the CLSA0100, ensuring it >> doesn't break the sound for it. >> We appreciate it if someone with CLSA0101 could verify that this >> the patch works for them. >> >> Lucas Tanure (2): >> ALSA: hda: cs35l41: Use the CS35L41 HDA internal define >> ALSA: hda: cs35l41: Support CLSA0101 >> >> sound/pci/hda/cs35l41_hda.c | 67 +++++++++++++++++++++-------------- >> sound/pci/hda/patch_realtek.c | 12 +++++++ >> 2 files changed, 53 insertions(+), 26 deletions(-) >> >