| Message ID | 20220728152118.1429161-2-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: realtek-rtl: two small improvements | expand |
Hi Martin, On Thu, 2022-07-28 at 17:21 +0200, Martin Blumenstingl wrote: > Add support for compile testing the spi-realtek-rtl driver to increase > build testing coverage. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/spi/Kconfig | 9 +++++++++ > drivers/spi/Makefile | 2 +- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 8e550269d488..d8b55efb05d5 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -969,6 +969,15 @@ config SPI_MXS > help > SPI driver for Freescale MXS devices. > > +config SPI_REALTEK_RTL > + tristate "Realtek RTL SPI controller" > + depends on HAS_IOMEM I think this is already an implied dependency, by virtue of this symbol being available only when CONFIG_SPI=y. > + depends on MACH_REALTEK_RTL || COMPILE_TEST > + default MACH_REALTEK_RTL > + help > + SPI driver for the hardware found on Realtek RLTL8380, RTL8382, > + RTL8391, RTL8392 and RTL8393 SoCs. > + Could you add how the module will be named be to the help text? See for example CONFIG_SPI_DLN2. Best, Sander > config SPI_TEGRA210_QUAD > tristate "NVIDIA Tegra QSPI Controller" > depends on ARCH_TEGRA || COMPILE_TEST > diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile > index 18bf3d8c6df7..9fe4a2aa0fd7 100644 > --- a/drivers/spi/Makefile > +++ b/drivers/spi/Makefile > @@ -105,7 +105,7 @@ obj-$(CONFIG_SPI_QUP) += spi-qup.o > obj-$(CONFIG_SPI_ROCKCHIP) += spi-rockchip.o > obj-$(CONFIG_SPI_ROCKCHIP_SFC) += spi-rockchip-sfc.o > obj-$(CONFIG_SPI_RB4XX) += spi-rb4xx.o > -obj-$(CONFIG_MACH_REALTEK_RTL) += spi-realtek-rtl.o > +obj-$(CONFIG_SPI_REALTEK_RTL) += spi-realtek-rtl.o > obj-$(CONFIG_SPI_RPCIF) += spi-rpc-if.o > obj-$(CONFIG_SPI_RSPI) += spi-rspi.o > obj-$(CONFIG_SPI_S3C24XX) += spi-s3c24xx-hw.o
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 8e550269d488..d8b55efb05d5 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -969,6 +969,15 @@ config SPI_MXS help SPI driver for Freescale MXS devices. +config SPI_REALTEK_RTL + tristate "Realtek RTL SPI controller" + depends on HAS_IOMEM + depends on MACH_REALTEK_RTL || COMPILE_TEST + default MACH_REALTEK_RTL + help + SPI driver for the hardware found on Realtek RLTL8380, RTL8382, + RTL8391, RTL8392 and RTL8393 SoCs. + config SPI_TEGRA210_QUAD tristate "NVIDIA Tegra QSPI Controller" depends on ARCH_TEGRA || COMPILE_TEST diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile index 18bf3d8c6df7..9fe4a2aa0fd7 100644 --- a/drivers/spi/Makefile +++ b/drivers/spi/Makefile @@ -105,7 +105,7 @@ obj-$(CONFIG_SPI_QUP) += spi-qup.o obj-$(CONFIG_SPI_ROCKCHIP) += spi-rockchip.o obj-$(CONFIG_SPI_ROCKCHIP_SFC) += spi-rockchip-sfc.o obj-$(CONFIG_SPI_RB4XX) += spi-rb4xx.o -obj-$(CONFIG_MACH_REALTEK_RTL) += spi-realtek-rtl.o +obj-$(CONFIG_SPI_REALTEK_RTL) += spi-realtek-rtl.o obj-$(CONFIG_SPI_RPCIF) += spi-rpc-if.o obj-$(CONFIG_SPI_RSPI) += spi-rspi.o obj-$(CONFIG_SPI_S3C24XX) += spi-s3c24xx-hw.o
Add support for compile testing the spi-realtek-rtl driver to increase build testing coverage. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/spi/Kconfig | 9 +++++++++ drivers/spi/Makefile | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-)