| Message ID | 20220727165721.37959-1-vikas.gupta@broadcom.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add framework for selftests in devlink | expand |
Wed, Jul 27, 2022 at 06:57:19PM CEST, vikas.gupta@broadcom.com wrote: >Hi, > This patchset adds support for selftests in the devlink framework. > It adds a callback .selftests_check and .selftests_run in devlink_ops. > User can add test(s) suite which is subsequently passed to the driver > and driver can opt for running particular tests based on its capabilities. > > Patchset adds a flash based test for the bnxt_en driver. > > Suggested commands at user level would be as below: > >changes from: >v8->v9: > Only SOB line fixed in 2/2. If nothing changes in the patches, you should retain the RVB tags from previous version.
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 27 Jul 2022 22:27:19 +0530 you wrote: > Hi, > This patchset adds support for selftests in the devlink framework. > It adds a callback .selftests_check and .selftests_run in devlink_ops. > User can add test(s) suite which is subsequently passed to the driver > and driver can opt for running particular tests based on its capabilities. > > Patchset adds a flash based test for the bnxt_en driver. > > [...] Here is the summary with links: - [net-next,v9,1/2] devlink: introduce framework for selftests https://git.kernel.org/netdev/net-next/c/08f588fa301b - [net-next,v9,2/2] bnxt_en: implement callbacks for devlink selftests https://git.kernel.org/netdev/net-next/c/5b6ff128fdf6 You are awesome, thank you!
Hi, This patchset adds support for selftests in the devlink framework. It adds a callback .selftests_check and .selftests_run in devlink_ops. User can add test(s) suite which is subsequently passed to the driver and driver can opt for running particular tests based on its capabilities. Patchset adds a flash based test for the bnxt_en driver. Suggested commands at user level would be as below: changes from: v8->v9: Only SOB line fixed in 2/2. v7->v8: Some nits requested by jiri@nvidia.com in v7. v6->v7: 1) Changed the macros/enums name as suggested by kuba@kernel.org. 2) Rebase with latest net-next. Dumpit impacted due to recent patches by jiri@nvidia.com. net: devlink: make sure that devlink_try_get() works with valid pointer during xarray iteration net: devlink: move net check into devlinks_xa_for_each_registered_get() v5->v6: Addressed change in .rst file only suggested by jiri@nvidia.com in patch v5. v4->v5: Addressed the changes requested by jiri@nvidia.com in patch v4. v3->v4: Addressed the changes requested by kuba@kernel.org in patch v3. v2->v3: 1) After discussions with jiri@nvidia.com, passing a testmask from user to kernel is removed and a flag based arguments are adopted. This way we can have more than 32/64 selftests defined in the kernel. Below is the format from user to kernel and vice-versa. Kernel to user for show command . Users can know what all tests are supported by the driver. A return from kernel to user if driver supports TEST1, TEST4, and TEST7. ______ |NEST | |_____ |TEST1|TEST4|TEST7|... User to kernel to execute test: If user wants to execute test4, test8, test1... ______ |NEST | |_____ |TEST4|TEST8|TEST1|... After executing the tests kernel return to user. |NEST | |_____ | NEST| |NEST| |NEST| TEST4,RES4 TEST8,RES8 TEST1, RES1 2) Added dumpit in devlink for list/show command. v1->v2: Addressed the changes requested by kuba@kernel.org in patch v1. Fixed the style issues. Thanks, Vikas *** BLURB HERE *** Vikas Gupta (1): devlink: introduce framework for selftests vikas (1): bnxt_en: implement callbacks for devlink selftests .../networking/devlink/devlink-selftests.rst | 38 +++ .../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 61 +++++ .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 24 +- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 12 + include/net/devlink.h | 21 ++ include/uapi/linux/devlink.h | 29 +++ net/core/devlink.c | 216 ++++++++++++++++++ 7 files changed, 389 insertions(+), 12 deletions(-) create mode 100644 Documentation/networking/devlink/devlink-selftests.rst