| Message ID | 082003d00be1f05578c9c6434272ceb314609b8e.1659285240.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2e8f205d910eb1fc59faf24582f3faf774000360 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: txgbe: Fix an error handling path in txgbe_probe() | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Sun, 31 Jul 2022 18:34:15 +0200 you wrote: > A pci_enable_pcie_error_reporting() should be balanced by a corresponding > pci_disable_pcie_error_reporting() call in the error handling path, as > already done in the remove function. > > Fixes: 3ce7547e5b71 ("net: txgbe: Add build support for txgbe") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > [...] Here is the summary with links: - net: txgbe: Fix an error handling path in txgbe_probe() https://git.kernel.org/netdev/net-next/c/2e8f205d910e You are awesome, thank you!
On Mon, 1 Aug 2022 10:54:44 +0800 Jiawen Wu wrote: > On Monday, August 1, 2022 12:34 AM, Christophe wrote: > > A pci_enable_pcie_error_reporting() should be balanced by a corresponding > > pci_disable_pcie_error_reporting() call in the error handling path, as already > > done in the remove function. > > Thanks Christophe, it's right. > Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com> Your reply did not make it to the list: https://lore.kernel.org/r/02a101d8a552$0e704650$2b50d2f0$@trustnetic.com+898582B7F010EAA4/ not sure why but I wanted to let you know. Thanks for reviewing the fix promptly!
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c index 55c3c720b377..d3b9f73ecba4 100644 --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c @@ -123,6 +123,7 @@ static int txgbe_probe(struct pci_dev *pdev, return 0; err_pci_release_regions: + pci_disable_pcie_error_reporting(pdev); pci_release_selected_regions(pdev, pci_select_bars(pdev, IORESOURCE_MEM)); err_pci_disable_dev:
A pci_enable_pcie_error_reporting() should be balanced by a corresponding pci_disable_pcie_error_reporting() call in the error handling path, as already done in the remove function. Fixes: 3ce7547e5b71 ("net: txgbe: Add build support for txgbe") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 1 + 1 file changed, 1 insertion(+)