| Message ID | 20220808110545.62886-2-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | libxl: replace deprecated -sdl and -soundhw qemu options | expand |
On Mon, Aug 8, 2022 at 7:06 AM Anthony PERARD <anthony.perard@citrix.com> wrote: > > "-sdl" is deprecated upstream since 6695e4c0fd9e ("softmmu/vl: > Deprecate the -sdl and -curses option"), QEMU v6.2, and the option is > removed by 707d93d4abc6 ("ui: Remove deprecated options "-sdl" and > "-curses""), in upcoming QEMU v7.1. > > Instead, use "-display sdl", available since 1472a95bab1e ("Introduce > -display argument"), before QEMU v1.0. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 1864ee30f0..04bf5d8563 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1349,7 +1349,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append_pair(dm_args, "-display", "none"); if (sdl && !is_stubdom) { - flexarray_append(dm_args, "-sdl"); + flexarray_append_pair(dm_args, "-display", "sdl"); if (sdl->display) flexarray_append_pair(dm_envs, "DISPLAY", sdl->display); if (sdl->xauthority)
"-sdl" is deprecated upstream since 6695e4c0fd9e ("softmmu/vl: Deprecate the -sdl and -curses option"), QEMU v6.2, and the option is removed by 707d93d4abc6 ("ui: Remove deprecated options "-sdl" and "-curses""), in upcoming QEMU v7.1. Instead, use "-display sdl", available since 1472a95bab1e ("Introduce -display argument"), before QEMU v1.0. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libs/light/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)