Message ID | 1660117558-21829-3-git-send-email-quic_srivasam@quicinc.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | Update ADSP pil loader for SC7280 platform | expand |
On Wed, 10 Aug 2022 13:15:52 +0530, Srinivasa Rao Mandadapu wrote: > Add compatible name, clocks and update max reg items for SC7280 > based platforms. > Add adsp-memory-regions property, required for memory sandboxing. > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes since V2: > -- Add clock property. > -- Add qcom,adsp-memory-regions property. > Changes since V1: > -- Change reg property maxItems to minItems and update description. > > .../bindings/remoteproc/qcom,lpass-adsp-pil.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml: properties:qcom,adsp-memory-regions: 'oneOf' conditional failed, one must be fixed: [{'description': 'List of memory regions accessed by ADSP firmware.'}] is too short False schema does not allow 1 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml: properties:qcom,adsp-memory-regions: 'oneOf' conditional failed, one must be fixed: 'type' is a required property hint: A vendor boolean property can use "type: boolean" 'description' is a required property hint: A vendor boolean property can use "type: boolean" Additional properties are not allowed ('items', 'minItems' were unexpected) hint: A vendor boolean property can use "type: boolean" /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml: properties:qcom,adsp-memory-regions: 'oneOf' conditional failed, one must be fixed: 'enum' is a required property 'const' is a required property hint: A vendor string property with exact values has an implicit type from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml: properties:qcom,adsp-memory-regions: 'oneOf' conditional failed, one must be fixed: '$ref' is a required property 'allOf' is a required property hint: A vendor property needs a $ref to types.yaml from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# hint: Vendor specific properties must have a type and description unless they have a defined, common suffix. from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml: ignoring, error in schema: properties: qcom,adsp-memory-regions Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.example.dtb:0:0: /example-0/remoteproc@17300000: failed to match any schema with compatible: ['qcom,sdm845-adsp-pil'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml index 9f11332..45bc732 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,lpass-adsp-pil.yaml @@ -17,11 +17,13 @@ properties: compatible: enum: - qcom,sdm845-adsp-pil + - qcom,sc7280-adsp-pil reg: - maxItems: 1 - description: - The base address and size of the qdsp6ss register + minItems: 1 + items: + - description: qdsp6ss register + - description: efuse q6ss register interrupts: items: @@ -48,6 +50,7 @@ properties: - description: QDSP XO clock - description: Q6SP6SS SLEEP clock - description: Q6SP6SS CORE clock + - description: GCC CFG NOC clock clock-names: items: @@ -58,6 +61,7 @@ properties: - const: qdsp6ss_xo - const: qdsp6ss_sleep - const: qdsp6ss_core + - const: gcc_cfg_noc power-domains: items: @@ -77,6 +81,11 @@ properties: maxItems: 1 description: Reference to the reserved-memory for the Hexagon core + qcom,adsp-memory-regions: + minItems: 1 + items: + - description: List of memory regions accessed by ADSP firmware. + qcom,halt-regs: $ref: /schemas/types.yaml#/definitions/phandle-array description: