| Message ID | 20220811091713.10427-2-justin.he@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Modularize ghes_edac driver | expand |
On Thu, 11 Aug 2022 at 11:17, Jia He <justin.he@arm.com> wrote: > > Before modularizing the ghes_edac codes, we need to export several efi/cper > helpers to avoid linking error of ghes_edac. > > Signed-off-by: Jia He <justin.he@arm.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> > --- > drivers/firmware/efi/cper.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c > index e4e5ea7ce910..053eae13f409 100644 > --- a/drivers/firmware/efi/cper.c > +++ b/drivers/firmware/efi/cper.c > @@ -290,6 +290,7 @@ int cper_mem_err_location(struct cper_mem_err_compact *mem, char *msg) > > return n; > } > +EXPORT_SYMBOL_GPL(cper_mem_err_location); > > int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg) > { > @@ -310,6 +311,7 @@ int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg) > > return n; > } > +EXPORT_SYMBOL_GPL(cper_dimm_err_location); > > void cper_mem_err_pack(const struct cper_sec_mem_err *mem, > struct cper_mem_err_compact *cmem) > @@ -331,6 +333,7 @@ void cper_mem_err_pack(const struct cper_sec_mem_err *mem, > cmem->mem_array_handle = mem->mem_array_handle; > cmem->mem_dev_handle = mem->mem_dev_handle; > } > +EXPORT_SYMBOL_GPL(cper_mem_err_pack); > > const char *cper_mem_err_unpack(struct trace_seq *p, > struct cper_mem_err_compact *cmem) > -- > 2.25.1 >
On Thu, Aug 11, 2022 at 09:17:12AM +0000, Jia He wrote:
> Before modularizing the ghes_edac codes, we need to export several efi/cper
Who's we?
Please use passive voice in your commit message: no "we" or "I", etc,
and describe your changes in imperative mood.
Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details.
Also, see section "Changelog" in
Documentation/process/maintainer-tip.rst
Bottom line is: personal pronouns are ambiguous in text, especially with
so many parties/companies/etc developing the kernel so let's avoid them
please.
Hi Boris > -----Original Message----- > From: Borislav Petkov <bp@alien8.de> > Sent: Friday, August 12, 2022 10:46 PM > To: Justin He <Justin.He@arm.com> > Cc: Ard Biesheuvel <ardb@kernel.org>; Len Brown <lenb@kernel.org>; James > Morse <James.Morse@arm.com>; Tony Luck <tony.luck@intel.com>; Mauro > Carvalho Chehab <mchehab@kernel.org>; Robert Richter <rric@kernel.org>; > Robert Moore <robert.moore@intel.com>; linux-acpi@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-edac@vger.kernel.org; devel@acpica.org; > Rafael J . Wysocki <rafael@kernel.org>; Shuai Xue > <xueshuai@linux.alibaba.com>; Jarkko Sakkinen <jarkko@kernel.org>; > linux-efi@vger.kernel.org; nd <nd@arm.com>; toshi.kani@hpe.com > Subject: Re: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use > > On Thu, Aug 11, 2022 at 09:17:12AM +0000, Jia He wrote: > > Before modularizing the ghes_edac codes, we need to export several > > efi/cper > > Who's we? > > Please use passive voice in your commit message: no "we" or "I", etc, and > describe your changes in imperative mood. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst for more details. > > Also, see section "Changelog" in > Documentation/process/maintainer-tip.rst > > Bottom line is: personal pronouns are ambiguous in text, especially with so > many parties/companies/etc developing the kernel so let's avoid them please. Okay，I will fix the commit description in next version. -- Cheers, Justin (Jia He)
diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index e4e5ea7ce910..053eae13f409 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -290,6 +290,7 @@ int cper_mem_err_location(struct cper_mem_err_compact *mem, char *msg) return n; } +EXPORT_SYMBOL_GPL(cper_mem_err_location); int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg) { @@ -310,6 +311,7 @@ int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg) return n; } +EXPORT_SYMBOL_GPL(cper_dimm_err_location); void cper_mem_err_pack(const struct cper_sec_mem_err *mem, struct cper_mem_err_compact *cmem) @@ -331,6 +333,7 @@ void cper_mem_err_pack(const struct cper_sec_mem_err *mem, cmem->mem_array_handle = mem->mem_array_handle; cmem->mem_dev_handle = mem->mem_dev_handle; } +EXPORT_SYMBOL_GPL(cper_mem_err_pack); const char *cper_mem_err_unpack(struct trace_seq *p, struct cper_mem_err_compact *cmem)
Before modularizing the ghes_edac codes, we need to export several efi/cper helpers to avoid linking error of ghes_edac. Signed-off-by: Jia He <justin.he@arm.com> --- drivers/firmware/efi/cper.c | 3 +++ 1 file changed, 3 insertions(+)