| Message ID | 07a2dcebf8ede69b484103de8f9df043f158cffd.1658862932.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] mmc: pxamci: Fix an error handling path in pxamci_probe() | expand |
On Tue, 26 Jul 2022 at 21:15, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > The commit in Fixes: has introduced an new error handling without branching > to the existing error handling path. > > Update it now and release some resources if pxamci_init_ocr() fails. > > Fixes: 61951fd6cb49 ("mmc: pxamci: let mmc core handle regulators") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied for fixes and by adding stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/pxamci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c > index 37bf362a0ed5..e4003f6058eb 100644 > --- a/drivers/mmc/host/pxamci.c > +++ b/drivers/mmc/host/pxamci.c > @@ -672,7 +672,7 @@ static int pxamci_probe(struct platform_device *pdev) > > ret = pxamci_init_ocr(host); > if (ret < 0) > - return ret; > + goto out; > > mmc->caps = 0; > host->cmdat = 0; > -- > 2.34.1 >
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 37bf362a0ed5..e4003f6058eb 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -672,7 +672,7 @@ static int pxamci_probe(struct platform_device *pdev) ret = pxamci_init_ocr(host); if (ret < 0) - return ret; + goto out; mmc->caps = 0; host->cmdat = 0;
The commit in Fixes: has introduced an new error handling without branching to the existing error handling path. Update it now and release some resources if pxamci_init_ocr() fails. Fixes: 61951fd6cb49 ("mmc: pxamci: let mmc core handle regulators") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/mmc/host/pxamci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)