diff mbox series

[v2] test/xattr: don't rely on NUL-termination

Message ID 20220816105134.9824-1-jslaby@suse.cz (mailing list archive)
State New
Headers show
Series [v2] test/xattr: don't rely on NUL-termination | expand

Commit Message

Jiri Slaby Aug. 16, 2022, 10:51 a.m. UTC 
The returned value from io_uring_fgetxattr() needs not be NUL-terminated,
as we stored non-NUL-terminated string by io_uring_fsetxattr()
previously.

So don't use strlen() on value, but on VALUE1, and VALUE2 respectively.

This fixes random test failures.

Cc: Stefan Roesch <shr@fb.com>
Fixes: d6515e06f73c ("liburing: Add new test program to verify xattr support")
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
[v2] added Fixes, Cc, and fixed a typo in the message above.

 test/xattr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jens Axboe Aug. 16, 2022, 12:23 p.m. UTC | #1 
On Tue, 16 Aug 2022 12:51:34 +0200, Jiri Slaby wrote:
> The returned value from io_uring_fgetxattr() needs not be NUL-terminated,
> as we stored non-NUL-terminated string by io_uring_fsetxattr()
> previously.
> 
> So don't use strlen() on value, but on VALUE1, and VALUE2 respectively.
> 
> This fixes random test failures.
> 
> [...]

Applied, thanks!

[1/1] test/xattr: don't rely on NUL-termination
      commit: bf3fedba890e66d644692910964fe1d8cbf4fb1b

Best regards,
diff mbox series

Patch

diff --git a/test/xattr.c b/test/xattr.c
index d88059cb..101d82b3 100644
--- a/test/xattr.c
+++ b/test/xattr.c
@@ -210,14 +210,14 @@  static int test_fxattr(void)
 
 	/* Test reading attributes. */
 	value_len = io_uring_fgetxattr(&ring, fd, KEY1, value, XATTR_SIZE);
-	if (value_len != strlen(value) || strncmp(value, VALUE1, value_len)) {
+	if (value_len != strlen(VALUE1) || strncmp(value, VALUE1, value_len)) {
 		fprintf(stderr, "Error: fgetxattr expected value: %s, returned value: %s\n", VALUE1, value);
 		rc = -1;
 		goto Exit;
 	}
 
 	value_len = io_uring_fgetxattr(&ring, fd, KEY2, value, XATTR_SIZE);
-	if (value_len != strlen(value)|| strncmp(value, VALUE2, value_len)) {
+	if (value_len != strlen(VALUE2) || strncmp(value, VALUE2, value_len)) {
 		fprintf(stderr, "Error: fgetxattr expected value: %s, returned value: %s\n", VALUE2, value);
 		rc = -1;
 		goto Exit;