diff mbox series

iio: pressure: bmp280: fix datasheet links

Message ID 6e908cc827c70b95dae683717592aff0b003e7c9.1660606478.git.ang.iglesiasg@gmail.com (mailing list archive)
State Changes Requested
Headers show
Series iio: pressure: bmp280: fix datasheet links | expand

Commit Message

Angel Iglesias Aug. 15, 2022, 11:38 p.m. UTC 
Updated links for BMP280 and BME280 datasheets on Bosch website.
Datasheet of BMP180 is no longer available on the manufacturer's website,
changed the link to a copy hosted by a third party.

Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
---
 drivers/iio/pressure/bmp280-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: b82217e73b5aa6db8453ad91b929ca2366e47184

Comments

Andy Shevchenko Aug. 19, 2022, 9:37 a.m. UTC | #1 
On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>
> Updated links for BMP280 and BME280 datasheets on Bosch website.

> Datasheet of BMP180 is no longer available on the manufacturer's website,
> changed the link to a copy hosted by a third party.

Note, that the version is downgraded (from 12.1 to 9).

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> ---
>  drivers/iio/pressure/bmp280-core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index fe7aa81e7cc9..e98b024d510b 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -9,9 +9,9 @@
>   * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
>   *
>   * Datasheet:
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> - * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> + * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> + * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
>   */
>
>  #define pr_fmt(fmt) "bmp280: " fmt
>
> base-commit: b82217e73b5aa6db8453ad91b929ca2366e47184
> --
> 2.37.2
>
Angel Iglesias Aug. 19, 2022, 10:31 a.m. UTC | #2 
On Fri, 2022-08-19 at 12:37 +0300, Andy Shevchenko wrote:
> On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> wrote:
> > 
> > Updated links for BMP280 and BME280 datasheets on Bosch website.
> 
> > Datasheet of BMP180 is no longer available on the manufacturer's website,
> > changed the link to a copy hosted by a third party.
> 
> Note, that the version is downgraded (from 12.1 to 9).

Apologies, I forgot to add a note about this. Changelog on datasheet 12.1 listed
these three changes from version 9:
* Page 26: Changed document referral from ANP015 to BST-MPS-AN004-00
* Chapter 3.5: New equation for B3 (adds a long cast to AC1)
* Page 26: Updated RoHS directive to 2011/65/EU effective 8 June 2011

Unfortunately, I couldn't find the most updated version in good quality hosted
in a trustworthy place.

> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > ---
> >  drivers/iio/pressure/bmp280-core.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/pressure/bmp280-core.c
> > b/drivers/iio/pressure/bmp280-core.c
> > index fe7aa81e7cc9..e98b024d510b 100644
> > --- a/drivers/iio/pressure/bmp280-core.c
> > +++ b/drivers/iio/pressure/bmp280-core.c
> > @@ -9,9 +9,9 @@
> >   * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
> >   *
> >   * Datasheet:
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> > + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
> >   */
> > 
> >  #define pr_fmt(fmt) "bmp280: " fmt
> > 
> > base-commit: b82217e73b5aa6db8453ad91b929ca2366e47184
> > --
> > 2.37.2
> > 
> 
> 
Kind regards,
Angel
Andy Shevchenko Aug. 19, 2022, 10:33 a.m. UTC | #3 
On Fri, Aug 19, 2022 at 1:31 PM Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
> On Fri, 2022-08-19 at 12:37 +0300, Andy Shevchenko wrote:
> > On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> > wrote:
> > >
> > > Updated links for BMP280 and BME280 datasheets on Bosch website.
> >
> > > Datasheet of BMP180 is no longer available on the manufacturer's website,
> > > changed the link to a copy hosted by a third party.
> >
> > Note, that the version is downgraded (from 12.1 to 9).
>
> Apologies, I forgot to add a note about this. Changelog on datasheet 12.1 listed
> these three changes from version 9:
> * Page 26: Changed document referral from ANP015 to BST-MPS-AN004-00
> * Chapter 3.5: New equation for B3 (adds a long cast to AC1)
> * Page 26: Updated RoHS directive to 2011/65/EU effective 8 June 2011

Perhaps you may add this to the comment below into the code.

> Unfortunately, I couldn't find the most updated version in good quality hosted
> in a trustworthy place.

Me neither.

> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Angel Iglesias Aug. 19, 2022, 11:09 a.m. UTC | #4 
On Fri, 2022-08-19 at 13:33 +0300, Andy Shevchenko wrote:
> On Fri, Aug 19, 2022 at 1:31 PM Angel Iglesias <ang.iglesiasg@gmail.com>
> wrote:
> > On Fri, 2022-08-19 at 12:37 +0300, Andy Shevchenko wrote:
> > > On Tue, Aug 16, 2022 at 2:39 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> > > wrote:
> > > > 
> > > > Updated links for BMP280 and BME280 datasheets on Bosch website.
> > > 
> > > > Datasheet of BMP180 is no longer available on the manufacturer's
> > > > website,
> > > > changed the link to a copy hosted by a third party.
> > > 
> > > Note, that the version is downgraded (from 12.1 to 9).
> > 
> > Apologies, I forgot to add a note about this. Changelog on datasheet 12.1
> > listed
> > these three changes from version 9:
> > * Page 26: Changed document referral from ANP015 to BST-MPS-AN004-00
> > * Chapter 3.5: New equation for B3 (adds a long cast to AC1)
> > * Page 26: Updated RoHS directive to 2011/65/EU effective 8 June 2011
> 
> Perhaps you may add this to the comment below into the code.

Will do, thanks

> 
> > Unfortunately, I couldn't find the most updated version in good quality
> > hosted
> > in a trustworthy place.
> 
> Me neither.
> 
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 

Kind regards,
Angel
diff mbox series

Patch

diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index fe7aa81e7cc9..e98b024d510b 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -9,9 +9,9 @@ 
  * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
  *
  * Datasheet:
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
- * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
+ * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
+ * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
+ * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
  */
 
 #define pr_fmt(fmt) "bmp280: " fmt