| Message ID | cover.1660934107.git.mazziesaccount@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use devm helpers for regulator get and enable | expand |
On Fri, Aug 19, 2022 at 10:20 PM Matti Vaittinen <mazziesaccount@gmail.com> wrote: > > Use devm helpers for regulator get and enable > > NOTE: The series depends on commit > ee94aff2628b ("Devm helpers for regulator get and enable") > which currently sits in Mark's regulator/for-next > > A few* drivers seem to pattern demonstrated by pseudocode: > > - devm_regulator_get() > - regulator_enable() > - devm_add_action_or_reset(regulator_disable()) > > devm helpers for this pattern were added to remove bunch of code from remove a bunch > drivers. Typically following: > > - replace 3 calls (devm_regulator_get[_optional](), regulator_enable(), > devm_add_action_or_reset()) with just one > (devm_regulator_get_enable[_optional]()). > - drop disable callback. > > I believe this simplifies things by removing some dublicated code. duplicated > This series reowrks a few drivers. There is still plenty of fish in the reworks > sea for people who like to improve the code (or count the beans ;]). > > Finally - most of the converted drivers have not been tested (other than > compile-tested) due to lack of HW. All reviews and testing is _highly_ > appreciated (as always!). ... > docs: devres: regulator: Add new get_enable functions to devres.rst > clk: cdce925: simplify using devm_regulator_get_enable() > gpu: drm: simplify drivers using devm_regulator_*get_enable*() > hwmon: lm90: simplify using devm_regulator_get_enable() > hwmon: adm1177: simplify using devm_regulator_get_enable() hwmon uses a different pattern for the Subject line.
Use devm helpers for regulator get and enable NOTE: The series depends on commit ee94aff2628b ("Devm helpers for regulator get and enable") which currently sits in Mark's regulator/for-next A few* drivers seem to pattern demonstrated by pseudocode: - devm_regulator_get() - regulator_enable() - devm_add_action_or_reset(regulator_disable()) devm helpers for this pattern were added to remove bunch of code from drivers. Typically following: - replace 3 calls (devm_regulator_get[_optional](), regulator_enable(), devm_add_action_or_reset()) with just one (devm_regulator_get_enable[_optional]()). - drop disable callback. I believe this simplifies things by removing some dublicated code. This series reowrks a few drivers. There is still plenty of fish in the sea for people who like to improve the code (or count the beans ;]). Finally - most of the converted drivers have not been tested (other than compile-tested) due to lack of HW. All reviews and testing is _highly_ appreciated (as always!). Revision history: v3: - Drop already applied helper patches - Add a few more drivers RFCv1 => v2: - Add devm_regulator_bulk_get_enable() and devm_regulator_bulk_put() - Convert a couple of drivers to use the new devm_regulator_bulk_get_enable(). - Squash all IIO patches into one. Patch 1: Add new devm-helper APIs to docs. Patch 2: simplified CLK driver(s) Patch 3: simplified GPU driver(s) Patch 4 - 5: simplified hwmon driver(s) Patch 6 - 14: simplified IIO driver(s) --- Matti Vaittinen (14): docs: devres: regulator: Add new get_enable functions to devres.rst clk: cdce925: simplify using devm_regulator_get_enable() gpu: drm: simplify drivers using devm_regulator_*get_enable*() hwmon: lm90: simplify using devm_regulator_get_enable() hwmon: adm1177: simplify using devm_regulator_get_enable() iio: ad7192: Simplify using devm_regulator_get_enable() iio: ltc2688: Simplify using devm_regulator_*get_enable() iio: bmg160_core: Simplify using devm_regulator_*get_enable() iio: st_lsm6dsx: Simplify using devm_regulator_*get_enable() iio: ad7476: simplify using devm_regulator_get_enable() iio: ad7606: simplify using devm_regulator_get_enable() iio: max1241: simplify using devm_regulator_get_enable() iio: max1363: simplify using devm_regulator_get_enable() iio: hmc425a: simplify using devm_regulator_get_enable() .../driver-api/driver-model/devres.rst | 4 +++ drivers/clk/clk-cdce925.c | 21 +++---------- drivers/gpu/drm/bridge/sii902x.c | 22 ++------------ drivers/gpu/drm/meson/meson_dw_hdmi.c | 23 ++------------ drivers/hwmon/adm1177.c | 27 ++--------------- drivers/hwmon/lm90.c | 15 ++-------- drivers/iio/adc/ad7192.c | 15 ++-------- drivers/iio/adc/ad7476.c | 11 +------ drivers/iio/adc/ad7606.c | 22 ++------------ drivers/iio/adc/ad7606.h | 1 - drivers/iio/adc/max1241.c | 28 ++--------------- drivers/iio/adc/max1363.c | 11 +------ drivers/iio/amplifiers/hmc425a.c | 17 +---------- drivers/iio/dac/ltc2688.c | 23 ++------------ drivers/iio/gyro/bmg160_core.c | 24 ++------------- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 2 -- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 30 ++++--------------- 17 files changed, 41 insertions(+), 255 deletions(-)