| Message ID | 20220711075202.21775-1-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel-edp: add AUO B133UAN02.1 panel entry | expand |
On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > Add an eDP panel entry for AUO B133UAN02.1. > > Due to lack of documentation, use the delay_200_500_e50 timings like > some other AUO entries for now. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Any comments to this one? It looks like it hasn't shown up in the dri-devel patchwork and just want to make sure it isn't lost. Rob Clark mentioned something about a spam filter on IRC. > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c > index fe3897b86665..30f69cd8f9ee 100644 > --- a/drivers/gpu/drm/panel/panel-edp.c > +++ b/drivers/gpu/drm/panel/panel-edp.c > @@ -1845,6 +1845,7 @@ static const struct panel_delay delay_100_500_e200 = { > * Sort first by vendor, then by product ID. > */ > static const struct edp_panel_entry edp_panels[] = { > + EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"), > EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"), > EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"), > EDP_PANEL_ENTRY('A', 'U', 'O', 0x8594, &delay_200_500_e50, "B133UAN01.0"), Johan
On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > Add an eDP panel entry for AUO B133UAN02.1. > > > > Due to lack of documentation, use the delay_200_500_e50 timings like > > some other AUO entries for now. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > Any comments to this one? > > It looks like it hasn't shown up in the dri-devel patchwork and just > want to make sure it isn't lost. > > Rob Clark mentioned something about a spam filter on IRC. This one still hasn't been picked up. Is this something you can do, Doug? I noticed you applied a couple of patches to this driver recently. Or who is really responsible for this driver? > > --- > > drivers/gpu/drm/panel/panel-edp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c > > index fe3897b86665..30f69cd8f9ee 100644 > > --- a/drivers/gpu/drm/panel/panel-edp.c > > +++ b/drivers/gpu/drm/panel/panel-edp.c > > @@ -1845,6 +1845,7 @@ static const struct panel_delay delay_100_500_e200 = { > > * Sort first by vendor, then by product ID. > > */ > > static const struct edp_panel_entry edp_panels[] = { > > + EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"), > > EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"), > > EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"), > > EDP_PANEL_ENTRY('A', 'U', 'O', 0x8594, &delay_200_500_e50, "B133UAN01.0"), Johan
Hi, On Mon, Aug 22, 2022 at 6:35 AM Johan Hovold <johan@kernel.org> wrote: > > On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > > Add an eDP panel entry for AUO B133UAN02.1. > > > > > > Due to lack of documentation, use the delay_200_500_e50 timings like > > > some other AUO entries for now. > > > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > > > Any comments to this one? > > > > It looks like it hasn't shown up in the dri-devel patchwork and just > > want to make sure it isn't lost. > > > > Rob Clark mentioned something about a spam filter on IRC. > > This one still hasn't been picked up. > > Is this something you can do, Doug? I noticed you applied a couple of > patches to this driver recently. > > Or who is really responsible for this driver? Officially it falls within this section of maintainers: DRM PANEL DRIVERS M: Thierry Reding <thierry.reding@gmail.com> R: Sam Ravnborg <sam@ravnborg.org> L: dri-devel@lists.freedesktop.org S: Maintained T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/panel/ F: drivers/gpu/drm/drm_panel.c F: drivers/gpu/drm/panel/ F: include/drm/drm_panel.h ...and then you just have to know that if the "tree" is drm-misc that it falls under drm-misc rules. That means that anyone who is a drm-misc-next committer can commit it. I've been trying to keep an eye on panel-edp ever since I split it out from panel-simple, though. I'll post up a MAINTAINERS entry to try to make that more official. In any case, I've landed this on drm-misc-next: ee50b0024408 drm/panel-edp: add AUO B133UAN02.1 panel entry -Doug
Hi, On Mon, Aug 22, 2022 at 10:33 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Mon, Aug 22, 2022 at 6:35 AM Johan Hovold <johan@kernel.org> wrote: > > > > On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > > > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > > > Add an eDP panel entry for AUO B133UAN02.1. > > > > > > > > Due to lack of documentation, use the delay_200_500_e50 timings like > > > > some other AUO entries for now. > > > > > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > > > > > Any comments to this one? > > > > > > It looks like it hasn't shown up in the dri-devel patchwork and just > > > want to make sure it isn't lost. > > > > > > Rob Clark mentioned something about a spam filter on IRC. > > > > This one still hasn't been picked up. > > > > Is this something you can do, Doug? I noticed you applied a couple of > > patches to this driver recently. > > > > Or who is really responsible for this driver? > > Officially it falls within this section of maintainers: > > DRM PANEL DRIVERS > M: Thierry Reding <thierry.reding@gmail.com> > R: Sam Ravnborg <sam@ravnborg.org> > L: dri-devel@lists.freedesktop.org > S: Maintained > T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/panel/ > F: drivers/gpu/drm/drm_panel.c > F: drivers/gpu/drm/panel/ > F: include/drm/drm_panel.h > > ...and then you just have to know that if the "tree" is drm-misc that > it falls under drm-misc rules. That means that anyone who is a > drm-misc-next committer can commit it. > > I've been trying to keep an eye on panel-edp ever since I split it out > from panel-simple, though. I'll post up a MAINTAINERS entry to try to > make that more official. Posted a patch to add myself in MAINTAINERS: https://lore.kernel.org/r/20220822105340.1.I66a9a5577f9b0af66492ef13c47bc78ed85e5d6b@changeid ...though I had a brain-fail and didn't CC anyone on it. ;-) -Doug
On Mon, Aug 22, 2022 at 10:33:40AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Aug 22, 2022 at 6:35 AM Johan Hovold <johan@kernel.org> wrote: > > > > On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > > > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > > > Add an eDP panel entry for AUO B133UAN02.1. > > > > > > > > Due to lack of documentation, use the delay_200_500_e50 timings like > > > > some other AUO entries for now. > > > > > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > This one still hasn't been picked up. > > > > Is this something you can do, Doug? I noticed you applied a couple of > > patches to this driver recently. > > > > Or who is really responsible for this driver? > > Officially it falls within this section of maintainers: > > DRM PANEL DRIVERS > M: Thierry Reding <thierry.reding@gmail.com> > R: Sam Ravnborg <sam@ravnborg.org> > L: dri-devel@lists.freedesktop.org > S: Maintained > T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/panel/ > F: drivers/gpu/drm/drm_panel.c > F: drivers/gpu/drm/panel/ > F: include/drm/drm_panel.h > > ...and then you just have to know that if the "tree" is drm-misc that > it falls under drm-misc rules. That means that anyone who is a > drm-misc-next committer can commit it. > > I've been trying to keep an eye on panel-edp ever since I split it out > from panel-simple, though. I'll post up a MAINTAINERS entry to try to > make that more official. Sounds good. > In any case, I've landed this on drm-misc-next: > > ee50b0024408 drm/panel-edp: add AUO B133UAN02.1 panel entry Thanks for that! Perhaps you can take look also at this one: https://lore.kernel.org/all/20220720054152.2450-1-steev@kali.org/ which is for another panel found on some X13s? Johan
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index fe3897b86665..30f69cd8f9ee 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1845,6 +1845,7 @@ static const struct panel_delay delay_100_500_e200 = { * Sort first by vendor, then by product ID. */ static const struct edp_panel_entry edp_panels[] = { + EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x8594, &delay_200_500_e50, "B133UAN01.0"),
Add an eDP panel entry for AUO B133UAN02.1. Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+)