diff mbox series

arm64: dts: rockchip: Lower sd speed on quartz64-b

Message ID 20220721044307.48641-1-frattaroli.nicolas@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: rockchip: Lower sd speed on quartz64-b | expand

Commit Message

Nicolas Frattaroli July 21, 2022, 4:43 a.m. UTC
The previously stated speed of sdr-104 is too high for the hardware
to reliably communicate with some fast SD cards.

Lower this to sd-uhs-sdr50 to fix this.

Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")

Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Geis July 22, 2022, 5:54 a.m. UTC | #1
On Thu, Jul 21, 2022 at 6:43 AM Nicolas Frattaroli
<frattaroli.nicolas@gmail.com> wrote:
>
> The previously stated speed of sdr-104 is too high for the hardware
> to reliably communicate with some fast SD cards.
>
> Lower this to sd-uhs-sdr50 to fix this.

I can confirm this is necessary. Thanks!

Tested-by: Peter Geis <pgwipeout@gmail.com>

>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
>
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 02d5f5a8ca03..528bb4e8ac77 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -506,7 +506,7 @@ &sdmmc0 {
>         disable-wp;
>         pinctrl-names = "default";
>         pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> -       sd-uhs-sdr104;
> +       sd-uhs-sdr50;
>         vmmc-supply = <&vcc3v3_sd>;
>         vqmmc-supply = <&vccio_sd>;
>         status = "okay";
> --
> 2.37.1
>
Nicolas Frattaroli Aug. 19, 2022, 11:53 p.m. UTC | #2
On Donnerstag, 21. Juli 2022 06:43:06 CEST Nicolas Frattaroli wrote:
> The previously stated speed of sdr-104 is too high for the hardware
> to reliably communicate with some fast SD cards.
> 
> Lower this to sd-uhs-sdr50 to fix this.
> 
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
> 
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 02d5f5a8ca03..528bb4e8ac77 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -506,7 +506,7 @@ &sdmmc0 {
>  	disable-wp;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> -	sd-uhs-sdr104;
> +	sd-uhs-sdr50;
>  	vmmc-supply = <&vcc3v3_sd>;
>  	vqmmc-supply = <&vccio_sd>;
>  	status = "okay";
> 

Please apply. Thank you!
Heiko Stübner Aug. 23, 2022, 12:36 p.m. UTC | #3
On Thu, 21 Jul 2022 06:43:06 +0200, Nicolas Frattaroli wrote:
> The previously stated speed of sdr-104 is too high for the hardware
> to reliably communicate with some fast SD cards.
> 
> Lower this to sd-uhs-sdr50 to fix this.
> 
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")

Applied, thanks!

[1/1] arm64: dts: rockchip: Lower sd speed on quartz64-b
      commit: 1ea90b2d293fd8b1f3377c9ed08364ff6f2a8562

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
index 02d5f5a8ca03..528bb4e8ac77 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
@@ -506,7 +506,7 @@  &sdmmc0 {
 	disable-wp;
 	pinctrl-names = "default";
 	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
-	sd-uhs-sdr104;
+	sd-uhs-sdr50;
 	vmmc-supply = <&vcc3v3_sd>;
 	vqmmc-supply = <&vccio_sd>;
 	status = "okay";