[v4,0/2] PCI: dwc: Add support for 64-bit MSI target addresses

Message

William McVicker Aug. 12, 2022, 12:03 a.m. UTC

Hi All,

I've updated the series to address the review comments. Refer to the v4
history below for the changes. Please take a look and thanks again for the
reviews!

Regards,
Will

Will McVicker (2):
  PCI: dwc: Drop dependency on ZONE_DMA32
  PCI: dwc: Add support for 64-bit MSI target address

v4:
 * Updated commit descriptions.
 * Renamed msi_64b -> msi_64bit.
 * Dropped msi_64bit ternary use.
 * Dropped export of dw_pcie_msi_capabilities.

v3:
  * Switched to a managed DMA allocation.
  * Simplified the DMA allocation cleanup.
  * Dropped msi_page from struct dw_pcie_rp.
  * Allocating a u64 instead of a full page.

v2:
  * Fixed build error caught by kernel test robot
  * Fixed error handling reported by Isaac Manjarres

 .../pci/controller/dwc/pcie-designware-host.c | 42 +++++++++----------
 drivers/pci/controller/dwc/pcie-designware.c  |  8 ++++
 drivers/pci/controller/dwc/pcie-designware.h  |  2 +-
 3 files changed, 28 insertions(+), 24 deletions(-)


base-commit: 2ae08b36c06ea8df73a79f6b80ff7964e006e9e3

Comments

Lorenzo Pieralisi Aug. 23, 2022, 10:01 a.m. UTC | #1

On Fri, Aug 12, 2022 at 12:03:24AM +0000, Will McVicker wrote:
> Hi All,
> 
> I've updated the series to address the review comments. Refer to the v4
> history below for the changes. Please take a look and thanks again for the
> reviews!

This series looks OK to me - it'd be good if Christoph/Robin can have
a look though before merging it.

Lorenzo

> Regards,
> Will
> 
> Will McVicker (2):
>   PCI: dwc: Drop dependency on ZONE_DMA32
>   PCI: dwc: Add support for 64-bit MSI target address
> 
> v4:
>  * Updated commit descriptions.
>  * Renamed msi_64b -> msi_64bit.
>  * Dropped msi_64bit ternary use.
>  * Dropped export of dw_pcie_msi_capabilities.
> 
> v3:
>   * Switched to a managed DMA allocation.
>   * Simplified the DMA allocation cleanup.
>   * Dropped msi_page from struct dw_pcie_rp.
>   * Allocating a u64 instead of a full page.
> 
> v2:
>   * Fixed build error caught by kernel test robot
>   * Fixed error handling reported by Isaac Manjarres
> 
>  .../pci/controller/dwc/pcie-designware-host.c | 42 +++++++++----------
>  drivers/pci/controller/dwc/pcie-designware.c  |  8 ++++
>  drivers/pci/controller/dwc/pcie-designware.h  |  2 +-
>  3 files changed, 28 insertions(+), 24 deletions(-)
> 
> 
> base-commit: 2ae08b36c06ea8df73a79f6b80ff7964e006e9e3
> -- 
> 2.37.1.559.g78731f0fdb-goog
>