mbox series

[-next,0/3] cifs: Use some helper function for preamble size

Message ID 20220823125202.1156172-1-zhangxiaoxu5@huawei.com (mailing list archive)
Headers show
Series cifs: Use some helper function for preamble size | expand

Message

Zhang Xiaoxu Aug. 23, 2022, 12:51 p.m. UTC 
*** BLURB HERE ***
The unfolded expression of header_preamble_size is too long, in addition, 
some expressions have specific semantics, e.g.:
  calculate the position of the mid,
  confirm it's smb2+ server or not.

Zhang Xiaoxu (3):
  cifs: Use help macro to get the header preamble size
  cifs: Use help macro to get the mid header size
  cifs: Add helper function to check smb2+ server

 fs/cifs/cifsencrypt.c |  3 +--
 fs/cifs/cifsglob.h    |  7 +++++++
 fs/cifs/connect.c     | 28 +++++++++++-----------------
 fs/cifs/transport.c   | 21 ++++++++++-----------
 4 files changed, 29 insertions(+), 30 deletions(-)

Comments

Paulo Alcantara Aug. 23, 2022, 5:23 p.m. UTC | #1 
Zhang Xiaoxu <zhangxiaoxu5@huawei.com> writes:

>
> *** BLURB HERE ***
> The unfolded expression of header_preamble_size is too long, in addition, 
> some expressions have specific semantics, e.g.:
>   calculate the position of the mid,
>   confirm it's smb2+ server or not.
>
> Zhang Xiaoxu (3):
>   cifs: Use help macro to get the header preamble size
>   cifs: Use help macro to get the mid header size
>   cifs: Add helper function to check smb2+ server
>
>  fs/cifs/cifsencrypt.c |  3 +--
>  fs/cifs/cifsglob.h    |  7 +++++++
>  fs/cifs/connect.c     | 28 +++++++++++-----------------
>  fs/cifs/transport.c   | 21 ++++++++++-----------
>  4 files changed, 29 insertions(+), 30 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Steve French Aug. 24, 2022, 5:57 a.m. UTC | #2 
tentatively merged into cifs-2.6.git for-next pending testing

On Tue, Aug 23, 2022 at 12:23 PM Paulo Alcantara <pc@cjr.nz> wrote:
>
> Zhang Xiaoxu <zhangxiaoxu5@huawei.com> writes:
>
> >
> > *** BLURB HERE ***
> > The unfolded expression of header_preamble_size is too long, in addition,
> > some expressions have specific semantics, e.g.:
> >   calculate the position of the mid,
> >   confirm it's smb2+ server or not.
> >
> > Zhang Xiaoxu (3):
> >   cifs: Use help macro to get the header preamble size
> >   cifs: Use help macro to get the mid header size
> >   cifs: Add helper function to check smb2+ server
> >
> >  fs/cifs/cifsencrypt.c |  3 +--
> >  fs/cifs/cifsglob.h    |  7 +++++++
> >  fs/cifs/connect.c     | 28 +++++++++++-----------------
> >  fs/cifs/transport.c   | 21 ++++++++++-----------
> >  4 files changed, 29 insertions(+), 30 deletions(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>