| Message ID | 20220727040022.139387-1-lihuafei1@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: Convert to ARCH_STACKWALK | expand |
On 2022/7/27 12:00, Li Huafei wrote: > This series mainly updates the ARM stack trace code to use the newer and > simpler arch_stack_walk() interface (see patches 3 and 4). Two issues > were fixed before that (see patches 1 and 2). > > v3: > - According to the discussion with Linus and Russell in v1: > - Add a comment about "regs[1]" in patch 2, and remove the > unnecessary ternary operator in the initialization of > "frame->ex_frame". > - Remove the patch "ARM: stacktrace: Allow stack trace saving for > non-current tasks", and keep the check for not being able to > unwind non-current tasks (including tasks running on other CPUs) > when CONFIG_SMP=y in patch 4. > - Rebase to linux-5.19-rc8. > > v2: https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/ > - As suggested by Mark, the commit logs for patch 4 and 5 were > refined for easy review. > > v1: https://lore.kernel.org/lkml/20220712021527.109921-1-lihuafei1@huawei.com/ > > Li Huafei (4): > ARM: stacktrace: Skip frame pointer boundary check for > call_with_stack() > ARM: stacktrace: Avoid duplicate saving of exception PC value > ARM: stacktrace: Make stack walk callback consistent with generic code > ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK > > arch/arm/Kconfig | 1 + > arch/arm/include/asm/stacktrace.h | 8 +- > arch/arm/kernel/perf_callchain.c | 9 +- > arch/arm/kernel/return_address.c | 9 +- > arch/arm/kernel/stacktrace.c | 191 ++++++++++++++---------------- > arch/arm/lib/call_with_stack.S | 2 + > 6 files changed, 110 insertions(+), 110 deletions(-) > Hi Russell， Do you have any more comments on this patch set? Can you add this patch set to your patch tracker? Thanks! Thanks, Huafei
On Thu, Aug 18, 2022 at 11:16 AM Li Huafei <lihuafei1@huawei.com> wrote: > Hi Russell， > > Do you have any more comments on this patch set? Can you add this patch > set to your patch tracker? Thanks! I would rebase the patch on v6.0-rc1 and resend then you can add it to Russell's patch tracker yourself, it's not very hard to use, there is good documentation for how to use it: https://www.arm.linux.org.uk/developer/patches/ Yours, Linus Walleij
On 2022/8/25 21:00, Linus Walleij wrote: > On Thu, Aug 18, 2022 at 11:16 AM Li Huafei <lihuafei1@huawei.com> wrote: > >> Hi Russell， >> >> Do you have any more comments on this patch set? Can you add this patch >> set to your patch tracker? Thanks! > > I would rebase the patch on v6.0-rc1 and resend then you can add it > to Russell's patch tracker yourself, it's not very hard to use, there is > good documentation for how to use it: > https://www.arm.linux.org.uk/developer/patches/ > It's done. Thank you for the tip. Thanks, Huafei > Yours, > Linus Walleij > . >
This series mainly updates the ARM stack trace code to use the newer and simpler arch_stack_walk() interface (see patches 3 and 4). Two issues were fixed before that (see patches 1 and 2). v3: - According to the discussion with Linus and Russell in v1: - Add a comment about "regs[1]" in patch 2, and remove the unnecessary ternary operator in the initialization of "frame->ex_frame". - Remove the patch "ARM: stacktrace: Allow stack trace saving for non-current tasks", and keep the check for not being able to unwind non-current tasks (including tasks running on other CPUs) when CONFIG_SMP=y in patch 4. - Rebase to linux-5.19-rc8. v2: https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/ - As suggested by Mark, the commit logs for patch 4 and 5 were refined for easy review. v1: https://lore.kernel.org/lkml/20220712021527.109921-1-lihuafei1@huawei.com/ Li Huafei (4): ARM: stacktrace: Skip frame pointer boundary check for call_with_stack() ARM: stacktrace: Avoid duplicate saving of exception PC value ARM: stacktrace: Make stack walk callback consistent with generic code ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK arch/arm/Kconfig | 1 + arch/arm/include/asm/stacktrace.h | 8 +- arch/arm/kernel/perf_callchain.c | 9 +- arch/arm/kernel/return_address.c | 9 +- arch/arm/kernel/stacktrace.c | 191 ++++++++++++++---------------- arch/arm/lib/call_with_stack.S | 2 + 6 files changed, 110 insertions(+), 110 deletions(-)