| Message ID | 20220824094029.1634519-10-bmeng.cn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/qtest: Enable running qtest on Windows | expand |
On Mittwoch, 24. August 2022 11:39:47 CEST Bin Meng wrote: > From: Bin Meng <bin.meng@windriver.com> > > Use the same g_mkdir_with_parents() call to create a directory on > all platforms. The same would be g_mkdir(), not g_mkdir_with_parents(), so please use that instead. > Signed-off-by: Bin Meng <bin.meng@windriver.com> > --- > > fsdev/virtfs-proxy-helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c > index 2dde27922f..d0cf76d6d1 100644 > --- a/fsdev/virtfs-proxy-helper.c > +++ b/fsdev/virtfs-proxy-helper.c > @@ -639,7 +639,7 @@ static int do_create_others(int type, struct iovec > *iovec) if (retval < 0) { > goto err_out; > } > - retval = mkdir(path.data, mode); > + retval = g_mkdir_with_parents(path.data, mode); > break; > case T_SYMLINK: > retval = proxy_unmarshal(iovec, offset, "ss", &oldpath, &path);
On Fri, Aug 26, 2022 at 6:09 PM Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > > On Mittwoch, 24. August 2022 11:39:47 CEST Bin Meng wrote: > > From: Bin Meng <bin.meng@windriver.com> > > > > Use the same g_mkdir_with_parents() call to create a directory on > > all platforms. > > The same would be g_mkdir(), not g_mkdir_with_parents(), so please use that > instead. > No, g_mkdir() is a deprecated API. Search result (https://docs.gtk.org/glib/?q=mkdir) shows only g_mkdir_with_parents(). Regards, Bin
On Freitag, 26. August 2022 12:30:20 CEST Bin Meng wrote: > On Fri, Aug 26, 2022 at 6:09 PM Christian Schoenebeck > > <qemu_oss@crudebyte.com> wrote: > > On Mittwoch, 24. August 2022 11:39:47 CEST Bin Meng wrote: > > > From: Bin Meng <bin.meng@windriver.com> > > > > > > Use the same g_mkdir_with_parents() call to create a directory on > > > all platforms. > > > > The same would be g_mkdir(), not g_mkdir_with_parents(), so please use > > that > > instead. > > No, g_mkdir() is a deprecated API. Where did you got that from? AFAICS g_mkdir() does not seem to be deprecated: https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.c#L1201 https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.h#L131 > Search result (https://docs.gtk.org/glib/?q=mkdir) shows only > g_mkdir_with_parents(). Yeah, but that does not say that it was deprecated. > Regards, > Bin
On Fri, Aug 26, 2022 at 7:16 PM Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > > On Freitag, 26. August 2022 12:30:20 CEST Bin Meng wrote: > > On Fri, Aug 26, 2022 at 6:09 PM Christian Schoenebeck > > > > <qemu_oss@crudebyte.com> wrote: > > > On Mittwoch, 24. August 2022 11:39:47 CEST Bin Meng wrote: > > > > From: Bin Meng <bin.meng@windriver.com> > > > > > > > > Use the same g_mkdir_with_parents() call to create a directory on > > > > all platforms. > > > > > > The same would be g_mkdir(), not g_mkdir_with_parents(), so please use > > > that > > > instead. > > > > No, g_mkdir() is a deprecated API. > > Where did you got that from? AFAICS g_mkdir() does not seem to be deprecated: > https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.c#L1201 > https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.h#L131 > > > Search result (https://docs.gtk.org/glib/?q=mkdir) shows only > > g_mkdir_with_parents(). > > Yeah, but that does not say that it was deprecated. > Umm, correct. However I don't remember where I got the statement that it was deprecated. Maybe I was misled by the doc. Do you know why does the doc not document g_mkdir()? Regards, Bin
On Freitag, 26. August 2022 14:38:27 CEST Bin Meng wrote: > On Fri, Aug 26, 2022 at 7:16 PM Christian Schoenebeck > > <qemu_oss@crudebyte.com> wrote: > > On Freitag, 26. August 2022 12:30:20 CEST Bin Meng wrote: > > > On Fri, Aug 26, 2022 at 6:09 PM Christian Schoenebeck > > > > > > <qemu_oss@crudebyte.com> wrote: > > > > On Mittwoch, 24. August 2022 11:39:47 CEST Bin Meng wrote: > > > > > From: Bin Meng <bin.meng@windriver.com> > > > > > > > > > > Use the same g_mkdir_with_parents() call to create a directory on > > > > > all platforms. > > > > > > > > The same would be g_mkdir(), not g_mkdir_with_parents(), so please use > > > > that > > > > instead. > > > > > > No, g_mkdir() is a deprecated API. > > > > Where did you got that from? AFAICS g_mkdir() does not seem to be > > deprecated: > > https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.c#L1201 > > https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.h#L131> > > > Search result (https://docs.gtk.org/glib/?q=mkdir) shows only > > > g_mkdir_with_parents(). > > > > Yeah, but that does not say that it was deprecated. > > Umm, correct. However I don't remember where I got the statement that > it was deprecated. > > Maybe I was misled by the doc. Do you know why does the doc not > document g_mkdir()? Maybe gtk-doc does not define G_STDIO_WRAP_ON_UNIX? Other functions like g_chmod() are missing in the generated docs as well, whereas g_access() et al. are there, those are declared in both conditions. > Regards, > Bin
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index 2dde27922f..d0cf76d6d1 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -639,7 +639,7 @@ static int do_create_others(int type, struct iovec *iovec) if (retval < 0) { goto err_out; } - retval = mkdir(path.data, mode); + retval = g_mkdir_with_parents(path.data, mode); break; case T_SYMLINK: retval = proxy_unmarshal(iovec, offset, "ss", &oldpath, &path);