diff mbox series

[kernelshark] kernel-shark: Build missed_event as GUI plugin

Message ID 20220824135309.5347-1-dwagner@suse.de (mailing list archive)
State Accepted
Commit 984130f1fdab954934a8e4ed34dc38131c3dd97d
Headers show
Series [kernelshark] kernel-shark: Build missed_event as GUI plugin | expand

Commit Message

Daniel Wagner Aug. 24, 2022, 1:53 p.m. UTC
missed_events depends on GUI elements hence it should be build as GUI
plugin.

Signged-off-by: Daniel Wagner <dwagner@suse.de>
---

I had some build errors due to global build flags in our build service:

  Linker flags : -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now

 src/plugins/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Yordan Karadzhov Aug. 26, 2022, 3:20 p.m. UTC | #1
Thanks Daniel!
Yordan

On 8/24/22 16:53, Daniel Wagner wrote:
> missed_events depends on GUI elements hence it should be build as GUI
> plugin.
> 
> Signged-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> 
> I had some build errors due to global build flags in our build service:
> 
>    Linker flags : -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now
> 
>   src/plugins/CMakeLists.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/plugins/CMakeLists.txt b/src/plugins/CMakeLists.txt
> index e9d906863424..49aee3ed7560 100644
> --- a/src/plugins/CMakeLists.txt
> +++ b/src/plugins/CMakeLists.txt
> @@ -61,8 +61,8 @@ if (Qt5Widgets_FOUND AND TT_FONT_FILE)
>   
>   endif (Qt5Widgets_FOUND AND TT_FONT_FILE)
>   
> -BUILD_PLUGIN(NAME missed_events
> -             SOURCE missed_events.c MissedEvents.cpp)
> +BUILD_GUI_PLUGIN(NAME missed_events
> +		 SOURCE missed_events.c MissedEvents.cpp)
>   list(APPEND PLUGIN_LIST "missed_events")
>   
>   install(TARGETS ${PLUGIN_LIST}
diff mbox series

Patch

diff --git a/src/plugins/CMakeLists.txt b/src/plugins/CMakeLists.txt
index e9d906863424..49aee3ed7560 100644
--- a/src/plugins/CMakeLists.txt
+++ b/src/plugins/CMakeLists.txt
@@ -61,8 +61,8 @@  if (Qt5Widgets_FOUND AND TT_FONT_FILE)
 
 endif (Qt5Widgets_FOUND AND TT_FONT_FILE)
 
-BUILD_PLUGIN(NAME missed_events
-             SOURCE missed_events.c MissedEvents.cpp)
+BUILD_GUI_PLUGIN(NAME missed_events
+		 SOURCE missed_events.c MissedEvents.cpp)
 list(APPEND PLUGIN_LIST "missed_events")
 
 install(TARGETS ${PLUGIN_LIST}