diff mbox series

[net-next] Documentation: bonding: clarify supported modes for tlb_dynamic_lb

Message ID 20220826154738.4039-1-ffmancera@riseup.net (mailing list archive)
State Accepted
Commit fa8724478e64dcf6a45de9067004dcca07244934
Delegated to: Netdev Maintainers
Headers show
Series [net-next] Documentation: bonding: clarify supported modes for tlb_dynamic_lb | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 9 maintainers not CCed: edumazet@google.com j.vosburgh@gmail.com pabeni@redhat.com linux-doc@vger.kernel.org andy@greyhouse.net vfalico@gmail.com kuba@kernel.org corbet@lwn.net davem@davemloft.net
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Fernando F. Mancera Aug. 26, 2022, 3:47 p.m. UTC
tlb_dynamic_lb bonding option is compatible with balance-tlb and balance-alb
modes. In order to be consistent with other option documentation, it should
mention both modes not only balance-tlb.

Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
---
 Documentation/networking/bonding.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jay Vosburgh Aug. 29, 2022, 12:38 a.m. UTC | #1
Fernando Fernandez Mancera <ffmancera@riseup.net> wrote:

>tlb_dynamic_lb bonding option is compatible with balance-tlb and balance-alb
>modes. In order to be consistent with other option documentation, it should
>mention both modes not only balance-tlb.
>
>Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>


>---
> Documentation/networking/bonding.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst
>index 7823a069a903..96cd7a26f3d9 100644
>--- a/Documentation/networking/bonding.rst
>+++ b/Documentation/networking/bonding.rst
>@@ -846,7 +846,7 @@ primary_reselect
> tlb_dynamic_lb
> 
> 	Specifies if dynamic shuffling of flows is enabled in tlb
>-	mode. The value has no effect on any other modes.
>+	or alb mode. The value has no effect on any other modes.
> 
> 	The default behavior of tlb mode is to shuffle active flows across
> 	slaves based on the load in that interval. This gives nice lb
>-- 
>2.30.2
>
patchwork-bot+netdevbpf@kernel.org Aug. 31, 2022, 6:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 26 Aug 2022 17:47:38 +0200 you wrote:
> tlb_dynamic_lb bonding option is compatible with balance-tlb and balance-alb
> modes. In order to be consistent with other option documentation, it should
> mention both modes not only balance-tlb.
> 
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
> ---
>  Documentation/networking/bonding.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] Documentation: bonding: clarify supported modes for tlb_dynamic_lb
    https://git.kernel.org/netdev/net-next/c/fa8724478e64

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst
index 7823a069a903..96cd7a26f3d9 100644
--- a/Documentation/networking/bonding.rst
+++ b/Documentation/networking/bonding.rst
@@ -846,7 +846,7 @@  primary_reselect
 tlb_dynamic_lb
 
 	Specifies if dynamic shuffling of flows is enabled in tlb
-	mode. The value has no effect on any other modes.
+	or alb mode. The value has no effect on any other modes.
 
 	The default behavior of tlb mode is to shuffle active flows across
 	slaves based on the load in that interval. This gives nice lb