| Message ID | 20220826191305.3215706-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] soc: imx: imx8mp-blk-ctrl: don't set power device name in | expand |
> Subject: [PATCH 1/3] soc: imx: imx8mp-blk-ctrl: don't set power device > name in > > Setting the device name after it has been registered confuses the sysfs > cleanup paths. This has already been fixed for the imx8m-blk-ctrl driver in > b64b46fbaa1d ("Revert "soc: imx: imx8m-blk-ctrl: set power device name""), > but the same problem exists in imx8mp-blk-ctrl. > > Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp- > blk-ctrl.c > index 4ca2ede6871b..9401df25c85a 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -529,7 +529,6 @@ static int imx8mp_blk_ctrl_probe(struct > platform_device *pdev) > ret = PTR_ERR(domain->power_dev); > goto cleanup_pds; > } > - dev_set_name(domain->power_dev, "%s", data->name); > > domain->genpd.name = data->name; > domain->genpd.power_on = imx8mp_blk_ctrl_power_on; > -- > 2.30.2
On Fri, Aug 26, 2022 at 09:13:03PM +0200, Lucas Stach wrote: > Setting the device name after it has been registered confuses the sysfs > cleanup paths. This has already been fixed for the imx8m-blk-ctrl driver in > b64b46fbaa1d ("Revert "soc: imx: imx8m-blk-ctrl: set power device name""), > but the same problem exists in imx8mp-blk-ctrl. > > Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> For patch subject, what does "in" mean there? Should we just drop it or add something after it? Shawn > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > index 4ca2ede6871b..9401df25c85a 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -529,7 +529,6 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev) > ret = PTR_ERR(domain->power_dev); > goto cleanup_pds; > } > - dev_set_name(domain->power_dev, "%s", data->name); > > domain->genpd.name = data->name; > domain->genpd.power_on = imx8mp_blk_ctrl_power_on; > -- > 2.30.2 >
On Fri, Aug 26, 2022 at 09:13:03PM +0200, Lucas Stach wrote: > Setting the device name after it has been registered confuses the sysfs > cleanup paths. This has already been fixed for the imx8m-blk-ctrl driver in > b64b46fbaa1d ("Revert "soc: imx: imx8m-blk-ctrl: set power device name""), > but the same problem exists in imx8mp-blk-ctrl. > > Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Dropped "in" from subject and applied, thanks!
diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c index 4ca2ede6871b..9401df25c85a 100644 --- a/drivers/soc/imx/imx8mp-blk-ctrl.c +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c @@ -529,7 +529,6 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev) ret = PTR_ERR(domain->power_dev); goto cleanup_pds; } - dev_set_name(domain->power_dev, "%s", data->name); domain->genpd.name = data->name; domain->genpd.power_on = imx8mp_blk_ctrl_power_on;
Setting the device name after it has been registered confuses the sysfs cleanup paths. This has already been fixed for the imx8m-blk-ctrl driver in b64b46fbaa1d ("Revert "soc: imx: imx8m-blk-ctrl: set power device name""), but the same problem exists in imx8mp-blk-ctrl. Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- drivers/soc/imx/imx8mp-blk-ctrl.c | 1 - 1 file changed, 1 deletion(-)