| Message ID | 20220829072035.1539399-1-neal_liu@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: aspeed: fix build module error | expand |
On Mon, Aug 29, 2022 at 8:42 AM Neal Liu <neal_liu@aspeedtech.com> wrote: > > If CONFIG_MODULES=y and CONFIG_CRYPTO_DEV_ASPEED=m, > build modpost would be failed. > > Error messages: > ERROR: modpost: "aspeed_register_hace_hash_algs" > [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! > ERROR: modpost: "aspeed_unregister_hace_hash_algs" > [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! > > Change build sequence to fix this. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> Tested-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
On Mon, Aug 29, 2022 at 03:20:35PM +0800, Neal Liu wrote: > > obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) += aspeed-hace-hash.o > hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace-hash.o > obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) += aspeed-hace-crypto.o > hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace-crypto.o Why are these two files being included twice? I think the obj- lines should be deleted. Thanks,
> -----Original Message----- > From: Herbert Xu <herbert@gondor.apana.org.au> > Sent: Friday, September 2, 2022 6:29 PM > To: Neal Liu <neal_liu@aspeedtech.com> > Cc: David S . Miller <davem@davemloft.net>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; linux-aspeed@lists.ozlabs.org; > linux-crypto@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; kernel > test robot <lkp@intel.com> > Subject: Re: [PATCH] crypto: aspeed: fix build module error > > On Mon, Aug 29, 2022 at 03:20:35PM +0800, Neal Liu wrote: > > > > obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) += aspeed-hace-hash.o > > hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := > aspeed-hace-hash.o > > obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) += > aspeed-hace-crypto.o > > hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := > > aspeed-hace-crypto.o > > Why are these two files being included twice? I think the obj- lines should be > deleted. > > Thanks, I'll send new patch within removing the redundant obj- lines. Thanks. > -- > Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: > http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/crypto/aspeed/Makefile b/drivers/crypto/aspeed/Makefile index 421e2ca9c53e..4cc1a7ad3652 100644 --- a/drivers/crypto/aspeed/Makefile +++ b/drivers/crypto/aspeed/Makefile @@ -1,9 +1,9 @@ -obj-$(CONFIG_CRYPTO_DEV_ASPEED) += aspeed_crypto.o -aspeed_crypto-objs := aspeed-hace.o \ - $(hace-hash-y) \ - $(hace-crypto-y) - obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) += aspeed-hace-hash.o hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace-hash.o obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) += aspeed-hace-crypto.o hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace-crypto.o + +obj-$(CONFIG_CRYPTO_DEV_ASPEED) += aspeed_crypto.o +aspeed_crypto-objs := aspeed-hace.o \ + $(hace-hash-y) \ + $(hace-crypto-y)
If CONFIG_MODULES=y and CONFIG_CRYPTO_DEV_ASPEED=m, build modpost would be failed. Error messages: ERROR: modpost: "aspeed_register_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! ERROR: modpost: "aspeed_unregister_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! Change build sequence to fix this. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> --- drivers/crypto/aspeed/Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)