| Message ID | 20220829235429.17902-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Documentation: filesystems: correct possessive "its" | expand |
On Mon, Aug 29, 2022 at 04:54:29PM -0700, Randy Dunlap wrote: > Change occurrences of "it's" that are possessive to "its" > so that they don't read as "it is". > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-f2fs-devel@lists.sourceforge.net > Cc: linux-xfs@vger.kernel.org > Cc: Christian Brauner <brauner@kernel.org> > Cc: Seth Forshee <sforshee@kernel.org> Looks correct to me, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > Documentation/filesystems/f2fs.rst | 2 +- > Documentation/filesystems/idmappings.rst | 2 +- > Documentation/filesystems/qnx6.rst | 2 +- > Documentation/filesystems/xfs-delayed-logging-design.rst | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) > > --- a/Documentation/filesystems/f2fs.rst > +++ b/Documentation/filesystems/f2fs.rst > @@ -287,7 +287,7 @@ compress_algorithm=%s:%d Control compres > lz4 3 - 16 > zstd 1 - 22 > compress_log_size=%u Support configuring compress cluster size, the size will > - be 4KB * (1 << %u), 16KB is minimum size, also it's > + be 4KB * (1 << %u), 16KB is minimum size, also its > default size. > compress_extension=%s Support adding specified extension, so that f2fs can enable > compression on those corresponding files, e.g. if all files > --- a/Documentation/filesystems/idmappings.rst > +++ b/Documentation/filesystems/idmappings.rst > @@ -661,7 +661,7 @@ idmappings:: > mount idmapping: u0:k10000:r10000 > > Assume a file owned by ``u1000`` is read from disk. The filesystem maps this id > -to ``k21000`` according to it's idmapping. This is what is stored in the > +to ``k21000`` according to its idmapping. This is what is stored in the > inode's ``i_uid`` and ``i_gid`` fields. > > When the caller queries the ownership of this file via ``stat()`` the kernel > --- a/Documentation/filesystems/qnx6.rst > +++ b/Documentation/filesystems/qnx6.rst > @@ -176,7 +176,7 @@ Then userspace. > The requirement for a static, fixed preallocated system area comes from how > qnx6fs deals with writes. > > -Each superblock got it's own half of the system area. So superblock #1 > +Each superblock got its own half of the system area. So superblock #1 > always uses blocks from the lower half while superblock #2 just writes to > blocks represented by the upper half bitmap system area bits. > > --- a/Documentation/filesystems/xfs-delayed-logging-design.rst > +++ b/Documentation/filesystems/xfs-delayed-logging-design.rst > @@ -551,14 +551,14 @@ Essentially, this shows that an item tha > and relogged, so any tracking must be separate to the AIL infrastructure. As > such, we cannot reuse the AIL list pointers for tracking committed items, nor > can we store state in any field that is protected by the AIL lock. Hence the > -committed item tracking needs it's own locks, lists and state fields in the log > +committed item tracking needs its own locks, lists and state fields in the log > item. > > Similar to the AIL, tracking of committed items is done through a new list > called the Committed Item List (CIL). The list tracks log items that have been > committed and have formatted memory buffers attached to them. It tracks objects > in transaction commit order, so when an object is relogged it is removed from > -it's place in the list and re-inserted at the tail. This is entirely arbitrary > +its place in the list and re-inserted at the tail. This is entirely arbitrary > and done to make it easy for debugging - the last items in the list are the > ones that are most recently modified. Ordering of the CIL is not necessary for > transactional integrity (as discussed in the next section) so the ordering is > @@ -884,7 +884,7 @@ pin the object the first time it is inse > the CIL during a transaction commit, then we do not pin it again. Because there > can be multiple outstanding checkpoint contexts, we can still see elevated pin > counts, but as each checkpoint completes the pin count will retain the correct > -value according to it's context. > +value according to its context. > > Just to make matters more slightly more complex, this checkpoint level context > for the pin count means that the pinning of an item must take place under the
On Mon, Aug 29, 2022 at 04:54:29PM -0700, Randy Dunlap wrote: > Change occurrences of "it's" that are possessive to "its" > so that they don't read as "it is". > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-f2fs-devel@lists.sourceforge.net > Cc: linux-xfs@vger.kernel.org > Cc: Christian Brauner <brauner@kernel.org> > Cc: Seth Forshee <sforshee@kernel.org> > --- Thank you! Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
On 08/29, Randy Dunlap wrote: > Change occurrences of "it's" that are possessive to "its" > so that they don't read as "it is". > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-f2fs-devel@lists.sourceforge.net > Cc: linux-xfs@vger.kernel.org > Cc: Christian Brauner <brauner@kernel.org> > Cc: Seth Forshee <sforshee@kernel.org> For f2fs, Reviewed-by: Jaegeuk Kim <jaegeuk@kernel.org> Thanks, > --- > Documentation/filesystems/f2fs.rst | 2 +- > Documentation/filesystems/idmappings.rst | 2 +- > Documentation/filesystems/qnx6.rst | 2 +- > Documentation/filesystems/xfs-delayed-logging-design.rst | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) > > --- a/Documentation/filesystems/f2fs.rst > +++ b/Documentation/filesystems/f2fs.rst > @@ -287,7 +287,7 @@ compress_algorithm=%s:%d Control compres > lz4 3 - 16 > zstd 1 - 22 > compress_log_size=%u Support configuring compress cluster size, the size will > - be 4KB * (1 << %u), 16KB is minimum size, also it's > + be 4KB * (1 << %u), 16KB is minimum size, also its > default size. > compress_extension=%s Support adding specified extension, so that f2fs can enable > compression on those corresponding files, e.g. if all files > --- a/Documentation/filesystems/idmappings.rst > +++ b/Documentation/filesystems/idmappings.rst > @@ -661,7 +661,7 @@ idmappings:: > mount idmapping: u0:k10000:r10000 > > Assume a file owned by ``u1000`` is read from disk. The filesystem maps this id > -to ``k21000`` according to it's idmapping. This is what is stored in the > +to ``k21000`` according to its idmapping. This is what is stored in the > inode's ``i_uid`` and ``i_gid`` fields. > > When the caller queries the ownership of this file via ``stat()`` the kernel > --- a/Documentation/filesystems/qnx6.rst > +++ b/Documentation/filesystems/qnx6.rst > @@ -176,7 +176,7 @@ Then userspace. > The requirement for a static, fixed preallocated system area comes from how > qnx6fs deals with writes. > > -Each superblock got it's own half of the system area. So superblock #1 > +Each superblock got its own half of the system area. So superblock #1 > always uses blocks from the lower half while superblock #2 just writes to > blocks represented by the upper half bitmap system area bits. > > --- a/Documentation/filesystems/xfs-delayed-logging-design.rst > +++ b/Documentation/filesystems/xfs-delayed-logging-design.rst > @@ -551,14 +551,14 @@ Essentially, this shows that an item tha > and relogged, so any tracking must be separate to the AIL infrastructure. As > such, we cannot reuse the AIL list pointers for tracking committed items, nor > can we store state in any field that is protected by the AIL lock. Hence the > -committed item tracking needs it's own locks, lists and state fields in the log > +committed item tracking needs its own locks, lists and state fields in the log > item. > > Similar to the AIL, tracking of committed items is done through a new list > called the Committed Item List (CIL). The list tracks log items that have been > committed and have formatted memory buffers attached to them. It tracks objects > in transaction commit order, so when an object is relogged it is removed from > -it's place in the list and re-inserted at the tail. This is entirely arbitrary > +its place in the list and re-inserted at the tail. This is entirely arbitrary > and done to make it easy for debugging - the last items in the list are the > ones that are most recently modified. Ordering of the CIL is not necessary for > transactional integrity (as discussed in the next section) so the ordering is > @@ -884,7 +884,7 @@ pin the object the first time it is inse > the CIL during a transaction commit, then we do not pin it again. Because there > can be multiple outstanding checkpoint contexts, we can still see elevated pin > counts, but as each checkpoint completes the pin count will retain the correct > -value according to it's context. > +value according to its context. > > Just to make matters more slightly more complex, this checkpoint level context > for the pin count means that the pinning of an item must take place under the
On Mon, Aug 29, 2022 at 04:54:29PM -0700, Randy Dunlap wrote: > compress_log_size=%u Support configuring compress cluster size, the size will > - be 4KB * (1 << %u), 16KB is minimum size, also it's > + be 4KB * (1 << %u), 16KB is minimum size, also its > default size. That one doesn't look like possesive to me - more like "default size is 16KB and values below that are not allowed"...
On Tue, Aug 30, 2022 at 10:01:33PM +0100, Al Viro wrote: > On Mon, Aug 29, 2022 at 04:54:29PM -0700, Randy Dunlap wrote: > > compress_log_size=%u Support configuring compress cluster size, the size will > > - be 4KB * (1 << %u), 16KB is minimum size, also it's > > + be 4KB * (1 << %u), 16KB is minimum size, also its > > default size. > > That one doesn't look like possesive to me - more like "default size is 16KB and > values below that are not allowed"... That being said, it could also be rewritten to be easier to understand. e.g., "The default and minimum size is 16kb." - Ted
On 8/30/22 14:56, Theodore Ts'o wrote: > On Tue, Aug 30, 2022 at 10:01:33PM +0100, Al Viro wrote: >> On Mon, Aug 29, 2022 at 04:54:29PM -0700, Randy Dunlap wrote: >>> compress_log_size=%u Support configuring compress cluster size, the size will >>> - be 4KB * (1 << %u), 16KB is minimum size, also it's >>> + be 4KB * (1 << %u), 16KB is minimum size, also its >>> default size. >> >> That one doesn't look like possesive to me - more like "default size is 16KB and >> values below that are not allowed"... I have to disagree about the possessive part... > That being said, it could also be rewritten to be easier to > understand. e.g., "The default and minimum size is 16kb." but sure, it can be rewritten. thanks.
--- a/Documentation/filesystems/f2fs.rst +++ b/Documentation/filesystems/f2fs.rst @@ -287,7 +287,7 @@ compress_algorithm=%s:%d Control compres lz4 3 - 16 zstd 1 - 22 compress_log_size=%u Support configuring compress cluster size, the size will - be 4KB * (1 << %u), 16KB is minimum size, also it's + be 4KB * (1 << %u), 16KB is minimum size, also its default size. compress_extension=%s Support adding specified extension, so that f2fs can enable compression on those corresponding files, e.g. if all files --- a/Documentation/filesystems/idmappings.rst +++ b/Documentation/filesystems/idmappings.rst @@ -661,7 +661,7 @@ idmappings:: mount idmapping: u0:k10000:r10000 Assume a file owned by ``u1000`` is read from disk. The filesystem maps this id -to ``k21000`` according to it's idmapping. This is what is stored in the +to ``k21000`` according to its idmapping. This is what is stored in the inode's ``i_uid`` and ``i_gid`` fields. When the caller queries the ownership of this file via ``stat()`` the kernel --- a/Documentation/filesystems/qnx6.rst +++ b/Documentation/filesystems/qnx6.rst @@ -176,7 +176,7 @@ Then userspace. The requirement for a static, fixed preallocated system area comes from how qnx6fs deals with writes. -Each superblock got it's own half of the system area. So superblock #1 +Each superblock got its own half of the system area. So superblock #1 always uses blocks from the lower half while superblock #2 just writes to blocks represented by the upper half bitmap system area bits. --- a/Documentation/filesystems/xfs-delayed-logging-design.rst +++ b/Documentation/filesystems/xfs-delayed-logging-design.rst @@ -551,14 +551,14 @@ Essentially, this shows that an item tha and relogged, so any tracking must be separate to the AIL infrastructure. As such, we cannot reuse the AIL list pointers for tracking committed items, nor can we store state in any field that is protected by the AIL lock. Hence the -committed item tracking needs it's own locks, lists and state fields in the log +committed item tracking needs its own locks, lists and state fields in the log item. Similar to the AIL, tracking of committed items is done through a new list called the Committed Item List (CIL). The list tracks log items that have been committed and have formatted memory buffers attached to them. It tracks objects in transaction commit order, so when an object is relogged it is removed from -it's place in the list and re-inserted at the tail. This is entirely arbitrary +its place in the list and re-inserted at the tail. This is entirely arbitrary and done to make it easy for debugging - the last items in the list are the ones that are most recently modified. Ordering of the CIL is not necessary for transactional integrity (as discussed in the next section) so the ordering is @@ -884,7 +884,7 @@ pin the object the first time it is inse the CIL during a transaction commit, then we do not pin it again. Because there can be multiple outstanding checkpoint contexts, we can still see elevated pin counts, but as each checkpoint completes the pin count will retain the correct -value according to it's context. +value according to its context. Just to make matters more slightly more complex, this checkpoint level context for the pin count means that the pinning of an item must take place under the
Change occurrences of "it's" that are possessive to "its" so that they don't read as "it is". Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Jonathan Corbet <corbet@lwn.net> Cc: linux-fsdevel@vger.kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net Cc: linux-xfs@vger.kernel.org Cc: Christian Brauner <brauner@kernel.org> Cc: Seth Forshee <sforshee@kernel.org> --- Documentation/filesystems/f2fs.rst | 2 +- Documentation/filesystems/idmappings.rst | 2 +- Documentation/filesystems/qnx6.rst | 2 +- Documentation/filesystems/xfs-delayed-logging-design.rst | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-)